From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E142DA0C4D for ; Tue, 12 Oct 2021 23:14:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C7BD14113F; Tue, 12 Oct 2021 23:14:45 +0200 (CEST) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 1C8C1410FF for ; Tue, 12 Oct 2021 23:14:42 +0200 (CEST) Received: by mail-pl1-f182.google.com with SMTP id 21so359552plo.13 for ; Tue, 12 Oct 2021 14:14:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=uzE/5hPIBWalBMAEnEiuqwZh+rreoMltsLU1SezyIwQ=; b=Nl/8G2GA2g7KAqlnDWBDPFUiK9AXoq0TsxHDl8DwDM63Xd3MyeJwprCN9PrNvoS4Xz zuPxrmXmPzPe9Zrzi+PtbunK8m13R7OpF0C2H7yZxZvoP3kMVU/wXm5t2CWjIwuT4hk+ f/Hq4C7wxfXb9M3mjWNU1Abbwq/AYsi9rTzaw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=uzE/5hPIBWalBMAEnEiuqwZh+rreoMltsLU1SezyIwQ=; b=T58YvB7GBz6KA9uP53/iXCqpOUdl030iL2ISdAFZw57BqRyO68nmcz5x3k24trXoKd sHHw76HBpoBM/8HxMXyK4kOhtNz7HndLo6Rn94zJMLcvk1v2ixS/5I7fej3Nj0+j7/ru l5vlwZioXDIMulKFl+ZQdj8iRvlEup57BLwiAaoL3CF7HFYJtTrLSOfAMVCsY2BNwFRa 6tp7gOou1A0BqdcCROQ3YKKx6hVDnQ/V/39kAHq2C38G+gT0fu10V0CRnOSSC69ZrwE0 ZHC2Dnzud8ywZN/Y7TqInTVSXBJSNQVg47Hcixg6/NZ3ggpKhAN+9ZMBQ17d77TFYG6N sldw== X-Gm-Message-State: AOAM533h3gH+vp4g/8gFuXBj8LhYIFB7QlWk/DsUBBoGpVKa+DJh6pe6 5kr6gApCNKOpTB1wJA4HWp12pA== X-Google-Smtp-Source: ABdhPJxOy/4d20IzBlimX1gOxjMh3Z84QhLUglWo+eRRKjE/Nv9hLNYAudKpwzhZZ1pHhZePHRsvRQ== X-Received: by 2002:a17:90b:390b:: with SMTP id ob11mr8794459pjb.145.1634073281228; Tue, 12 Oct 2021 14:14:41 -0700 (PDT) Received: from localhost.localdomain ([136.52.99.246]) by smtp.gmail.com with ESMTPSA id f18sm7585705pfa.60.2021.10.12.14.14.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Oct 2021 14:14:40 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com, stable@dpdk.org, Lance Richardson Date: Tue, 12 Oct 2021 14:14:35 -0700 Message-Id: <20211012211436.70846-3-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) In-Reply-To: <20211012211436.70846-1-ajit.khaparde@broadcom.com> References: <20211012211436.70846-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000007bb74f05ce2e551c" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [dpdk-stable] [PATCH v3 2/3] net/bnxt: fix Rx queue state on start X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" --0000000000007bb74f05ce2e551c Content-Transfer-Encoding: 8bit Fix Rx queue state on device start. The state of Rx queues could be incorrect in some cases because instead of updating the state for all the Rx queues, we are updating it for queues in a VNIC. Fixes: 0105ea1296c9 ("net/bnxt: support runtime queue setup") Cc: stable@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson --- drivers/net/bnxt/bnxt_ethdev.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index aa7e7fdc85..a98f93ab29 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -482,12 +482,6 @@ static int bnxt_setup_one_vnic(struct bnxt *bp, uint16_t vnic_id) rxq->vnic->fw_grp_ids[j] = INVALID_HW_RING_ID; else vnic->rx_queue_cnt++; - - if (!rxq->rx_deferred_start) { - bp->eth_dev->data->rx_queue_state[j] = - RTE_ETH_QUEUE_STATE_STARTED; - rxq->rx_started = true; - } } PMD_DRV_LOG(DEBUG, "vnic->rx_queue_cnt = %d\n", vnic->rx_queue_cnt); @@ -824,6 +818,16 @@ static int bnxt_start_nic(struct bnxt *bp) } } + for (j = 0; j < bp->rx_nr_rings; j++) { + struct bnxt_rx_queue *rxq = bp->rx_queues[j]; + + if (!rxq->rx_deferred_start) { + bp->eth_dev->data->rx_queue_state[j] = + RTE_ETH_QUEUE_STATE_STARTED; + rxq->rx_started = true; + } + } + rc = bnxt_hwrm_cfa_l2_set_rx_mask(bp, &bp->vnic_info[0], 0, NULL); if (rc) { PMD_DRV_LOG(ERR, -- 2.30.1 (Apple Git-130) --0000000000007bb74f05ce2e551c--