* [dpdk-stable] [PATCH v3 2/3] net/bnxt: fix Rx queue state on start [not found] ` <20211012211436.70846-1-ajit.khaparde@broadcom.com> @ 2021-10-12 21:14 ` Ajit Khaparde 0 siblings, 0 replies; 2+ messages in thread From: Ajit Khaparde @ 2021-10-12 21:14 UTC (permalink / raw) To: dev; +Cc: ferruh.yigit, stable, Lance Richardson [-- Attachment #1: Type: text/plain, Size: 1536 bytes --] Fix Rx queue state on device start. The state of Rx queues could be incorrect in some cases because instead of updating the state for all the Rx queues, we are updating it for queues in a VNIC. Fixes: 0105ea1296c9 ("net/bnxt: support runtime queue setup") Cc: stable@dpdk.org Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com> Reviewed-by: Lance Richardson <lance.richardson@broadcom.com> --- drivers/net/bnxt/bnxt_ethdev.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index aa7e7fdc85..a98f93ab29 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -482,12 +482,6 @@ static int bnxt_setup_one_vnic(struct bnxt *bp, uint16_t vnic_id) rxq->vnic->fw_grp_ids[j] = INVALID_HW_RING_ID; else vnic->rx_queue_cnt++; - - if (!rxq->rx_deferred_start) { - bp->eth_dev->data->rx_queue_state[j] = - RTE_ETH_QUEUE_STATE_STARTED; - rxq->rx_started = true; - } } PMD_DRV_LOG(DEBUG, "vnic->rx_queue_cnt = %d\n", vnic->rx_queue_cnt); @@ -824,6 +818,16 @@ static int bnxt_start_nic(struct bnxt *bp) } } + for (j = 0; j < bp->rx_nr_rings; j++) { + struct bnxt_rx_queue *rxq = bp->rx_queues[j]; + + if (!rxq->rx_deferred_start) { + bp->eth_dev->data->rx_queue_state[j] = + RTE_ETH_QUEUE_STATE_STARTED; + rxq->rx_started = true; + } + } + rc = bnxt_hwrm_cfa_l2_set_rx_mask(bp, &bp->vnic_info[0], 0, NULL); if (rc) { PMD_DRV_LOG(ERR, -- 2.30.1 (Apple Git-130) ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <20211012211845.71121-1-ajit.khaparde@broadcom.com>]
* [dpdk-stable] [PATCH v4 2/3] net/bnxt: fix Rx queue state on start [not found] ` <20211012211845.71121-1-ajit.khaparde@broadcom.com> @ 2021-10-12 21:18 ` Ajit Khaparde 0 siblings, 0 replies; 2+ messages in thread From: Ajit Khaparde @ 2021-10-12 21:18 UTC (permalink / raw) To: dev; +Cc: ferruh.yigit, stable, Lance Richardson [-- Attachment #1: Type: text/plain, Size: 1536 bytes --] Fix Rx queue state on device start. The state of Rx queues could be incorrect in some cases because instead of updating the state for all the Rx queues, we are updating it for queues in a VNIC. Fixes: 0105ea1296c9 ("net/bnxt: support runtime queue setup") Cc: stable@dpdk.org Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com> Reviewed-by: Lance Richardson <lance.richardson@broadcom.com> --- drivers/net/bnxt/bnxt_ethdev.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index aa7e7fdc85..a98f93ab29 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -482,12 +482,6 @@ static int bnxt_setup_one_vnic(struct bnxt *bp, uint16_t vnic_id) rxq->vnic->fw_grp_ids[j] = INVALID_HW_RING_ID; else vnic->rx_queue_cnt++; - - if (!rxq->rx_deferred_start) { - bp->eth_dev->data->rx_queue_state[j] = - RTE_ETH_QUEUE_STATE_STARTED; - rxq->rx_started = true; - } } PMD_DRV_LOG(DEBUG, "vnic->rx_queue_cnt = %d\n", vnic->rx_queue_cnt); @@ -824,6 +818,16 @@ static int bnxt_start_nic(struct bnxt *bp) } } + for (j = 0; j < bp->rx_nr_rings; j++) { + struct bnxt_rx_queue *rxq = bp->rx_queues[j]; + + if (!rxq->rx_deferred_start) { + bp->eth_dev->data->rx_queue_state[j] = + RTE_ETH_QUEUE_STATE_STARTED; + rxq->rx_started = true; + } + } + rc = bnxt_hwrm_cfa_l2_set_rx_mask(bp, &bp->vnic_info[0], 0, NULL); if (rc) { PMD_DRV_LOG(ERR, -- 2.30.1 (Apple Git-130) ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-12 21:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <dbe8f02f-461a-0806-923d-122d23ee6cac@intel.com>
[not found] ` <20211012211436.70846-1-ajit.khaparde@broadcom.com>
2021-10-12 21:14 ` [dpdk-stable] [PATCH v3 2/3] net/bnxt: fix Rx queue state on start Ajit Khaparde
[not found] ` <20211012211845.71121-1-ajit.khaparde@broadcom.com>
2021-10-12 21:18 ` [dpdk-stable] [PATCH v4 " Ajit Khaparde
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).