From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BBB3A0C4E for ; Tue, 12 Oct 2021 23:20:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 285964114D; Tue, 12 Oct 2021 23:20:15 +0200 (CEST) Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by mails.dpdk.org (Postfix) with ESMTP id 40AD74111A for ; Tue, 12 Oct 2021 23:20:10 +0200 (CEST) Received: by mail-pg1-f176.google.com with SMTP id s11so288015pgr.11 for ; Tue, 12 Oct 2021 14:20:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=HUK8uQWilcaMs9QjIfWYyU/0Ak7Qy0jyqYBjU5oP1eA=; b=EXG2pVQ/UPb9376yVqkxFfMg9PqUsmlt7+Lytgi3/JPCbrDjOwFgdHwL1rex8B+uKh KnVowJdIiRDsUj4GMrsSmRhuwD/dlbGTEGM66CwhSJuZuwEsRSb6/TEstcFu4U4W+iUe 319yKZUptjwYj1ZDh2JbwnKU0oq9KYfPm3L50= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=HUK8uQWilcaMs9QjIfWYyU/0Ak7Qy0jyqYBjU5oP1eA=; b=QhJpbB2kLmd03ldL6XuIVSIXKHSoD4aEOt7cH62iJvilsBMsgSK1PB3jTUBjET2nkX 0sUQTE4B7/jDxkK1KfAvzOMjK7z09wKlKZbCqCY2kQ+Ze6ojXEBPGrI+K3a6UAc6J29Q tYO9ol+rVVEFwYr2T6u98cqv0SMmDPPZR6p/sYKC61P3B5CvN/Ciwu9QUkGHhDX0K5Dt A+/vhA1x/JTx2e6ButpcOa0vb9tAbkY5K5+TC2pV1XXx+3Q+mUgL7r1CGSSEf3cLFlx1 9LSUbpRRZQ/Djk4i9Hiqvd1TFUFGLh+rTn2064SLpqtcRoWfu2QvN7YjNDv/znbF8/4Q gthw== X-Gm-Message-State: AOAM530PcKgoGrao5tQ2eQWp/pS7boB2OmFB8gJqFrNTh6GEfJYTl2Ha QlADA/FgrPzK429ocyJz9Vq65A== X-Google-Smtp-Source: ABdhPJz56+j0ij2dqvVY84ktvsKGyJPN96vJ4GCoFsBUFVoH1bwbtl5BIvkoq4nrTI18CDuqIGm2uA== X-Received: by 2002:aa7:8b56:0:b0:44c:10a:4ee9 with SMTP id i22-20020aa78b56000000b0044c010a4ee9mr34133647pfd.46.1634073609387; Tue, 12 Oct 2021 14:20:09 -0700 (PDT) Received: from localhost.localdomain ([136.52.99.246]) by smtp.gmail.com with ESMTPSA id ls7sm4084941pjb.16.2021.10.12.14.20.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Oct 2021 14:20:08 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com, stable@dpdk.org, Lance Richardson Date: Tue, 12 Oct 2021 14:18:44 -0700 Message-Id: <20211012211845.71121-3-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) In-Reply-To: <20211012211845.71121-1-ajit.khaparde@broadcom.com> References: <20211012211845.71121-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000000b3c5d05ce2e69d3" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [dpdk-stable] [PATCH v4 2/3] net/bnxt: fix Rx queue state on start X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" --0000000000000b3c5d05ce2e69d3 Content-Transfer-Encoding: 8bit Fix Rx queue state on device start. The state of Rx queues could be incorrect in some cases because instead of updating the state for all the Rx queues, we are updating it for queues in a VNIC. Fixes: 0105ea1296c9 ("net/bnxt: support runtime queue setup") Cc: stable@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson --- drivers/net/bnxt/bnxt_ethdev.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index aa7e7fdc85..a98f93ab29 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -482,12 +482,6 @@ static int bnxt_setup_one_vnic(struct bnxt *bp, uint16_t vnic_id) rxq->vnic->fw_grp_ids[j] = INVALID_HW_RING_ID; else vnic->rx_queue_cnt++; - - if (!rxq->rx_deferred_start) { - bp->eth_dev->data->rx_queue_state[j] = - RTE_ETH_QUEUE_STATE_STARTED; - rxq->rx_started = true; - } } PMD_DRV_LOG(DEBUG, "vnic->rx_queue_cnt = %d\n", vnic->rx_queue_cnt); @@ -824,6 +818,16 @@ static int bnxt_start_nic(struct bnxt *bp) } } + for (j = 0; j < bp->rx_nr_rings; j++) { + struct bnxt_rx_queue *rxq = bp->rx_queues[j]; + + if (!rxq->rx_deferred_start) { + bp->eth_dev->data->rx_queue_state[j] = + RTE_ETH_QUEUE_STATE_STARTED; + rxq->rx_started = true; + } + } + rc = bnxt_hwrm_cfa_l2_set_rx_mask(bp, &bp->vnic_info[0], 0, NULL); if (rc) { PMD_DRV_LOG(ERR, -- 2.30.1 (Apple Git-130) --0000000000000b3c5d05ce2e69d3--