From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: "Peng, ZhihongX" <zhihongx.peng@intel.com>
Cc: "olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v3 1/2] lib/cmdline: release cl when cmdline exit
Date: Wed, 13 Oct 2021 05:36:15 +0300 [thread overview]
Message-ID: <20211013053615.1ae63b13@sovereign> (raw)
In-Reply-To: <DM8PR11MB55915D40582566C97DB69819F0B79@DM8PR11MB5591.namprd11.prod.outlook.com>
2021-10-13 01:53 (UTC+0000), Peng, ZhihongX:
> > -----Original Message-----
> > From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > Sent: Monday, October 11, 2021 4:26 PM
> > To: Peng, ZhihongX <zhihongx.peng@intel.com>
> > Cc: olivier.matz@6wind.com; dev@dpdk.org; stable@dpdk.org
> > Subject: Re: [PATCH v3 1/2] lib/cmdline: release cl when cmdline exit
> >
> > 2021-10-08 06:41 (UTC+0000), zhihongx.peng@intel.com:
> > > From: Zhihong Peng <zhihongx.peng@intel.com>
> > >
> > > Malloc cl in the cmdline_stdin_new function, so release in the
> > > cmdline_stdin_exit function is logical, so that cl will not be
> > > released alone.
> > >
> > > Fixes: af75078fece3 (first public release)
> > > Cc: stable@dpdk.org
> >
> > As I have explained before, backporting this will introduce a double-free bug
> > in user apps unless their code are fixed, so it must not be done.
>
> The release notes have stated that this is the only thing we can do,
> and this unreasonable design should be resolved as soon as possible.
> And the user apps change is very small.
Stable release means stable ABI, which means that a compiled binary can use
the next minor version of DPDK without recompilation. No code change is
possible in this scenario. If the behavior changes such that cmdline_exit() +
cmdline_free() worked before and now cmdline_free() cause double-free, this
is an ABI breakage. Simply put, DPDK .so are replaced, the app restarts and
crashes. Users can do nothing about that.
Release notes are for developers updating their application code for the next
DPDK version.
next prev parent reply other threads:[~2021-10-13 2:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 2:28 [dpdk-stable] [PATCH] " zhihongx.peng
2021-08-31 16:59 ` [dpdk-stable] [dpdk-dev] " Stephen Hemminger
2021-09-06 5:45 ` Peng, ZhihongX
2021-08-31 17:52 ` Dmitry Kozlyuk
2021-09-06 5:51 ` Peng, ZhihongX
2021-09-06 7:33 ` Dmitry Kozlyuk
2021-09-30 6:53 ` Peng, ZhihongX
2021-09-30 7:44 ` Dmitry Kozlyuk
2021-10-08 6:55 ` Peng, ZhihongX
2021-09-17 2:15 ` [dpdk-stable] [PATCH v2 1/2] " zhihongx.peng
2021-09-17 2:15 ` [dpdk-stable] [PATCH v2 2/2] app/test: Delete cmdline free function zhihongx.peng
2021-10-08 6:41 ` [dpdk-stable] [PATCH v3 1/2] lib/cmdline: release cl when cmdline exit zhihongx.peng
2021-10-08 6:41 ` [dpdk-stable] [PATCH v3 2/2] app/test: delete cmdline free function zhihongx.peng
2021-10-11 8:26 ` Dmitry Kozlyuk
2021-10-11 5:20 ` [dpdk-stable] [PATCH v3 1/2] lib/cmdline: release cl when cmdline exit Peng, ZhihongX
2021-10-11 8:25 ` Dmitry Kozlyuk
2021-10-13 1:53 ` Peng, ZhihongX
2021-10-13 2:36 ` Dmitry Kozlyuk [this message]
2021-10-13 3:12 ` Peng, ZhihongX
2021-10-13 1:52 ` [dpdk-stable] [PATCH v4 " zhihongx.peng
2021-10-13 1:52 ` [dpdk-stable] [PATCH v4 2/2] app/test: delete cmdline free function zhihongx.peng
2021-10-15 12:58 ` [dpdk-stable] [PATCH v4 1/2] lib/cmdline: release cl when cmdline exit Olivier Matz
2021-10-18 5:16 ` Peng, ZhihongX
2021-09-30 6:47 ` [dpdk-stable] [PATCH v2 " Peng, ZhihongX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211013053615.1ae63b13@sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
--cc=zhihongx.peng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).