From: zhihongx.peng@intel.com
To: david.marchand@redhat.com, anatoly.burakov@intel.com,
konstantin.ananyev@intel.com, stephen@networkplumber.org,
cristian.dumitrescu@intel.com, john.mcnamara@intel.com,
bruce.richardson@intel.com
Cc: dev@dpdk.org, xueqin.lin@intel.com,
Zhihong Peng <zhihongx.peng@intel.com>,
stable@dpdk.org
Subject: [dpdk-stable] [PATCH v12 4/4] performance-thread: Fix cross compilation failed
Date: Tue, 19 Oct 2021 21:58:41 +0800 [thread overview]
Message-ID: <20211019135841.2004819-4-zhihongx.peng@intel.com> (raw)
In-Reply-To: <20211019135841.2004819-1-zhihongx.peng@intel.com>
From: Zhihong Peng <zhihongx.peng@intel.com>
The gcc(arm-linux-gcc) will check code more stricter when ASan enabled.
"strncpy specified bound XX equals destination size" error occurs here.
Fixes: 116819b9ed0d ("examples/performance-thread: add lthread subsystem")
Cc: stable@dpdk.org
Signed-off-by: Xueqin Lin <xueqin.lin@intel.com>
Signed-off-by: Zhihong Peng <zhihongx.peng@intel.com>
---
v11: Use rte_strlcpy to replace strncpy.
v12: Delete rte_strlcpy's rte_.
---
examples/performance-thread/common/lthread.c | 4 ++--
examples/performance-thread/common/lthread_cond.c | 6 +++---
examples/performance-thread/common/lthread_mutex.c | 6 +++---
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/examples/performance-thread/common/lthread.c b/examples/performance-thread/common/lthread.c
index 3f1f48db43..190e5874b1 100644
--- a/examples/performance-thread/common/lthread.c
+++ b/examples/performance-thread/common/lthread.c
@@ -20,6 +20,7 @@
#include <sys/mman.h>
#include <rte_log.h>
+#include <rte_string_fns.h>
#include <ctx.h>
#include <stack.h>
@@ -463,6 +464,5 @@ void lthread_set_funcname(const char *f)
{
struct lthread *lt = THIS_LTHREAD;
- strncpy(lt->funcname, f, sizeof(lt->funcname));
- lt->funcname[sizeof(lt->funcname)-1] = 0;
+ strlcpy(lt->funcname, f, sizeof(lt->funcname));
}
diff --git a/examples/performance-thread/common/lthread_cond.c b/examples/performance-thread/common/lthread_cond.c
index cdcc7a7b5a..e7be17089a 100644
--- a/examples/performance-thread/common/lthread_cond.c
+++ b/examples/performance-thread/common/lthread_cond.c
@@ -20,6 +20,7 @@
#include <rte_log.h>
#include <rte_common.h>
+#include <rte_string_fns.h>
#include "lthread_api.h"
#include "lthread_diag_api.h"
@@ -57,10 +58,9 @@ lthread_cond_init(char *name, struct lthread_cond **cond,
}
if (name == NULL)
- strncpy(c->name, "no name", sizeof(c->name));
+ strlcpy(c->name, "no name", sizeof(c->name));
else
- strncpy(c->name, name, sizeof(c->name));
- c->name[sizeof(c->name)-1] = 0;
+ strlcpy(c->name, name, sizeof(c->name));
c->root_sched = THIS_SCHED;
diff --git a/examples/performance-thread/common/lthread_mutex.c b/examples/performance-thread/common/lthread_mutex.c
index 01da6cad4f..709ab9f553 100644
--- a/examples/performance-thread/common/lthread_mutex.c
+++ b/examples/performance-thread/common/lthread_mutex.c
@@ -19,6 +19,7 @@
#include <rte_log.h>
#include <rte_spinlock.h>
#include <rte_common.h>
+#include <rte_string_fns.h>
#include "lthread_api.h"
#include "lthread_int.h"
@@ -52,10 +53,9 @@ lthread_mutex_init(char *name, struct lthread_mutex **mutex,
}
if (name == NULL)
- strncpy(m->name, "no name", sizeof(m->name));
+ strlcpy(m->name, "no name", sizeof(m->name));
else
- strncpy(m->name, name, sizeof(m->name));
- m->name[sizeof(m->name)-1] = 0;
+ strlcpy(m->name, name, sizeof(m->name));
m->root_sched = THIS_SCHED;
m->owner = NULL;
--
2.25.1
next prev parent reply other threads:[~2021-10-19 14:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210918074155.872358-1-zhihongx.peng@intel.com>
[not found] ` <20210924022028.1291404-1-zhihongx.peng@intel.com>
2021-09-24 2:20 ` [dpdk-stable] [PATCH v4 2/2] lib/pipeline: Fix gcc compilation error using ASan zhihongx.peng
[not found] ` <20210924093309.3411-1-zhihongx.peng@intel.com>
2021-09-24 9:33 ` [dpdk-stable] [PATCH v5 2/2] " zhihongx.peng
[not found] ` <20210924100310.4278-1-zhihongx.peng@intel.com>
2021-09-24 10:03 ` [dpdk-stable] [PATCH v5 2/2] lib/pipeline: " zhihongx.peng
[not found] ` <20210930052724.195414-1-zhihongx.peng@intel.com>
2021-09-30 5:27 ` [dpdk-stable] [PATCH v6 " zhihongx.peng
2021-09-30 8:29 ` David Marchand
2021-10-12 2:41 ` Peng, ZhihongX
[not found] ` <20210930125938.266731-1-zhihongx.peng@intel.com>
2021-09-30 12:59 ` [dpdk-stable] [PATCH v6 2/2] lib/pipeline: Fix compilation error with gcc ASan zhihongx.peng
[not found] ` <20211008091751.417468-1-zhihongx.peng@intel.com>
2021-10-08 9:17 ` [dpdk-stable] [PATCH v7 3/3] " zhihongx.peng
[not found] ` <20211011062810.422220-1-zhihongx.peng@intel.com>
2021-10-11 6:28 ` [dpdk-stable] [PATCH v8 " zhihongx.peng
[not found] ` <20211012094318.1154727-1-zhihongx.peng@intel.com>
2021-10-12 9:43 ` [dpdk-stable] [PATCH v9 3/3] pipeline: " zhihongx.peng
[not found] ` <20211015142739.1876210-1-zhihongx.peng@intel.com>
2021-10-15 14:27 ` [dpdk-stable] [PATCH v10 3/4] " zhihongx.peng
2021-10-15 14:27 ` [dpdk-stable] [PATCH v10 4/4] performance-thread: Fix cross compilation failed zhihongx.peng
[not found] ` <20211015151110.1876850-1-zhihongx.peng@intel.com>
2021-10-15 15:11 ` [dpdk-stable] [PATCH v10 3/4] pipeline: Fix compilation error with gcc ASan zhihongx.peng
2021-10-18 12:21 ` Dumitrescu, Cristian
2021-10-18 12:54 ` Peng, ZhihongX
2021-10-19 11:26 ` Dumitrescu, Cristian
2021-10-19 12:11 ` Peng, ZhihongX
2021-10-15 15:11 ` [dpdk-stable] [PATCH v10 4/4] performance-thread: Fix cross compilation failed zhihongx.peng
2021-10-19 6:02 ` Peng, ZhihongX
[not found] ` <20211019101207.1451058-1-zhihongx.peng@intel.com>
2021-10-19 10:12 ` [dpdk-stable] [PATCH v11 3/4] pipeline: Fix compilation error with gcc ASan zhihongx.peng
2021-10-19 10:12 ` [dpdk-stable] [PATCH v11 4/4] performance-thread: Fix cross compilation failed zhihongx.peng
2021-10-19 10:37 ` Bruce Richardson
[not found] ` <20211019130445.1955622-1-zhihongx.peng@intel.com>
2021-10-19 13:04 ` [dpdk-stable] [PATCH v12 " zhihongx.peng
[not found] ` <20211019135841.2004819-1-zhihongx.peng@intel.com>
2021-10-19 13:58 ` zhihongx.peng [this message]
[not found] ` <20211019151524.2005442-1-zhihongx.peng@intel.com>
2021-10-19 15:15 ` zhihongx.peng
[not found] ` <20211015141326.1875898-1-zhihongx.peng@intel.com>
2021-10-15 14:13 ` [dpdk-stable] [PATCH v10 3/4] pipeline: Fix compilation error with gcc ASan zhihongx.peng
2021-10-15 14:13 ` [dpdk-stable] [PATCH v10 4/4] performance-thread: Fix cross compilation failed zhihongx.peng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211019135841.2004819-4-zhihongx.peng@intel.com \
--to=zhihongx.peng@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=xueqin.lin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).