From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 5A29EA0C4B
for <public@inbox.dpdk.org>; Tue, 26 Oct 2021 11:06:58 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 4CB4341C3D;
Tue, 26 Oct 2021 11:06:58 +0200 (CEST)
Received: from smtpservice.6wind.com (host.78.145.23.62.rev.coltfrance.com
[62.23.145.78]) by mails.dpdk.org (Postfix) with ESMTP id 79C60407FF;
Tue, 26 Oct 2021 11:06:56 +0200 (CEST)
Received: from metallica.dev.6wind.com (metallica.dev.6wind.com [10.16.0.191])
by smtpservice.6wind.com (Postfix) with ESMTP id 51D1860071;
Tue, 26 Oct 2021 11:06:56 +0200 (CEST)
From: Houssem Bouhlel <houssem.bouhlel@6wind.com>
To: dev@dpdk.org
Cc: Houssem Bouhlel <houssem.bouhlel@6wind.com>, stable@dpdk.org,
Olivier Matz <olivier.matz@6wind.com>
Date: Tue, 26 Oct 2021 11:06:10 +0200
Message-Id: <20211026090610.10823-1-houssem.bouhlel@6wind.com>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-stable] [PATCH] bus/pci: fix selection of default device NUMA
node
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
There can be dev binding issue when no hugepages
are allocated for socket 0.
To avoid this, set device numa node value based on
the first lcore instead of 0.
Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support")
Cc: stable@dpdk.org
Signed-off-by: Houssem Bouhlel <houssem.bouhlel@6wind.com>
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
drivers/bus/pci/pci_common.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
index f8fff2c98ebf..c70ab2373c79 100644
--- a/drivers/bus/pci/pci_common.c
+++ b/drivers/bus/pci/pci_common.c
@@ -166,6 +166,7 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
struct rte_pci_device *dev)
{
int ret;
+ unsigned int socket_id;
bool already_probed;
struct rte_pci_addr *loc;
@@ -194,7 +195,8 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
if (rte_socket_count() > 1)
RTE_LOG(INFO, EAL, "Device %s is not NUMA-aware, defaulting socket to 0\n",
dev->name);
- dev->device.numa_node = 0;
+ socket_id = rte_lcore_to_socket_id(rte_get_next_lcore(-1, 0, 0));
+ dev->device.numa_node = socket_id;
}
already_probed = rte_dev_is_probed(&dev->device);
--
2.30.2