From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B1FAA0C56 for ; Fri, 5 Nov 2021 03:01:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CEA5F40151; Fri, 5 Nov 2021 03:01:31 +0100 (CET) Received: from smtpbg154.qq.com (smtpbg154.qq.com [15.184.224.54]) by mails.dpdk.org (Postfix) with ESMTP id AFF7940151 for ; Fri, 5 Nov 2021 03:01:29 +0100 (CET) X-QQ-mid: bizesmtp42t1636077681tru8e0am Received: from jiawenwu.trustnetic.com (unknown [183.129.236.74]) by esmtp6.qq.com (ESMTP) with id ; Fri, 05 Nov 2021 10:01:19 +0800 (CST) X-QQ-SSF: 01400000002000E0I000000A0000000 X-QQ-FEAT: +MMDnLImGVV8TRKkXlQTfNKkYDJaI46hPgoFVeIN+LmaOZnJhb8BwA8GaqRDE qY/pyDc+ElrQsayRpxdEuOk/Sjr18ky0uYaEVkh9zRfSZ9rJhmzc4ADE/Gp6JVfhF6D+dZZ VO+ABCm7Y0O0lYlLoRMhxc93B3uPKynrzNVhkuf5N8kiLs49pZy73WkORDRsAt2YM5/KeQ0 EEeS5xZbgcVgzjrbnkZhjfO7oeoLIb3yOGyflI1g4V1Ko0CxbiZStjk4OJe7sBtOZz3a0U2 mNgNwdC348NI1ilq9NoMH/z5UYm7mnd+pu16ROLhJrr2zRsanwbP3Mp9g2YjvNG07oaNN7z Y3iDWYdkXM71UAl/H4GIBrPpZmhwXBL2m1UEz5c X-QQ-GoodBg: 2 From: Jiawen Wu To: dev@dpdk.org Cc: Jiawen Wu , stable@dpdk.org Date: Fri, 5 Nov 2021 10:01:17 +0800 Message-Id: <20211105020117.23000-1-jiawenwu@trustnetic.com> X-Mailer: git-send-email 2.21.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign6 X-QQ-Bgrelay: 1 Subject: [dpdk-stable] [PATCH v2] net/txgbe: fix link process in KR mode X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Set the 'present' parameter to 0 by default. It is configured by hardware, users can set it to 1 for manual configuration. Fixes: f611dada1af8 ("net/txgbe: update link setup process of backplane NICs") Cc: stable@dpdk.org Signed-off-by: Jiawen Wu --- doc/guides/nics/txgbe.rst | 2 +- drivers/net/txgbe/base/txgbe_phy.c | 2 +- drivers/net/txgbe/txgbe_ethdev.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/guides/nics/txgbe.rst b/doc/guides/nics/txgbe.rst index 47501796f2..5b29f1de0c 100644 --- a/doc/guides/nics/txgbe.rst +++ b/doc/guides/nics/txgbe.rst @@ -110,7 +110,7 @@ Please note that following ``devargs`` are only set for backplane NICs. Toggle behavior to enable/disable polling mode to receive AN interrupt. -- ``present`` (default **1**) +- ``present`` (default **0**) Toggle behavior to use present mode or init mode. diff --git a/drivers/net/txgbe/base/txgbe_phy.c b/drivers/net/txgbe/base/txgbe_phy.c index 2db87ae0c5..3f5229ecc2 100644 --- a/drivers/net/txgbe/base/txgbe_phy.c +++ b/drivers/net/txgbe/base/txgbe_phy.c @@ -1456,7 +1456,7 @@ txgbe_set_link_to_kr(struct txgbe_hw *hw, bool autoneg) wr32_epcs(hw, SR_AN_CTRL, 0); wr32_epcs(hw, VR_AN_KR_MODE_CL, 0); } - if (hw->devarg.present == 1) { + if (hw->devarg.present == 1) { value = rd32_epcs(hw, TXGBE_PHY_TX_EQ_CTL1); value |= TXGBE_PHY_TX_EQ_CTL1_DEF; wr32_epcs(hw, TXGBE_PHY_TX_EQ_CTL1, value); diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index 169272ded5..8628ce455f 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -495,7 +495,7 @@ txgbe_parse_devargs(struct txgbe_hw *hw, struct rte_devargs *devargs) struct rte_kvargs *kvlist; u16 auto_neg = 1; u16 poll = 0; - u16 present = 1; + u16 present = 0; u16 sgmii = 0; u16 ffe_set = 0; u16 ffe_main = 27; -- 2.21.0.windows.1