From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0124DA034F for ; Wed, 10 Nov 2021 07:47:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EABCC40142; Wed, 10 Nov 2021 07:47:12 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2043.outbound.protection.outlook.com [40.107.223.43]) by mails.dpdk.org (Postfix) with ESMTP id 5E38240142 for ; Wed, 10 Nov 2021 07:47:11 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X80zjXpgdU4/vHyWm7n360JYZH/2b35QMaKEkk3ckaQP6TjT/BSlHg4SwlfDJJHQi/dTVlwxvHzlCJEBe7Iml8iuJIFWj0KDcPc+UX3NF5LVzCQWbJWcTovES9RUT5m8d6yYXaR+whQr1XmnU+ka5r6wBc2jyBoyKncIUQ364JvX0wlvj30Whf1uBfdF6yJ4Dg6M0d4ipjl2orUaLCchES5lyEk1NDbOxf1PXEll5akvORXMWIqInEqDZW/my0jUYBoNVlzhTP1HMk9IC9jSYQZMICE6EA+ePxkGoV61Cg9gm5agSXu5z8lT5BDBimIU4E/PG4x2w+8bcndtBoYBsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iUl4w2dJJc8TuBO+wiKiYAYJ0KovEz8MsI1wMAohmn0=; b=DmU3TWJPHLAjUMqojOFFOShe5p1Ja6BuRR/HKw+ycIIwuK72tUT5pZdJwWU4fKvoGyVNLTarpoJI0QmykgUofGGHxzp5f+OrWU1qP9+iEMLR8tV00gWlJLswJyWZCyEnQatf/24WE8Ruj23XrrFu6ZY64Rs17PXgXbEURCQ2RSWHDZoAHRVAtHsI+nfute89f9SvapSzW5WJCYBTQG2YB875baW9SVAL5FiREtovRbq0bEe6p2Y5Jp4LZhvXFvojARufTlv6bnP+Jt9jsUrTdaMaQUgFmZ5daQUKdoiEu/Y8unIzA5Q/tQwRuQS3126y4LaHvWyJwHIvQmKzJkJpkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iUl4w2dJJc8TuBO+wiKiYAYJ0KovEz8MsI1wMAohmn0=; b=os/MmrIFuK2eOM0xtSMltftMS01Tr4q6Z3HW7zS5KQXb7AGYA090Q+y5Wwtn3ypm8KDD8tQ/OT+UgIjmtRwxxhVcCSZMMxK5P8sHU46aM8lHro13gBVExaPIZeBl9OxcljXY7/5CNNBDdYHkycnRCP7jophJGVnmiuuKl3UkhRYD3RRAyrLkHhW6uLl9XvI8Xh4antJ0gBYdYlIypreq4UH+3BGPvgKyFYJnSP5j67uyq1pF1NFnh3efTh6ti8DCdVdIXMy+BxricNED+AHhSLQjcc1lxILSN/Zlm4JmkfBdL4RwxINXIZsJofXWZ0zq0mlQEhv/rZVnHayRSOWvgQ== Received: from BN8PR07CA0013.namprd07.prod.outlook.com (2603:10b6:408:ac::26) by BYAPR12MB3013.namprd12.prod.outlook.com (2603:10b6:a03:a9::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.16; Wed, 10 Nov 2021 06:47:09 +0000 Received: from BN8NAM11FT025.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ac:cafe::b0) by BN8PR07CA0013.outlook.office365.com (2603:10b6:408:ac::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11 via Frontend Transport; Wed, 10 Nov 2021 06:47:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT025.mail.protection.outlook.com (10.13.177.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4669.10 via Frontend Transport; Wed, 10 Nov 2021 06:47:08 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 10 Nov 2021 06:47:06 +0000 From: Xueming Li To: Ciara Loftus CC: Luca Boccassi , Stephen Hemminger , dpdk stable Date: Wed, 10 Nov 2021 14:30:16 +0800 Message-ID: <20211110063216.2744012-133-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211110063216.2744012-1-xuemingl@nvidia.com> References: <20211110063216.2744012-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1ca21320-7812-4800-e1ce-08d9a415eabb X-MS-TrafficTypeDiagnostic: BYAPR12MB3013: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ts4bV5OBQUoPAyXYITOV4CkAKnfuy1pH/g5sKy425MKhU1qbF/9uwSBUYCI6z0I8T1aWWCOhDL5WonafmV0mwywqrcAjc3DSSSTfLwOjIRvuJOkP9RUOjPgXD9FBi0uo2d/fPVeDc8JjW3eOv91+mQqdyM+Y5kX/U/hYuUzNfNgqoG10COZ0HQblg+FfdE6ObCY/5LgZXoR5whMM+9DHO4O3seaFYFOVc4AAexDuLm60A7mhcwkXg4Znv/pY4/CO1Ik77Zv9lLdAt4VdqW2hYtXsVl0KBa6JFl5HiO8bGvITOSa8hZ2mLFaEV7yW99p3ZR28DUBCIoNV7vndTGoZSuNatSNf9aga90f2rbI4Kq8YpJe+n7yaK9sQ3HChNlip0LIX0o1oGktEEDlpIoR/XNOU9g3ir7f1XBNsPP4AXEn2c6qtLPmgELFlLoFgdZzBGEXholJbrriR7ueh/yZqMkCh9Z678I++BcTqDCXnxjbyPwDcW92piW4a9UcVjWlm6hPWGzOYpJQOXzhRJ3F8OlF4bNmRCk8LGJM18NR4H8ASH3BkBdLErXxdpyaqBuwO3Dy6YDXekiU4J5b7XUibfvnNPK2xbmUVLWdwZUUetQOHyd3b4kQyw6plbhAYxqDj6HO+xtdzJfErqZ1xt3LBNh0m9Kgu4BbBKs52rbrnxy2Qm//WYzHT8Dcq7ur9mONb+dPOS2JtHxxXmWpBXJHgS1wPqMJ5+iew0KndVu7KaACLoWdhhmlbF83z9zUvJ0NoPFFTjK4yMvf3cyVzx9vhbG7aDvR8XhzcILTU8Y8fXtXxZvy+IQUNMKGC+8u6kZtDeOATzRLKcEs9tNXYRh5aXA== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(316002)(6286002)(7696005)(36906005)(54906003)(16526019)(2616005)(53546011)(5660300002)(83380400001)(36860700001)(2906002)(7636003)(6666004)(336012)(186003)(26005)(426003)(1076003)(6916009)(356005)(36756003)(966005)(86362001)(4326008)(8676002)(47076005)(55016002)(8936002)(70206006)(508600001)(82310400003)(70586007)(4001150100001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 06:47:08.7326 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1ca21320-7812-4800-e1ce-08d9a415eabb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT025.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3013 Subject: [dpdk-stable] patch 'net/af_xdp: disable secondary process support' has been queued to stable release 20.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/effeb912ca7ac50e18db307f40e3bf1e35af8d19 Thanks. Xueming Li --- >From effeb912ca7ac50e18db307f40e3bf1e35af8d19 Mon Sep 17 00:00:00 2001 From: Ciara Loftus Date: Fri, 8 Oct 2021 07:50:20 +0000 Subject: [PATCH] net/af_xdp: disable secondary process support Cc: Xueming Li [ upstream commit 0668d829085c4e92a6a1117e2b7cb8653eff8038 ] Since the AF_XDP PMD does not work for secondary processes as reported in Bugzilla 805, check for the process type at the beginning of probe and return ENOTSUP if the process type is secondary. It is planned that secondary processes will be supported by the PMD in full in a future release by using rte_mp_msg to pass the state to the secondary process that it requires in order to work. Bugzilla ID: 805 Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") Reported-by: Stephen Hemminger Signed-off-by: Ciara Loftus Acked-by: Stephen Hemminger --- drivers/net/af_xdp/rte_eth_af_xdp.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c index 312e424359..3e2e621993 100644 --- a/drivers/net/af_xdp/rte_eth_af_xdp.c +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c @@ -1597,16 +1597,11 @@ rte_pmd_af_xdp_probe(struct rte_vdev_device *dev) rte_vdev_device_name(dev)); name = rte_vdev_device_name(dev); - if (rte_eal_process_type() == RTE_PROC_SECONDARY && - strlen(rte_vdev_device_args(dev)) == 0) { - eth_dev = rte_eth_dev_attach_secondary(name); - if (eth_dev == NULL) { - AF_XDP_LOG(ERR, "Failed to probe %s\n", name); - return -EINVAL; - } - eth_dev->dev_ops = &ops; - rte_eth_dev_probing_finish(eth_dev); - return 0; + if (rte_eal_process_type() == RTE_PROC_SECONDARY) { + AF_XDP_LOG(ERR, "Failed to probe %s. " + "AF_XDP PMD does not support secondary processes.\n", + name); + return -ENOTSUP; } kvlist = rte_kvargs_parse(rte_vdev_device_args(dev), valid_arguments); -- 2.33.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-10 14:17:07.808782386 +0800 +++ 0132-net-af_xdp-disable-secondary-process-support.patch 2021-11-10 14:17:01.894079233 +0800 @@ -1 +1 @@ -From 0668d829085c4e92a6a1117e2b7cb8653eff8038 Mon Sep 17 00:00:00 2001 +From effeb912ca7ac50e18db307f40e3bf1e35af8d19 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 0668d829085c4e92a6a1117e2b7cb8653eff8038 ] @@ -16 +18,0 @@ -Cc: stable@dpdk.org @@ -22,19 +24,3 @@ - doc/guides/rel_notes/release_21_11.rst | 4 ++++ - drivers/net/af_xdp/rte_eth_af_xdp.c | 15 +++++---------- - 2 files changed, 9 insertions(+), 10 deletions(-) - -diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst -index 30175246c7..48e0bb60a1 100644 ---- a/doc/guides/rel_notes/release_21_11.rst -+++ b/doc/guides/rel_notes/release_21_11.rst -@@ -85,6 +85,10 @@ New Features - * Default VLAN strip behavior was changed. VLAN tag won't be stripped - unless ``DEV_RX_OFFLOAD_VLAN_STRIP`` offload is enabled. - -+* **Updated AF_XDP PMD.** -+ -+ * Disabled secondary process support. -+ - * **Updated Broadcom bnxt PMD.** - - * Added flow offload support for Thor. + drivers/net/af_xdp/rte_eth_af_xdp.c | 15 +++++---------- + 1 file changed, 5 insertions(+), 10 deletions(-) + @@ -42 +28 @@ -index a619dd218d..b362ccdcd3 100644 +index 312e424359..3e2e621993 100644 @@ -45 +31 @@ -@@ -1783,16 +1783,11 @@ rte_pmd_af_xdp_probe(struct rte_vdev_device *dev) +@@ -1597,16 +1597,11 @@ rte_pmd_af_xdp_probe(struct rte_vdev_device *dev)