From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01AF9A034F for ; Wed, 10 Nov 2021 07:47:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E946540142; Wed, 10 Nov 2021 07:47:48 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2078.outbound.protection.outlook.com [40.107.93.78]) by mails.dpdk.org (Postfix) with ESMTP id F29BB40142 for ; Wed, 10 Nov 2021 07:47:47 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LjBxHZ/qzoUTXMuudcVNza1V44jDeRqSynV3iFA/g9IvKTpLGgDhlYoAV3gDGlTGogOsTlC52vVdM/kzidMPcEu1uGM0Fdg1iHl2E8RNSE42f7GbyG24goF1NxW8Ozjh9FRle2YPvZIEh8Nkf/wciBx4aWmc0PvFbIAh2mARDOZwP+1gk+Lz+FK0pbv+aHTS2DBKE8LKddcQ5+PB4Ti+mFBuFpGPr894ZgrKC69+vvXKid1jHa6WNROYvxNyaFQc1mNbgzLbhH9iEHqtW4nnLfAlLD4tBjSmokCuGIc7SBl3R4Pv1SZl4c+CNAjaiPoOIL0kJTPL0JewnWIA48HUrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mi0mvgtl2jOHBZ5aEY8R5HjyqmXL1SAaUdv/mQ2e3LY=; b=CwuehV050b4CK2/9m3FDo/9rDQOeZUSBDvy+QpB9tRRDMmtB+lMMRjb1Ix/U0KD6RD9eFx5qOTQ3yvtQ1tPhPxLBvy89/5yicDWA1SHpIy+pwYNqnciam3ahpAn2Tcz685rKjNb6elNFJ1zl7YYM6KKZpxOtd5qkmFWfhjS5188La3sosb2R3YgbAQPASnhaIZEPSSSQTpQhpONoo9zENfvskyr+HA/uH9pTHxLvvD0BF63qJt/RJDu65ANNaGWOVU3ByLbPs5cH6gV+tdwjzwtzVGeH43jkX891njnjyeakQk6LgTBV4Y8eRbCF4oZUOB/Ee+OuX99XWqGE4MrBPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=xilinx.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mi0mvgtl2jOHBZ5aEY8R5HjyqmXL1SAaUdv/mQ2e3LY=; b=AuOMF7GnGteGDk2Frpuk0x1n3eAkA2EyfAvRM9KfbG7ll3Jdr+w7UqbUs4UoPTsyGhtUf2SANMaFPfMlRr+Aly4g3Sahk80wNajzzIXbbR7JzWvHGnYQwp8M1wN0r1OTSaGfxLZ7ZVg8y+YYgksGAhVDwTOMgxTrEBhrLWcSlC5VA2lcQGd2xnpIBOer63N0ap91C3/PavjPeytpgAtKBTR1s3GL1LcHHwHeObnO+ORsMyngUBf4sRatw6v59ZLWG1tqCOj7UQAmRw0CGWW63furU1/7NKW3F1TKKEnbdIWaWVR1p4Keo+b59tsqB4rv6vV2uK/NTyoDSgtjmZL40g== Received: from BN9PR03CA0401.namprd03.prod.outlook.com (2603:10b6:408:111::16) by MN2PR12MB3965.namprd12.prod.outlook.com (2603:10b6:208:168::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.13; Wed, 10 Nov 2021 06:47:46 +0000 Received: from BN8NAM11FT017.eop-nam11.prod.protection.outlook.com (2603:10b6:408:111:cafe::5b) by BN9PR03CA0401.outlook.office365.com (2603:10b6:408:111::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11 via Frontend Transport; Wed, 10 Nov 2021 06:47:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; xilinx.com; dkim=none (message not signed) header.d=none;xilinx.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT017.mail.protection.outlook.com (10.13.177.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4690.15 via Frontend Transport; Wed, 10 Nov 2021 06:47:45 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 10 Nov 2021 06:47:40 +0000 From: Xueming Li To: Viacheslav Galaktionov CC: Luca Boccassi , Andrew Rybchenko , Andy Moreton , dpdk stable Date: Wed, 10 Nov 2021 14:30:22 +0800 Message-ID: <20211110063216.2744012-139-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211110063216.2744012-1-xuemingl@nvidia.com> References: <20211110063216.2744012-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: acd25b43-82de-40da-02a4-08d9a41600a8 X-MS-TrafficTypeDiagnostic: MN2PR12MB3965: X-Microsoft-Antispam-PRVS: X-MLNXRule-Acc-MList-2: Rule triggered X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2TlGSiMrMgUR78b5HufDsoEuF56YBOHCy0B/GFag2latA/dPgHTX39clPvCGCGoGxQ7ltZJU/56xa5cl35MxPCqjtt6BPDR1DxBNjA+bOVOYg+ia3ZqTKT5TPAKrs0cLSflEedqS7cLlckKTcqXUMfXjf1RUgDs/kN8D5JIQqsFh67Wj1AcB2Ygwiw9P3UsOrYbjDOnfXk+aBDWL1bbZxdb6LYcIX+mrghN1eaXR9ajCKK5YYYeVyqpmncP95dAU69LwOwJ5VRY4A2LRaQqW9dZ/cFc+jUlCFDQqt1zg1tGp0Od24OJ1YjT0ZfTS2YM9oXz5vUfX0HvSAk+vHgLxBE+hwuzJOq7+WkGgGxR2NyGYjzkoAtUL9ElRBUU3w6fQLhNC+4GbMXUDOYPohMp+jBPSWaefqmREDr5lO9Dz1OFqR4pe4Rn0P6oR2V6NBD16I/vH6QJYmSeSFR0xRTJuHB2qTvLoa9Ojx0p+l64dsnbAgpdF15mkGN6q3/RC1XPDZ/BAv6kvRWzxF2/lTv6gV67nSmTDTXVG2lRAqsDKEJWitqHTKFTS2RookdYwdg7f6WDf9vMd5gotLmD+mowFMcXEVCXKJnIXRw+wQRTQNTmfE4T2cJUtuRxYqp3Kowvr5g1EBR9jj4tkzmKmO+r5Ccq5I392+xuEV/C32u1G7Km6KYr4LVlErNRpY1bfdxG2qTMf5TaZpyP/1dU6XwyfmcWkgw48kNIbp6wXgj8wUxtH+NoYqzm7aMKnU8F8mIffTK0qFVv/9P3GiSQcetdTfE/GSYSJtKZ7ioyXpIF27IBY/TnsnryGqDapXDJizR0eYB5z+KmWrtnMjFvEn45QgQ== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(7696005)(8936002)(26005)(6286002)(1076003)(53546011)(316002)(70586007)(4326008)(83380400001)(5660300002)(70206006)(54906003)(7636003)(36906005)(8676002)(508600001)(2906002)(4001150100001)(6916009)(55016002)(356005)(82310400003)(186003)(2616005)(16526019)(336012)(426003)(6666004)(36860700001)(36756003)(966005)(47076005)(86362001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 06:47:45.5263 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: acd25b43-82de-40da-02a4-08d9a41600a8 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT017.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3965 Subject: [dpdk-stable] patch 'net/sfc: free MAE lock once switch domain is assigned' has been queued to stable release 20.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/af0aaab086f605cee539c67ff80cea9785d2f850 Thanks. Xueming Li --- >From af0aaab086f605cee539c67ff80cea9785d2f850 Mon Sep 17 00:00:00 2001 From: Viacheslav Galaktionov Date: Mon, 11 Oct 2021 17:48:46 +0300 Subject: [PATCH] net/sfc: free MAE lock once switch domain is assigned Cc: Xueming Li [ upstream commit c7e64eea525241a383dc66c467358a9c91c5ed4a ] If for some reason the hardware switch ID initialization function fails, MAE lock is still held after the function finishes. This patch fixes that. Fixes: 1e7fbdf0ba19 ("net/sfc: support concept of switch domains/ports") Signed-off-by: Viacheslav Galaktionov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_switch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/sfc/sfc_switch.c b/drivers/net/sfc/sfc_switch.c index bdea2a2446..4aa9ab3060 100644 --- a/drivers/net/sfc/sfc_switch.c +++ b/drivers/net/sfc/sfc_switch.c @@ -214,9 +214,9 @@ fail_domain_alloc: fail_mem_alloc: sfc_hw_switch_id_fini(sa, hw_switch_id); - rte_spinlock_unlock(&sfc_mae_switch.lock); fail_hw_switch_id_init: + rte_spinlock_unlock(&sfc_mae_switch.lock); return rc; } -- 2.33.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-10 14:17:08.070479983 +0800 +++ 0138-net-sfc-free-MAE-lock-once-switch-domain-is-assigned.patch 2021-11-10 14:17:01.900745845 +0800 @@ -1 +1 @@ -From c7e64eea525241a383dc66c467358a9c91c5ed4a Mon Sep 17 00:00:00 2001 +From af0aaab086f605cee539c67ff80cea9785d2f850 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit c7e64eea525241a383dc66c467358a9c91c5ed4a ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index c37cdf4a61..80c884a599 100644 +index bdea2a2446..4aa9ab3060 100644