From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9EF15A034F for ; Wed, 10 Nov 2021 07:48:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A70E40E03; Wed, 10 Nov 2021 07:48:19 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2059.outbound.protection.outlook.com [40.107.244.59]) by mails.dpdk.org (Postfix) with ESMTP id 215194068B for ; Wed, 10 Nov 2021 07:48:18 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q75ektIUKfhQIHRd87oq3qd9ZiuOxjhs3f+TQ+lyxVcqvCM4pbfzkpRlEW5I+vtXAs8pSQMB9vWXpHxwFk8yDnodJ8/eWeapChVoT2maKZskRCJ5mTkO577lXXfMrrPIDXr8CthT3zXCXK9uBRVSjIRcTupsXmavb/MFe1kXM9CWQySBeeJIKOhtz6RG34jAqWM1r+7CK2O/4T2xgXm0yqXFBtOUq7QUGv7XNYg+m1yECXnLwcoNXdNY+0oe4HAT6aUiy7XLSSpx00xRv0OdwDDK6GJ41rc6efc2mxx1wKeC3BlUGN0G2yA1Bym7TjLi2fiEnkiVK89PE7p02z1Vfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aQVt0FfY/osMV9tf80TWJqZ0lcXZCB2GFDAQwA+8rFw=; b=L+6dl1A++30A9s8r3+hc0Wq4BcoQgmiFubx8WggA0Z8CodByQGLhXHAysjWYJHLpdYeWeHY9t/HBuGIqeLf2XLis67Bvp8M4pbZA0TrSl5mPv8RObi7N7In0fNHrciAMXRyYf57HQzpiKLmkY+2/u5PM7/TSX+mqEUEwiU3Npn5eFHdXXK/0Bx9/td6yI3HakUMtBR2LQQYhfkEtqBR6aDRr7HCIIptU9dRQKgOLNdM6zAKKOZj7oEmBs2nKB2iemXxBeAkyDFHmP5Hz/mRR0fPUml/J1UoilJhZ2MXUnm2zCJTYjE5UKvi4S6C5iy1NKSVUKeiwsVY789MhEV48mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aQVt0FfY/osMV9tf80TWJqZ0lcXZCB2GFDAQwA+8rFw=; b=k/iqIqLmi01YSY4digUUjjzvyAppLwYrbprxNMYYyY/ZLE/1pV8kkxkhTWxc1f9MXRBI17ZMwMIxEUUgwuCkURIBLDTSZ0LUw7e1aSc+3tP0smtxeVXacIndIPbbxEa4KhFgc4UVtQvPsoRPHU5KGysjmniVMkHNIjbaBwxbvp80n9792ygln0u/3RLT2O8q/V6QM54FgumBnujZmxkoALaS1IWaATqb8bTXtnsRCalANyf4KZlpGHjsjBWtreUDdrIBmd4JNz6IRBeeoTsGnTreeD2Yb4eHbjDjqgLe5TpP5KRJFCq4fsG0JJL7IDSKKoon6BXGPmoAekeiJZQh8g== Received: from BN0PR03CA0032.namprd03.prod.outlook.com (2603:10b6:408:e7::7) by BYAPR12MB4600.namprd12.prod.outlook.com (2603:10b6:a03:112::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15; Wed, 10 Nov 2021 06:48:16 +0000 Received: from BN8NAM11FT059.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e7:cafe::f7) by BN0PR03CA0032.outlook.office365.com (2603:10b6:408:e7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11 via Frontend Transport; Wed, 10 Nov 2021 06:48:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT059.mail.protection.outlook.com (10.13.177.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4690.15 via Frontend Transport; Wed, 10 Nov 2021 06:48:15 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 10 Nov 2021 06:48:11 +0000 From: Xueming Li To: Robin Zhang CC: Luca Boccassi , Dawid Lukwinski , Beilei Xing , dpdk stable Date: Wed, 10 Nov 2021 14:30:26 +0800 Message-ID: <20211110063216.2744012-143-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211110063216.2744012-1-xuemingl@nvidia.com> References: <20211110063216.2744012-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1a5c28ad-788c-44d2-a3a9-08d9a41612a6 X-MS-TrafficTypeDiagnostic: BYAPR12MB4600: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zZR+AYAfZZ00aqBqHPmEXQbHCdT4sevLadSyLnmk583r1aA4l4eaHAn9egb5RnkVHf/MVOZREblmgClbRyZeNZPR8kf27i59IMXiwjtbJ78wdYDxzBobHrzgeKEJayss1HxbObCnFRkAtrNHO1AjKnzD8c8c4S5jsNsn9FCUoi3Xt9SZM1DnnibGPrWKBJiabZdvMDDJuI3nWb9aDec59AjLF5TviOLnJL4mH2fND8mC7r4MSP3rTd4QYyYgXcEFGMsNTsu5AyO6FfHZENtwInw461HloiktomiN2iRLu/w89+L/7Y5x1RVZe98W4F4wjWQTSn20Oy74W75h6rypiNgjvYG+Z4aBVOxXZjUoGcy+q87rdHYIojgrt0c7rGNLpZDOU/NtV7HWffgu89l7DDAUoGeDHHbnGPAF9p+ElMK9YZNGww4UZrARcB+nmVhGViZwGjyZLZehf76MECJapzsYbgoFgOmI4fiS352U1+XIgWZVB620TjZzEW1YY4rLVjZjLH/R/1IdXAINxrzeBlbgiDowflPUV+J0WuunDOlmX96upMiWDnjWkLXOOQ/LPTGe3AD11+iIC1RuwggeRrLVuRi9iJZGWmPoSxT7kM63ZaHqo6pz655g5phw3D8w5M1gOZoP7tjCutMfsyZJ4UJU0u61ZDPsQIiY5ggOjdzVR6TEpVo1olTu4IK3zQjYyQnCLNZeCZBvdETq+aneVP7RQptNOrfxglHAZSYppXLH1xVXGBbfiXs+i9iix6vYqXgRNpq0gwN34ZZupKFhOJEVRRigLccAYrMXzAqw2GAYedsciRZyOXCh3OG+o7nG1ZoyJNQngzdvt/dVLMlr8A== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(4001150100001)(7696005)(36756003)(83380400001)(7636003)(4326008)(82310400003)(47076005)(55016002)(966005)(426003)(86362001)(2616005)(6286002)(2906002)(1076003)(36906005)(508600001)(6666004)(8936002)(316002)(26005)(356005)(70206006)(36860700001)(53546011)(6916009)(186003)(8676002)(16526019)(54906003)(70586007)(336012)(5660300002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 06:48:15.6893 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1a5c28ad-788c-44d2-a3a9-08d9a41612a6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT059.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB4600 Subject: [dpdk-stable] patch 'net/i40e/base: fix PHY identifiers for 2.5G and 5G adapters' has been queued to stable release 20.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/9eec8f0a542763987e9d988bc7f3637440984c1a Thanks. Xueming Li --- >From 9eec8f0a542763987e9d988bc7f3637440984c1a Mon Sep 17 00:00:00 2001 From: Robin Zhang Date: Sat, 9 Oct 2021 01:39:44 +0000 Subject: [PATCH] net/i40e/base: fix PHY identifiers for 2.5G and 5G adapters Cc: Xueming Li [ upstream commit dafd6c6308d441af5a215dc25a7942973c3eda15 ] Unlike other supported adapters, 2.5G and 5G use different PHY type identifiers for reading/writing PHY settings and for reading link status. This commit introduces separate PHY identifiers for these two operation types. Fixes: 988ed63c7441 ("net/i40e/base: add support for Carlsville device") Signed-off-by: Dawid Lukwinski Signed-off-by: Robin Zhang Acked-by: Beilei Xing --- drivers/net/i40e/base/i40e_adminq_cmd.h | 6 ++++-- drivers/net/i40e/base/i40e_common.c | 4 ++-- drivers/net/i40e/base/i40e_type.h | 8 ++------ 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq_cmd.h index 2ca41db5d3..4d80568050 100644 --- a/drivers/net/i40e/base/i40e_adminq_cmd.h +++ b/drivers/net/i40e/base/i40e_adminq_cmd.h @@ -1947,8 +1947,10 @@ enum i40e_aq_phy_type { I40E_PHY_TYPE_25GBASE_LR = 0x22, I40E_PHY_TYPE_25GBASE_AOC = 0x23, I40E_PHY_TYPE_25GBASE_ACC = 0x24, - I40E_PHY_TYPE_2_5GBASE_T = 0x30, - I40E_PHY_TYPE_5GBASE_T = 0x31, + I40E_PHY_TYPE_2_5GBASE_T = 0x26, + I40E_PHY_TYPE_5GBASE_T = 0x27, + I40E_PHY_TYPE_2_5GBASE_T_LINK_STATUS = 0x30, + I40E_PHY_TYPE_5GBASE_T_LINK_STATUS = 0x31, I40E_PHY_TYPE_MAX, I40E_PHY_TYPE_NOT_SUPPORTED_HIGH_TEMP = 0xFD, I40E_PHY_TYPE_EMPTY = 0xFE, diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c index e20bb9ac35..a13513d0b5 100644 --- a/drivers/net/i40e/base/i40e_common.c +++ b/drivers/net/i40e/base/i40e_common.c @@ -1280,8 +1280,8 @@ STATIC enum i40e_media_type i40e_get_media_type(struct i40e_hw *hw) break; case I40E_PHY_TYPE_100BASE_TX: case I40E_PHY_TYPE_1000BASE_T: - case I40E_PHY_TYPE_2_5GBASE_T: - case I40E_PHY_TYPE_5GBASE_T: + case I40E_PHY_TYPE_2_5GBASE_T_LINK_STATUS: + case I40E_PHY_TYPE_5GBASE_T_LINK_STATUS: case I40E_PHY_TYPE_10GBASE_T: media = I40E_MEDIA_TYPE_BASET; break; diff --git a/drivers/net/i40e/base/i40e_type.h b/drivers/net/i40e/base/i40e_type.h index cf41345834..4674715ed7 100644 --- a/drivers/net/i40e/base/i40e_type.h +++ b/drivers/net/i40e/base/i40e_type.h @@ -329,12 +329,8 @@ struct i40e_phy_info { I40E_PHY_TYPE_OFFSET) #define I40E_CAP_PHY_TYPE_25GBASE_ACC BIT_ULL(I40E_PHY_TYPE_25GBASE_ACC + \ I40E_PHY_TYPE_OFFSET) -/* Offset for 2.5G/5G PHY Types value to bit number conversion */ -#define I40E_PHY_TYPE_OFFSET2 (-10) -#define I40E_CAP_PHY_TYPE_2_5GBASE_T BIT_ULL(I40E_PHY_TYPE_2_5GBASE_T + \ - I40E_PHY_TYPE_OFFSET2) -#define I40E_CAP_PHY_TYPE_5GBASE_T BIT_ULL(I40E_PHY_TYPE_5GBASE_T + \ - I40E_PHY_TYPE_OFFSET2) +#define I40E_CAP_PHY_TYPE_2_5GBASE_T BIT_ULL(I40E_PHY_TYPE_2_5GBASE_T) +#define I40E_CAP_PHY_TYPE_5GBASE_T BIT_ULL(I40E_PHY_TYPE_5GBASE_T) #define I40E_HW_CAP_MAX_GPIO 30 #define I40E_HW_CAP_MDIO_PORT_MODE_MDIO 0 #define I40E_HW_CAP_MDIO_PORT_MODE_I2C 1 -- 2.33.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-10 14:17:08.248115201 +0800 +++ 0142-net-i40e-base-fix-PHY-identifiers-for-2.5G-and-5G-ad.patch 2021-11-10 14:17:01.917412376 +0800 @@ -1 +1 @@ -From dafd6c6308d441af5a215dc25a7942973c3eda15 Mon Sep 17 00:00:00 2001 +From 9eec8f0a542763987e9d988bc7f3637440984c1a Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit dafd6c6308d441af5a215dc25a7942973c3eda15 ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -24 +26 @@ -index a96527f31c..af9dec1d7f 100644 +index 2ca41db5d3..4d80568050 100644 @@ -41 +43 @@ -index 32642f3e2b..ceedec68bf 100644 +index e20bb9ac35..a13513d0b5 100644 @@ -56 +58 @@ -index e5a3729183..0323887550 100644 +index cf41345834..4674715ed7 100644