From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 57E37A034F
for <public@inbox.dpdk.org>; Wed, 10 Nov 2021 07:48:52 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 51A8F40E03;
Wed, 10 Nov 2021 07:48:52 +0100 (CET)
Received: from NAM12-DM6-obe.outbound.protection.outlook.com
(mail-dm6nam12on2060.outbound.protection.outlook.com [40.107.243.60])
by mails.dpdk.org (Postfix) with ESMTP id 80DA740142
for <stable@dpdk.org>; Wed, 10 Nov 2021 07:48:50 +0100 (CET)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=VoCtE7xM1P6D6qyoy2uQl3ZYtiXdO9H/OzS1TUDOmCnBp7Yl0w6AlVHqFL5AyjgnAjqkN6PaKk6utgTqxI8/0jkSBWy2FlNsvBB9ADxZ4vZKlDnO9CVMEEwXoS9yZulk1LI8X7EnQQUW5wrI2wNNHhaLZd/klO54abha/BrIALP4ulcLCFjPYc4Uu3hV2KiwQBrWqigtXdvmArC0WPK5JznJI8Vp3yZCGkK21nopCMj29IZtA4UtGVRI1RPyg1IK7oyyPLmiW4fomkpHYo0dCK0KFI8W7/CW5ZOSuc79R1s5vnei7+1Wn7+FDVgw0qZVC76ryQ78zIDZY/0a/pbxVA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=VhQI3wxXL/Mel7UV07lF1/1Q++zua3ArnXVyTALYj8k=;
b=AhjXkSA+TEoYIEEioL4Er2k2CQgDYMgvIyjv77aRANoXilxnqf7ICDcZhDTc6WntF0YzqdUgqP+TasvsNNXkJe6MWc44Vqx2dte4KWI+U/d+4UuD4cLWSeKJgcWOnqi8u000Qcw8jplxohoRVKPQughGzH82MvvgRojD5Lgmm/ZFK70hn+hWsZjh8Ucw54/oE03gy306OnRiIdgMxpu99LG2EMu8CuRlVoWMB1Jrvm176T6okgMyR4EOYF1T+w9uoVdjcSYpOYzYyUaDK+OxhKSt/FEbsQw6lqqNrzgeTHaFk8rVygPMANrLJGvluxerd/RaOCt3IiwR3Tela3++uA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com;
dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
header.from=nvidia.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
s=selector2;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=VhQI3wxXL/Mel7UV07lF1/1Q++zua3ArnXVyTALYj8k=;
b=JQKZhaNPgYwWzaFgCLOBSMLq8PbcEG+NBlSmiJBlT2Z62Q+venJCAFc83DLkp5KA8znhKm2rqXUjGbnCzj+jC2oiMpwS5ccxbqGI6eRG/HPJZ10rV0ksdct5ZxX9DM6PXEo8goooNw+2nJiqprMwXKJ8whqTxIgzoP6qSSS4P/Mtcy+zCT8VTRJ36nc4H4B/V9g0CH6ssdKRMsQDhQW1Aw1XjJY2XtZN/2oOlUy4m9zBNRj3WTfOelRptBFXGTAJ4/iR8Q+t8OuT2a7s9ABR4HW05MiJRq/j8swLPI9z5PX46auEAce7nVLsgCLeNjrYzewdwFLhv7EgAb4aIhFwDA==
Received: from BN9P221CA0024.NAMP221.PROD.OUTLOOK.COM (2603:10b6:408:10a::23)
by CH2PR12MB4953.namprd12.prod.outlook.com (2603:10b6:610:36::8) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Wed, 10 Nov
2021 06:48:48 +0000
Received: from BN8NAM11FT055.eop-nam11.prod.protection.outlook.com
(2603:10b6:408:10a:cafe::5c) by BN9P221CA0024.outlook.office365.com
(2603:10b6:408:10a::23) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.16 via Frontend
Transport; Wed, 10 Nov 2021 06:48:48 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34)
smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed)
header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
216.228.112.34 as permitted sender) receiver=protection.outlook.com;
client-ip=216.228.112.34; helo=mail.nvidia.com;
Received: from mail.nvidia.com (216.228.112.34) by
BN8NAM11FT055.mail.protection.outlook.com (10.13.177.62) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id
15.20.4690.15 via Frontend Transport; Wed, 10 Nov 2021 06:48:48 +0000
Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com
(172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 10 Nov
2021 06:48:45 +0000
From: Xueming Li <xuemingl@nvidia.com>
To: Robin Zhang <robinx.zhang@intel.com>
CC: Luca Boccassi <bluca@debian.org>, Christopher Pau
<christopher.pau@intel.com>, Beilei Xing <beilei.xing@intel.com>, dpdk stable
<stable@dpdk.org>
Date: Wed, 10 Nov 2021 14:30:31 +0800
Message-ID: <20211110063216.2744012-148-xuemingl@nvidia.com>
X-Mailer: git-send-email 2.33.0
In-Reply-To: <20211110063216.2744012-1-xuemingl@nvidia.com>
References: <20211110063216.2744012-1-xuemingl@nvidia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Originating-IP: [172.20.187.6]
X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To
HQMAIL107.nvidia.com (172.20.187.13)
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6085110c-ea95-47db-8e36-08d9a416260a
X-MS-TrafficTypeDiagnostic: CH2PR12MB4953:
X-Microsoft-Antispam-PRVS: <CH2PR12MB495368161B2EF8CBECA3BFBFA1939@CH2PR12MB4953.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 33BAjbnJpyj4faV7tr+xLNFvQauDYEuzDBe9mdoG8gYmjTmSLkpVkr/aC2pJnoejX3dFLbX0vt9Cg3N+1F1bJAW/ePVQ8nhEyGw8XKXyCAbsUA568klndMBpksajzOqDus+CX9PSn8EB61H+SyW9GKzi2Ik8ZVZMjGweDMv0esmcBuGowmu41P81BTvmyaJZd/LbGj+K/SdwJVeCfOX1YrSxBp4dSZw76OOW3mIp0i1JdnNcWQc7q9LRciRan5+9phGF4vuYSN7iyOPzQQINP3iRzEwuyDQLvp/+ap8OhqPx0KdvyeLBG3MrfdfMzUY+oEk7YAWmJkMrPKlCu1b77p482llGeoWNJPmq+uY/pL/hpx2SVTw5XjV/4wO2pz5/TboAakeDUUMwgpTN6pUC3KTbn5B0cvPsl6XtyPkwmXbOSoE4PkS1fHDkmPWjrdT0MnGpvdzpnN5cqdnpYXKUEa+leHanSuMokXHo/qnMyFpBd0CRt/KvGnWJEQcJR3N878Xg8GCcnBW56dINWYI+kdWHg438f1mdbhxDg80A5fDXF5QUelCH0NZGkn4o/Q23pKdMkT85emyJ8T2fP9TmRLrxYNZneBTeckySHUbW+2mw7jTnoppJSOwfdfqGdgmydGkl5T3uZxP/8IHYBQEJkljchc03xrN4noft6MAlEwp6K8YtJXKqVejKn6SFJZTmcmWAJEaZOwLbiPA5JQFs74VYjaLfbifYSs7A4e6QZx7oHHCa4basesZqaOSvc4KAeiyj46ommhIYdTgTyDvEoTkoZNvr+cY7NBtPzHsg4tFVKP+nY8AQJuk40r6vdt8NHs9mTWGMyJtsfS8OfescWPGNF75HOe21UucfocNvMSc=
X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;
SFS:(4636009)(46966006)(36840700001)(36906005)(4001150100001)(316002)(53546011)(86362001)(1076003)(7636003)(70206006)(47076005)(7696005)(36860700001)(70586007)(16526019)(54906003)(2906002)(2616005)(426003)(6286002)(356005)(8936002)(6666004)(4326008)(186003)(55016002)(336012)(8676002)(966005)(82310400003)(36756003)(5660300002)(26005)(83380400001)(6916009)(508600001)(127784003);
DIR:OUT; SFP:1101;
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 06:48:48.2418 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6085110c-ea95-47db-8e36-08d9a416260a
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];
Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT055.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4953
Subject: [dpdk-stable] patch 'net/i40e/base: fix potentially uninitialized
variables' has been queued to stable release 20.11.4
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
Hi,
FYI, your patch has been queued to stable release 20.11.4
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/12/21. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk
This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/50dcbcd809225687f2da84e11b60742fce7fef68
Thanks.
Xueming Li <xuemingl@nvidia.com>
---
>From 50dcbcd809225687f2da84e11b60742fce7fef68 Mon Sep 17 00:00:00 2001
From: Robin Zhang <robinx.zhang@intel.com>
Date: Sat, 9 Oct 2021 01:39:50 +0000
Subject: [PATCH] net/i40e/base: fix potentially uninitialized variables
Cc: Xueming Li <xuemingl@nvidia.com>
[ upstream commit bc99971d1021ecc85280b9b98e84c9b5f4ba008e ]
The status of i40e_read_nvm_word is not checked, so variables set
from this function could be used uninitialized. In this case, preserve
the existing flow that does not block initialization by initializing
these values from the start.
Fixes: 8d6c51fcd24b ("i40e/base: get OEM version")
Fixes: 2db70574247b ("net/i40e/base: limit PF/VF specific code to that driver only")
Signed-off-by: Christopher Pau <christopher.pau@intel.com>
Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
Acked-by: Beilei Xing <beilei.xing@intel.com>
---
drivers/net/i40e/base/i40e_adminq.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/i40e/base/i40e_adminq.c b/drivers/net/i40e/base/i40e_adminq.c
index 235667d57a..c63a38e900 100644
--- a/drivers/net/i40e/base/i40e_adminq.c
+++ b/drivers/net/i40e/base/i40e_adminq.c
@@ -652,8 +652,10 @@ enum i40e_status_code i40e_init_adminq(struct i40e_hw *hw)
{
struct i40e_adminq_info *aq = &hw->aq;
enum i40e_status_code ret_code;
- u16 cfg_ptr, oem_hi, oem_lo;
- u16 eetrack_lo, eetrack_hi;
+ u16 oem_hi = 0, oem_lo = 0;
+ u16 eetrack_hi = 0;
+ u16 eetrack_lo = 0;
+ u16 cfg_ptr = 0;
int retry = 0;
/* verify input for valid configuration */
--
2.33.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2021-11-10 14:17:08.479979630 +0800
+++ 0147-net-i40e-base-fix-potentially-uninitialized-variable.patch 2021-11-10 14:17:01.934078906 +0800
@@ -1 +1 @@
-From bc99971d1021ecc85280b9b98e84c9b5f4ba008e Mon Sep 17 00:00:00 2001
+From 50dcbcd809225687f2da84e11b60742fce7fef68 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl@nvidia.com>
+
+[ upstream commit bc99971d1021ecc85280b9b98e84c9b5f4ba008e ]
@@ -13 +15,0 @@
-Cc: stable@dpdk.org
@@ -23 +25 @@
-index 38d3429e5b..27c82d9b44 100644
+index 235667d57a..c63a38e900 100644