From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40E58A034F for ; Wed, 10 Nov 2021 07:55:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A5D040142; Wed, 10 Nov 2021 07:55:27 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2065.outbound.protection.outlook.com [40.107.93.65]) by mails.dpdk.org (Postfix) with ESMTP id 1DDBE410E0 for ; Wed, 10 Nov 2021 07:55:25 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oFQ8yGiokCv/ILylGQC7njInR67wpx2GiJcMxMGe+ej58mWm/+lVu/d3jLnzNjPU/LdUue7W8e9FbNeiRcYkFp6SiChrnHrUTPkOJjons298Gehs/CrECoa7Ow0hOaBMdf/VJWnJj53dKNkRCuP+6IRij0vH+/XCKhM3xdYCkXOvhh5zZrOLxcGkp+dzuPvZ7tPtQ9D+TO0Xn01U6AOxvyOlXqwNlsxKn4eEPaXfcHCioU2Pj1vhjGfUvrw7E6TFmFaTpyAGKgMN2bKTWmg6pRTravf2NRQHKKQ5ApehkWc6WirM8V4oaPXt0qKT32eaGgcftRwvd0ZDvw2Vqws8wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nTN+k4Y78v9QQ+uVj4r458HVDY7uNt9uGE/Q/5ME/0I=; b=RNxB/8zyPsp1XAx15YYQMfGCMCrNFloQ0nzwFJM0A8hCygadLFgqiGplaIHG/hPEE4Gtth+zAjEDIzf2TUre9K0ktBjXaVA1bG+A5u3VMdTD+LlXOolDY6zUOa3ts39HjBRN4oPHrmtgQpwbTKOmZC8UEpoLChvcQGAQp6Kjiah3rXTFf/HlBMAmiVRDer2jzVVG4MZTT/Xj17MPv+JWDrWIfqa1EtMzuo1rRhbIsEuMsN+OpopanOojKAUsm3AoWoc11XrcTdxI1q3w731kBcBvkaheKq5kLkEayTKYeNM70UKFkw+3uHkRpQ0m/v4Zla/5CwxPUuUu4NuJ7+tYGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nTN+k4Y78v9QQ+uVj4r458HVDY7uNt9uGE/Q/5ME/0I=; b=brR4AsKVma16WsjCi4sehSmGAMN8o1YN0eEh6FK8d+QL1NCPAkEeVm7BvBIIKgSQf8dQgEFZeDL4DaReomdZQgbC6whUFn/IbUB4VM7gehXH85s89r/HBdn79ElRVJ1klz3hvkzSppJjjMea6E5+3ZrZJQH7LeH/zCACG1e50sUUTqxuaHoS/q2rqiWTf2iiLMMwEe3gFd9ELnxZe9TXcxxCJWhxBiBSyNvxholh1E7SPLa1/hIBmkoWd6RLZrWKqSpkPQtpjsRNzEJ3UOBcCgf+EBNs3OZmcFU+UaVNJz6ZuSs30s8PAXN0aW0kwkFccc1RS9U9fDYuAwAGTXNv6w== Received: from DM5PR08CA0033.namprd08.prod.outlook.com (2603:10b6:4:60::22) by MN2PR12MB4318.namprd12.prod.outlook.com (2603:10b6:208:1d8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15; Wed, 10 Nov 2021 06:55:23 +0000 Received: from DM6NAM11FT058.eop-nam11.prod.protection.outlook.com (2603:10b6:4:60:cafe::bf) by DM5PR08CA0033.outlook.office365.com (2603:10b6:4:60::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11 via Frontend Transport; Wed, 10 Nov 2021 06:55:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT058.mail.protection.outlook.com (10.13.172.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4690.15 via Frontend Transport; Wed, 10 Nov 2021 06:55:22 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 10 Nov 2021 06:55:21 +0000 From: Xueming Li To: Xueming Li CC: Luca Boccassi , dpdk stable Date: Wed, 10 Nov 2021 14:31:30 +0800 Message-ID: <20211110063216.2744012-207-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211110063216.2744012-1-xuemingl@nvidia.com> References: <20211110063216.2744012-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 997d6b3a-a019-4b4e-ca25-08d9a417114b X-MS-TrafficTypeDiagnostic: MN2PR12MB4318: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aZojINz77ucE/+OwzREPbiF81ybJfyP0UwPJglIYoTbc+G7cfVn3Q3sIdIwbZf+vJmG1YZ92qZIGvOwmKzs3z3xK6kEhBbHNKtiazAMyBRoRuyIhBiRsNLlPTEpsGCI9psgE+gNm21dJqiNBNaWQOrEweq/rZgf4i+vDFBUJkukMg7y/oEUc2YFS8xmLs8gGdJRQ2eGxrfnATAnyX2YrvYzcldbZztWjp2LaP+FVkth7Eh0oCFZiSutQk88XICna0KZfhISyQVunYfFBfbxokY91WgU8rgOGLPk9nA9oi9sxWEkVor7M/LjpX+fVj+MqPtsvwbOeMGjpgc9XCpqIMN65bfycfZuhmnmTn1cuw1nTx8ZigqzE5P+5UKpWy2alFXqTCfJRKUkNX/v1nC95GLA6VpldVtyKXdO91WVsDHgs804F2FtLk2ecin9VsoQPALvw0JYdZXf8fo7nB5KUJVclBsBljO0Gi4MWpVpzRJL6PNOSws1MFhDhksHNVlfw+ZuxG4v3SV2DjY6jIscmNyjQswr/As8wLwCF4QO9ZtzPF9N1lSfUUlng8wZyNtoy7BmdG0FxV97OV/AUsx66TfJOqc0IJqaUer1ITc/s0JCW+eOITw6UBol1vJboNXshfjYlaV1+F7x4p9+lnK3Gu0omqHqr6caIQUA4fWNQcw5kk2C2ZxfRhNn1Red7Whu/4kRBzaggjrJxKLHr0sDa2jM7be1xJMa2OaB8Q5X8mj3Wj24kDdKCXOXmZfSiRbktsMAs9+8M9tyZH9WAJxzHYrWSgtDPcxuY7QrWuRlp7Gm/LTrFSH6nZZaEa4JU4abWBv9YybpipuhOiipDSKItng== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(966005)(26005)(8676002)(7696005)(47076005)(53546011)(5660300002)(186003)(54906003)(356005)(37006003)(8936002)(4326008)(508600001)(36756003)(16526019)(86362001)(6862004)(7049001)(316002)(82310400003)(6666004)(336012)(2906002)(426003)(83380400001)(70586007)(2616005)(1076003)(4001150100001)(6200100001)(6286002)(7636003)(55016002)(70206006)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 06:55:22.9899 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 997d6b3a-a019-4b4e-ca25-08d9a417114b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT058.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4318 Subject: [dpdk-stable] patch 'eal: fix device iterator when no bus is selected' has been queued to stable release 20.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/d02f2de893f028899690957a8883aea4889c9983 Thanks. Xueming Li --- >From d02f2de893f028899690957a8883aea4889c9983 Mon Sep 17 00:00:00 2001 From: Xueming Li Date: Wed, 27 Oct 2021 16:22:21 +0800 Subject: [PATCH] eal: fix device iterator when no bus is selected Cc: Xueming Li [ upstream commit fc382022c6adcde57eb30e58186198275ad493d7 ] Devargs used in device iterator initialization wasn't set to zero, random data like bus string lead to invalid address access. This patch initializes devargs. Bugzilla ID: 862 Fixes: c99a2d4c6b7f ("eal: implement device iteration initialization") Signed-off-by: Xueming Li --- lib/librte_eal/common/eal_common_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c index 8a3bd3100a..3358f1328a 100644 --- a/lib/librte_eal/common/eal_common_dev.c +++ b/lib/librte_eal/common/eal_common_dev.c @@ -575,7 +575,7 @@ int rte_dev_iterator_init(struct rte_dev_iterator *it, const char *dev_str) { - struct rte_devargs devargs; + struct rte_devargs devargs = { .bus = NULL }; struct rte_class *cls = NULL; struct rte_bus *bus = NULL; -- 2.33.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-10 14:17:11.022832241 +0800 +++ 0206-eal-fix-device-iterator-when-no-bus-is-selected.patch 2021-11-10 14:17:02.017411557 +0800 @@ -1 +1 @@ -From fc382022c6adcde57eb30e58186198275ad493d7 Mon Sep 17 00:00:00 2001 +From d02f2de893f028899690957a8883aea4889c9983 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit fc382022c6adcde57eb30e58186198275ad493d7 ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org @@ -17 +19 @@ - lib/eal/common/eal_common_dev.c | 2 +- + lib/librte_eal/common/eal_common_dev.c | 2 +- @@ -20,5 +22,5 @@ -diff --git a/lib/eal/common/eal_common_dev.c b/lib/eal/common/eal_common_dev.c -index 148a23830a..e1e9976d8d 100644 ---- a/lib/eal/common/eal_common_dev.c -+++ b/lib/eal/common/eal_common_dev.c -@@ -573,7 +573,7 @@ int +diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c +index 8a3bd3100a..3358f1328a 100644 +--- a/lib/librte_eal/common/eal_common_dev.c ++++ b/lib/librte_eal/common/eal_common_dev.c +@@ -575,7 +575,7 @@ int