From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FF1FA034F for ; Wed, 10 Nov 2021 07:55:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5FF4E40142; Wed, 10 Nov 2021 07:55:31 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2083.outbound.protection.outlook.com [40.107.237.83]) by mails.dpdk.org (Postfix) with ESMTP id 10A5840142 for ; Wed, 10 Nov 2021 07:55:30 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NrCvO4lh4RXU4GOMOFA0HnR29Bjyao7jGRmtNY+j6tZFNmdhhvorps0+OuRDpqq2qhfq7IVHF5zGj5FGYQPdTQV1TIyUuOuKb0pujDYULBwych1fcWzQWo3dEF0SbIRIA53sEHVgHOZe+W4bdaiKPK3UMRqsap4V9hG8rNqU9KMf0nHqsDy0BrbXe8pOsA2gnYMjFQnh4LRxilkGJ/YWHv1gII7NehTavI6LHZ9xMfxnYYaI/tNF9UqyfcpUeWhUx5OFFaCCXeVrSQzTvmY7thW2ZbIc1dydcJd+OksEcWPII4fbNTHDmLvnVC053tBwrbOwe/50eos9oOsRdSS2vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R5MFyAI3RiemD2rKS4ZgagCpxG3GlTLdiVMgei7moOg=; b=Cf/mv8UwPfOTrGqAW9Tf/zoITJy1HV0IfosEX0S3Lt9Ce0YJo9DvOvvTTos7e1EjyKTnXwNkCOBGxc/xNTE2vXityUhb8pSpX7vFNYMzt77Up0o4uHU+oL57Y4I3d4Z41w8zXUSdIGV5Z1vcO9zzW+qxTUIARrgTZpJEVWhHfmodOpFUoewW7fxXhZnSfELzD31u4LCzANmtk2o6yGd+cJQFo1PkMWl7bO+EmaTvd7q/i3cIFpfY+PFnCr92g1ELTC9ZcDwpDZlzE2H+BWGMiis2/A+NBr/ejB1mFCsXBKtwKq4BhOMyjY0o695dC3f546YIvaIopGeZdKBxINtg8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R5MFyAI3RiemD2rKS4ZgagCpxG3GlTLdiVMgei7moOg=; b=Xp3+Z8TN6jqn1sADwnW0AZ+tPOd1OFA4Sx5IkP/XDBGBPxClyhcT54CtZXfV/oaxUF0YOaGEhj/7HRFJ9mPdA1rR+OY7YPZ9COX0JyaDDmbu8lpWoBe5Lusv90juWF7AH6lc7eHXqmc3fOMXh2TN8iT7oS1+0AANI+UoUljBIdoaKVmUTZWNdBzlPz4k1gLk0BZB3cUW+vTa0ZnvtALg4i2sw79FFjNbC9AnfnQxu7sJJX9dADsv4KhOxCucj0Z2hH9wpHbxp9d9BU3f37CstvOeVS7sCk3qFN7g0XJXMEZwUcCfyY9BUBbZReAqAB4cgDFVvXyUXpJ+Iq6Cl1b/PQ== Received: from DM6PR02CA0143.namprd02.prod.outlook.com (2603:10b6:5:332::10) by MWHPR12MB1261.namprd12.prod.outlook.com (2603:10b6:300:10::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Wed, 10 Nov 2021 06:55:28 +0000 Received: from DM6NAM11FT030.eop-nam11.prod.protection.outlook.com (2603:10b6:5:332:cafe::1c) by DM6PR02CA0143.outlook.office365.com (2603:10b6:5:332::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11 via Frontend Transport; Wed, 10 Nov 2021 06:55:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT030.mail.protection.outlook.com (10.13.172.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4690.15 via Frontend Transport; Wed, 10 Nov 2021 06:55:27 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 10 Nov 2021 06:55:22 +0000 From: Xueming Li To: Jim Harris CC: Luca Boccassi , David Marchand , dpdk stable Date: Wed, 10 Nov 2021 14:31:31 +0800 Message-ID: <20211110063216.2744012-208-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211110063216.2744012-1-xuemingl@nvidia.com> References: <20211110063216.2744012-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a8cd1cf4-b803-4ab1-96ea-08d9a4171441 X-MS-TrafficTypeDiagnostic: MWHPR12MB1261: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QtUwcqDPlz9VvBeV4NRZluzjN3lH+pDQaeSfEILaCu5CGns58StQu4NMnjr+dYPrptJF9ejGwbUXbFtqcpkQmZpAL0hQCatx0P9byp3FpVZEUXgPweMZuWMxaK6vffVCkdgC2TnJQAyWNCCjZhqe5/RNw5VdgxurVHReWkgVdR4Tmb8R6ic8CfOD4UYVBjz+SSXDWPG+PxqadLVUetkt1Eg9df3bpR/xiwMbdWeBXqRQnIJHXmvFJfvudJEEtmG8KXrdAUDfw4Xoxb1P/l8xQFkQjyDFrEXjKFR8IHlmt2JFBfx5Wf8aGum05rqsPHJfGgZ1TqpAkhzVwlt/VzMwNp3WwC/H5N9AWiPHBMHRL6KebndY2+iPgLB1rvQm7ewoLwuIOO+OMzM/SN7oCVS6tkBabDOn6XQDuY7DaDZB7d6Djk8wARMLAfR0aZvqyEa9gbsmA0szthZvVpqu7Ppi+JkzWMBXK81kLlEOAwnoOmm+mBF+ZJjcTYPctEXJUold+l3YOc76WG4ZrtBRHzQKAj8N54z6n5bbwPMEzortQrcylgzg+pTdO58GNAPvIM17wFo5lZdU72A7UNYZuElFU1le4X6Hx0gBR8AFfIO8ga4Yvhz/KJt13ekpIFjvghxENe/DDv98dor54iHlanOslj3OTPpmPm8w/lL+bQEZMWaHd1lvrAC/ea5i4Yo04N5n4Q2+PP2Z7WfhXSxI27AjRoHtCigErd+/oW8tQRiRb/9xHVOjgPrAJcw5Oo+R/xW6kZ/3n9Rb9OZgHUTaQ35tZM63caqV2NLsIOySB9RwUNTxweFGeeh7rZBJ+ApNOmcvY8gtEIJwVoKhSMlvFUGQ6g== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(4326008)(26005)(5660300002)(86362001)(7696005)(36860700001)(83380400001)(7636003)(16526019)(186003)(4001150100001)(6286002)(6916009)(47076005)(82310400003)(53546011)(356005)(6666004)(36756003)(1076003)(8936002)(966005)(508600001)(70586007)(55016002)(70206006)(316002)(2906002)(2616005)(426003)(54906003)(36906005)(336012)(8676002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 06:55:27.9532 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a8cd1cf4-b803-4ab1-96ea-08d9a4171441 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT030.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1261 Subject: [dpdk-stable] patch 'eal/linux: remove unused variable for socket memory' has been queued to stable release 20.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/30e6ba6bc4bff4abac8b790767f126387ca83f6b Thanks. Xueming Li --- >From 30e6ba6bc4bff4abac8b790767f126387ca83f6b Mon Sep 17 00:00:00 2001 From: Jim Harris Date: Fri, 29 Oct 2021 17:14:10 +0000 Subject: [PATCH] eal/linux: remove unused variable for socket memory Cc: Xueming Li [ upstream commit 628bac7df18904c7083c8ad04669c69688f352de ] clang-13 rightfully complains that the total_mem variable in eal_parse_socket_arg is set but not used, since the final accumulated total_mem result isn't used anywhere. So just remove the total_mem variable. Fixes: 0a703f0f36c1 ("eal/linux: fix parsing zero socket memory and limits") Signed-off-by: Jim Harris Reviewed-by: David Marchand --- lib/librte_eal/linux/eal.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/librte_eal/linux/eal.c b/lib/librte_eal/linux/eal.c index 2ccbad7b08..814572ccbd 100644 --- a/lib/librte_eal/linux/eal.c +++ b/lib/librte_eal/linux/eal.c @@ -561,7 +561,6 @@ eal_parse_socket_arg(char *strval, volatile uint64_t *socket_arg) char * arg[RTE_MAX_NUMA_NODES]; char *end; int arg_num, i, len; - uint64_t total_mem = 0; len = strnlen(strval, SOCKET_MEM_STRLEN); if (len == SOCKET_MEM_STRLEN) { @@ -593,7 +592,6 @@ eal_parse_socket_arg(char *strval, volatile uint64_t *socket_arg) (arg[i][0] == '\0') || (end == NULL) || (*end != '\0')) return -1; val <<= 20; - total_mem += val; socket_arg[i] = val; } -- 2.33.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-10 14:17:11.063314885 +0800 +++ 0207-eal-linux-remove-unused-variable-for-socket-memory.patch 2021-11-10 14:17:02.017411557 +0800 @@ -1 +1 @@ -From 628bac7df18904c7083c8ad04669c69688f352de Mon Sep 17 00:00:00 2001 +From 30e6ba6bc4bff4abac8b790767f126387ca83f6b Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 628bac7df18904c7083c8ad04669c69688f352de ] @@ -16 +19 @@ - lib/eal/linux/eal.c | 2 -- + lib/librte_eal/linux/eal.c | 2 -- @@ -19,5 +22,5 @@ -diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c -index 81fdebc6a0..60b4924838 100644 ---- a/lib/eal/linux/eal.c -+++ b/lib/eal/linux/eal.c -@@ -562,7 +562,6 @@ eal_parse_socket_arg(char *strval, volatile uint64_t *socket_arg) +diff --git a/lib/librte_eal/linux/eal.c b/lib/librte_eal/linux/eal.c +index 2ccbad7b08..814572ccbd 100644 +--- a/lib/librte_eal/linux/eal.c ++++ b/lib/librte_eal/linux/eal.c +@@ -561,7 +561,6 @@ eal_parse_socket_arg(char *strval, volatile uint64_t *socket_arg) @@ -31 +34 @@ -@@ -594,7 +593,6 @@ eal_parse_socket_arg(char *strval, volatile uint64_t *socket_arg) +@@ -593,7 +592,6 @@ eal_parse_socket_arg(char *strval, volatile uint64_t *socket_arg)