From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9614A034F for ; Wed, 10 Nov 2021 07:56:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D204B410FE; Wed, 10 Nov 2021 07:56:29 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2068.outbound.protection.outlook.com [40.107.93.68]) by mails.dpdk.org (Postfix) with ESMTP id BADF5410FE for ; Wed, 10 Nov 2021 07:56:28 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f6V1kgEdiCzvAnj+k0AX4pgku8Xo0C1gLYXNs0GZpFJ0IsaVaZYrbhYb2vYBOK3E+wNR9EuvFmAXKxHCL1KXQQ7xqrtlbkj+AzsojblE7izQeAd4lc0Ed56vdhBzk4fn0TzO7NklBqj+1nXhMN2/eZewzmaajdEU8ZnhHEOE/Rp4QqNhsxbTnbIhx9AZMWu0mg/QUA/N7IbofUnXNYlSHTWNQxw/xZZyd5sAPQxhleQvbTh5pLRMeuROeu04oLS+T7L1mgShTTBjdNmQrzEinWtwkrSsQ+sxGi5l3o9+8bVCz2+L2DLYupTVLSWf7kPGPU54xu/v+truxG3sXgdxqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kNPf3Raulp/VwiDv+xCZqq96uo+UfnM6djY/Cq9irLA=; b=UEvAdtGLy7u3Hgy+C4S8GJxGgN6rRLqGcBlwPP5pjUPZH/5/Ku0E/u1AuC9SgIeovmOzM5bytQeA+gDL4So/0cBpEdzZ4fDTzOZUevQVGQGKcWiNWh6TZE0OStwj7CWqq1Xx7RfXikzCb5zRW+XQeFhuxaGk9F9qE4TCnrgOp7zumkdiLwAOJyXdjWzlYleYtX43RDAOG+VK0+i0SJBh2nnynOnOtgZFzwInX18EgKQuh1hd/e/qCjR/w8/Gq1zKsPjfln6zdQwlkxQ5w1U0VT/alKpnhWz1/pOdToYJJAC0paVgVfcOYa4kl150b1iUw6IheRE8jVF3LnHoslGcdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kNPf3Raulp/VwiDv+xCZqq96uo+UfnM6djY/Cq9irLA=; b=XcGtfZpVd3tKSheKD4l3qg3EA9advSSkZkiPBSyeC4nHxr7d3i6cQzlfxmp0AWNFXjnV6CQujKRUmGDIH5vqM9N25dhGggxwYAVB2TMuGqlI60/ahZAwcigli4jgX1hVSsafPfc6Fldq6pAOHYK52/iXJRMO8MocfBywK9jB9b9w0JGCVYE1Lc34+Ri0NSztEkb/pDzX6bkf9D1/suW18wYbQTFPyGvg8BaHHqKxW8+RsJ4cQKfsETirtAYz2qe2+GaxQ7TYR8CBbkCehmC4BPKj3Ty4zVYNZe7WioS2Jz0w4WvWaIcLo9mEj1P3W9O1L1vEfZw8q5C5FTTUmpaiDA== Received: from DM6PR02CA0091.namprd02.prod.outlook.com (2603:10b6:5:1f4::32) by BN8PR12MB3011.namprd12.prod.outlook.com (2603:10b6:408:4a::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.16; Wed, 10 Nov 2021 06:56:27 +0000 Received: from DM6NAM11FT044.eop-nam11.prod.protection.outlook.com (2603:10b6:5:1f4:cafe::18) by DM6PR02CA0091.outlook.office365.com (2603:10b6:5:1f4::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.16 via Frontend Transport; Wed, 10 Nov 2021 06:56:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT044.mail.protection.outlook.com (10.13.173.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4690.15 via Frontend Transport; Wed, 10 Nov 2021 06:56:26 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 10 Nov 2021 06:56:25 +0000 From: Xueming Li To: Maxime Coquelin CC: Luca Boccassi , Viacheslav Ovsiienko , dpdk stable Date: Wed, 10 Nov 2021 14:31:40 +0800 Message-ID: <20211110063216.2744012-217-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211110063216.2744012-1-xuemingl@nvidia.com> References: <20211110063216.2744012-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1ccb0833-f557-4dbe-545a-08d9a4173734 X-MS-TrafficTypeDiagnostic: BN8PR12MB3011: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aHJVaBr7IKu76s/PacyzlS5CzBKlUC4u7nZtC1mZ3QXUAkyGA6/TwCgo9B7wy5ONgC0o3T9bjUPn85D6TlXSbV+m7Wf7VhwrAP0fo1j2Tk7kvCCJJDOKeWD08qGbXGPcQ8sulY+dS9MOK+d94Z2pjdZ5cPSoKFg6WA2SB7SWy4+hYMhZjRgCEf5ITEIGtED43K68Ko9eECLkP6OSzXVvXtC5+THrZ9v/56AvddV9g1R/GbXLH2xzHPdqyc2M9QhUBXhfRSvtlFoHmpHcpxq+QLX3SRynrONcnEsB/PeSGvwVhtQjlF6yDymksz2/1ZYQsolJeLQmtUY7YDwYqBNVEVIHh+vLReMjce8N70P4vkjBEknrjUmKRe4W0Q2bwQIo2Wph1uUscG/I7ZtOkOoDOxI0Pd9Gg4f7RQjHrvf3BiI0ATNtJRbPuQK5xW3F/eZv1PAJHm12I3wGqxeWcglOYEcp81+gohsiSXrH3mixCfMA6GXxifoqQWlG7eLj4paW8ltKbOqCC+aB5tG5yCXQSsaKkk6aJHQwHpk2SGLNZvWRQyPJ9zOmLTPisgugNltXljoujZY6y/0KbTEAfXmO2idbgZ0pW7LSEqiHvlDBsO7pKXk4SfObxPZWyaRPUHKyKedtvXghyzh3SWE4eTCwBnn48QHNyaY8dUuCWcNJ5imBTOIWHSJ/NHN/c1pwmaLjHOpTvKbxCr3rIavKX0HCMKp8vRkPUrDPk2ELRHhrGp/VOA75Lpxflpsj5igeLNc51ZNS8amd+R5NcWmf44wMtqLXmE0aFsaUpFADR1+FYg4mDxicEkf1jaJTeJS4Ud2mAgPXpN23yFykUCJLSoBcFg== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(26005)(16526019)(54906003)(7696005)(4001150100001)(53546011)(186003)(4326008)(8676002)(5660300002)(426003)(336012)(2906002)(47076005)(15650500001)(316002)(8936002)(2616005)(36906005)(83380400001)(966005)(86362001)(508600001)(6666004)(36756003)(70586007)(36860700001)(70206006)(356005)(82310400003)(1076003)(6916009)(55016002)(6286002)(7636003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 06:56:26.6005 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1ccb0833-f557-4dbe-545a-08d9a4173734 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT044.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3011 Subject: [dpdk-stable] patch 'net/mlx5: fix RSS RETA update' has been queued to stable release 20.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/5e6ca029a2360b7b20f2b28df64a5bf8046f779e Thanks. Xueming Li --- >From 5e6ca029a2360b7b20f2b28df64a5bf8046f779e Mon Sep 17 00:00:00 2001 From: Maxime Coquelin Date: Wed, 27 Oct 2021 16:22:12 +0200 Subject: [PATCH] net/mlx5: fix RSS RETA update Cc: Xueming Li [ upstream commit 5aeb7fab59fef7b9cb01ec58ef32d1068923b6d3 ] This patch fixes RETA updating for entries above 64. Without that, these entries are never updated as calculated mask value will always be 0. Fixes: 634efbc2c8c0 ("mlx5: support RETA query and update") Signed-off-by: Maxime Coquelin Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_rss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rss.c b/drivers/net/mlx5/mlx5_rss.c index 845cebe2e8..0aa3b4ed98 100644 --- a/drivers/net/mlx5/mlx5_rss.c +++ b/drivers/net/mlx5/mlx5_rss.c @@ -210,7 +210,7 @@ mlx5_dev_rss_reta_update(struct rte_eth_dev *dev, for (idx = 0, i = 0; (i != reta_size); ++i) { idx = i / RTE_RETA_GROUP_SIZE; pos = i % RTE_RETA_GROUP_SIZE; - if (((reta_conf[idx].mask >> i) & 0x1) == 0) + if (((reta_conf[idx].mask >> pos) & 0x1) == 0) continue; MLX5_ASSERT(reta_conf[idx].reta[pos] < priv->rxqs_n); (*priv->reta_idx)[i] = reta_conf[idx].reta[pos]; -- 2.33.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-10 14:17:11.443627602 +0800 +++ 0216-net-mlx5-fix-RSS-RETA-update.patch 2021-11-10 14:17:02.027411476 +0800 @@ -1 +1 @@ -From 5aeb7fab59fef7b9cb01ec58ef32d1068923b6d3 Mon Sep 17 00:00:00 2001 +From 5e6ca029a2360b7b20f2b28df64a5bf8046f779e Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 5aeb7fab59fef7b9cb01ec58ef32d1068923b6d3 ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index a4f690039e..a04e22398d 100644 +index 845cebe2e8..0aa3b4ed98 100644 @@ -23 +25 @@ -@@ -211,7 +211,7 @@ mlx5_dev_rss_reta_update(struct rte_eth_dev *dev, +@@ -210,7 +210,7 @@ mlx5_dev_rss_reta_update(struct rte_eth_dev *dev, @@ -25,2 +27,2 @@ - idx = i / RTE_ETH_RETA_GROUP_SIZE; - pos = i % RTE_ETH_RETA_GROUP_SIZE; + idx = i / RTE_RETA_GROUP_SIZE; + pos = i % RTE_RETA_GROUP_SIZE;