From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6063A034F for ; Wed, 10 Nov 2021 07:57:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F9D440142; Wed, 10 Nov 2021 07:57:05 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2055.outbound.protection.outlook.com [40.107.243.55]) by mails.dpdk.org (Postfix) with ESMTP id 198204068B for ; Wed, 10 Nov 2021 07:57:04 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ioHIOMcuOSYu9vZQvvM/wNv31+bRj7j1qcnuuKR13pSgskkAtmPhkvkjAU9ZgrIE4jHhT/tBjHiokNsJeCVdy0G6/AxoPJbR/GNa2drMLL4hvFteVe/rUw1xoa7elF0xrQn1vN12/sNomgjSflx3yqUG+KTExUPEO4fcMMr6St8IPD1Y6DU11Ndo4AOWO1W3iHy/HWmVbLcQ0/pMSVa6NqeTvtU08qBa42AuX954hmvHgqzIGTFyKbQWDEdONROJ2Nm5uT7dx9HBaClZrsUPwcP3j0m/fTrq7AK0/8eYSwyIOIQoQzN6nVyOxi/f8XEQbt0+iQCdK/WJv9kKK9UhUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nlFZce+neW+tQxBDgbHA5Sptdpm9CZFCbvoSxfrnHj0=; b=kGk1pRyfz4F66faIsql//saNDvu0OOev09K4PhgqLLXAohptbJAT8G2T0J/o5cAConcCk1a9q+CuZTsZg0iIL78kWN7tDmUGyTq6907BhIeU3iTuKekbocFOcdcMwDa2VL+7miSJK2CznJgNFaj7RRXKeYbVeSZsatRRSGeCDB15s0ADsm3sv9VzwiwEpQ35oj+L4Xzd7pib8mj+rSSqt4V0ttAjJZhBY2w5ki40o+CJE0FqpV5EYRgRd1SEerKhFyjFcEIrFGQcblJTcbuXPhT2hjvEBniMJe44OG2VecGuH314nBSpN6B2/lNNUko24jGEouSSriUM7uWjJRmL4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=cisco.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nlFZce+neW+tQxBDgbHA5Sptdpm9CZFCbvoSxfrnHj0=; b=uPwN95dOAgitmZr/xmNhHSTxs0D8Or9ZJsUgkSB8beTsFBzpEknO+UsEmOfd1Pl8XG1I5vOQDNFf4i5YH3y3wp5ST23GseB28iWxBgNOs1XiuH5FXlM4O2XnH0LCLIdgWgMzSCdNZlGSaoEIeyrpINkb6FoXp8CAv5wH5p44xxS8FaB0Uexq/yZEWiwm9MIIrSDWea3aVo1WN6o17+wWVEyIE2FZTfq+uIBx/TLKWLWpeR2JjeYJ3IvCyismQyJB6yIlBccP/L67AtbCTMy2nv+CjCXyP5lul8E4oRsk2kVoe+4Nt7YEdej+jx6syF/XLfDRXrnXcgLV2Ci3zaM7gw== Received: from DM6PR02CA0073.namprd02.prod.outlook.com (2603:10b6:5:1f4::14) by CH0PR12MB5107.namprd12.prod.outlook.com (2603:10b6:610:be::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Wed, 10 Nov 2021 06:57:02 +0000 Received: from DM6NAM11FT057.eop-nam11.prod.protection.outlook.com (2603:10b6:5:1f4:cafe::1f) by DM6PR02CA0073.outlook.office365.com (2603:10b6:5:1f4::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15 via Frontend Transport; Wed, 10 Nov 2021 06:57:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; cisco.com; dkim=none (message not signed) header.d=none;cisco.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT057.mail.protection.outlook.com (10.13.172.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4669.10 via Frontend Transport; Wed, 10 Nov 2021 06:57:01 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 10 Nov 2021 06:56:56 +0000 From: Xueming Li To: Hyong Youb Kim CC: Luca Boccassi , John Daley , dpdk stable Date: Wed, 10 Nov 2021 14:31:45 +0800 Message-ID: <20211110063216.2744012-222-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211110063216.2744012-1-xuemingl@nvidia.com> References: <20211110063216.2744012-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0215aa4b-41ba-48cd-9add-08d9a4174c10 X-MS-TrafficTypeDiagnostic: CH0PR12MB5107: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +GZdzl/NucKzdvbvng4SvyiH4wm/zf2H3HBEyHR6lu5hoZqraAc9p+y6S0v95Vq1tFuvp6XYD+PgkWgIA7DK6WK7Bfu3veb7Ph3I+Hhc88oeo13JdKNmy+euoV7+0xnGFLL5nvxMhTCAbO+oblUx2teRmHnnz5nyGSGlVQ/CvZOrpW2nH7mzAvnn83qRDspEfmKkaXcjqzAUBbT8HbBH8cBPaVw/K+RsBQDsGcRq0Ern4gyptC2g9R9FZiEuO3oHKuI4/FYwh+xMb/0TMn+L4KmJdgPDbJloDNU/MO7sI/FWEb+cxCz0Krq1fJ0v6CDsKbAJK0zRHeRHUg3R2J4Ay8bWi/CKdO5hM/vtee329wKHRzAgfopPm1VKPEtpM+riikTj9YMzJL1WVUtVV92bvayiHodC8Rrt6Ta/Bg8y1MVXIcfxU7EaOH95FV7VUlU+oeSRt9fwKvoz2qe/gdU5hJU0VTYiqWM6yVbZVnjwy+K5seY6YyhbEf7f97nAI5S2vVTmdowXcblGHRykHkbKpTjnDgGYI/zFOHBKxwScngXsqTjYsqXf8M6IUIz4ylzPHtrl8Y7ANbtQyZS4TQMiMcMOUh4+Fgbj2L212S2AWTuUNeMZr7DAi0oA8A7oh8DvKwPCcSQyH/ZIyXzoLQiIENXg0qsLNq5FSllo9rq+SuKF5EGq4iqpm5LCSFekvrZIeh7pao+F/4v/8tz5XCX1R2ITXkeaipgM2Oxvh6YRW7KaauGZl4u8ZSiCWQH49ziKHo0zKjyKgxrMgJJych0KiFIAP3wnG0hu0Lf+uWrtv6DCX3V2lsC1nAzF02rY22k5aM+l8/k74WHLTLZhkdhwIQ== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(336012)(36906005)(70206006)(6666004)(7696005)(966005)(15650500001)(6286002)(356005)(4001150100001)(70586007)(508600001)(4326008)(1076003)(53546011)(54906003)(8676002)(2616005)(16526019)(8936002)(426003)(5660300002)(82310400003)(55016002)(316002)(86362001)(26005)(6916009)(36756003)(83380400001)(186003)(2906002)(47076005)(36860700001)(7636003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 06:57:01.5976 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0215aa4b-41ba-48cd-9add-08d9a4174c10 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT057.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5107 Subject: [dpdk-stable] patch 'net/enic: avoid error message when no advanced filtering' has been queued to stable release 20.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/6fe384f69d95fbdbe1c98ffaf8f87cc78cf90b87 Thanks. Xueming Li --- >From 6fe384f69d95fbdbe1c98ffaf8f87cc78cf90b87 Mon Sep 17 00:00:00 2001 From: Hyong Youb Kim Date: Mon, 25 Oct 2021 17:04:18 -0700 Subject: [PATCH] net/enic: avoid error message when no advanced filtering Cc: Xueming Li [ upstream commit af397b3c93f82b0803c0890874d7ee3b5127522d ] Probing the availability of Flow Manager API may print the following error log. PMD: rte_enic_pmd: Devcmd 88 failed with error code -1 The error indicates a flow manager operation failed and happens when advanced filtering is disabled on vNIC. It is harmless but confusing to the user. Since advanced filtering is a prerequisite, check first if it is available and avoid the error message altogether. Fixes: ea7768b5bba8 ("net/enic: add flow implementation based on Flow Manager API") Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/base/vnic_dev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/enic/base/vnic_dev.c b/drivers/net/enic/base/vnic_dev.c index 2a5ea93bfe..8a82b7f491 100644 --- a/drivers/net/enic/base/vnic_dev.c +++ b/drivers/net/enic/base/vnic_dev.c @@ -594,6 +594,9 @@ static int vnic_dev_flowman_enable(struct vnic_dev *vdev, uint32_t *mode, uint64_t ops; static uint32_t instance; + /* Advanced filtering is a prerequisite */ + if (!vnic_dev_capable_adv_filters(vdev)) + return 0; /* flowman devcmd available? */ if (!vnic_dev_capable(vdev, CMD_FLOW_MANAGER_OP)) return 0; -- 2.33.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-10 14:17:11.654327856 +0800 +++ 0221-net-enic-avoid-error-message-when-no-advanced-filter.patch 2021-11-10 14:17:02.037411394 +0800 @@ -1 +1 @@ -From af397b3c93f82b0803c0890874d7ee3b5127522d Mon Sep 17 00:00:00 2001 +From 6fe384f69d95fbdbe1c98ffaf8f87cc78cf90b87 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit af397b3c93f82b0803c0890874d7ee3b5127522d ] @@ -17 +19,0 @@ -Cc: stable@dpdk.org @@ -26 +28 @@ -index 9c42595ced..00d7782e6e 100644 +index 2a5ea93bfe..8a82b7f491 100644