From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3790A034F for ; Wed, 10 Nov 2021 07:35:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED8A540142; Wed, 10 Nov 2021 07:35:34 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2057.outbound.protection.outlook.com [40.107.223.57]) by mails.dpdk.org (Postfix) with ESMTP id 688314068B for ; Wed, 10 Nov 2021 07:35:33 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tb1nLCP94T5uOnrkqhZaYM1KXCs8hSwYD5lYQD3osnpCAgZyyNflivFarwoFhB8PQSOMLhaWqhSw5ryiB6NBQTyCkQyIy9mEr9cvlM3w8woqY0kYhYenoxrEeyZZnP72z0KDp/Qii17BzZVGgQcysLFaG0xtPGaoRZZc9UzSb6jMJRw1c9kNsAHXdgPIbBenPPoK6iF+HzdalbczSgm6ROQJQTNnT/Ozg0CvalGipVaDe+RfssVOdLWUqXfKxaOcXlhJlqOjMvKbxq61j+qq1OewN2SCj10G02X1v31sn1wkfqEfGeREC+uXTrK+u4MOlTHnHdM0RhlYwQeh75ACEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o6sBrDrAxNXE0sfqPwKHzKrSrJRrNFQigI1GOnKU1zw=; b=EmIPivn2yBMe/ZMrSv9/07a7V5fhUxy40fcM1k5jl9f+biZTGVnC++WMQGAhmTpOO7BFSSjjg159Jh9ERePLeKyc2UufvPDqJINcvMslFpprSHlLuIlHb7+BlQf8hTNGrtcGJAkWgelncSKYJkuv3nv4F7XDhSi/m1kZoPyaPHgL/XAgBeFbnpsVfFb/LqlFWkPAnt67quJfCSWziEQeEnZaMIO/c+ccjmCuR4M5gdcIf5FW209tnEvss6Rr6eLRct+YTZEW5T4Uwff/8O3LDxjQAVjswfLKDe6vh47Tt8vZNqJxFKWFrkwVayTExXoOOlvHm43yhfxMPLin8WF4VA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=broadcom.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o6sBrDrAxNXE0sfqPwKHzKrSrJRrNFQigI1GOnKU1zw=; b=os4jU2zCr8jWyaq26v/fosU2OIQyx1fvD5nNX5Y1N544qpitpWhh3P6R7TO2TraaKQQ+8ChR0eb6+GRO79K4z7NEm+osPdQ+BDinRpqrDegMOZIADXK86E1MY3K0Y3sRvwPT+cGyeK6eMNvvLVxQi4voOf/1Gvt+KLQMa+V1tAqYJwjPSwYz+mNz83SKapNTFn2010dweDj9D1UZEl6S41Jgvkd3cbxeGhiE/RQHf02VRGiSMincYPUYiffk6MKOLeP1jzxLPKKSSfcOHWd3to5JWA565zr0mpnZR9SOGNVICcxji0iV5UPGcK5DGlhNfEXhFqU71f8CcHb+i7GI4A== Received: from DS7PR03CA0247.namprd03.prod.outlook.com (2603:10b6:5:3b3::12) by MWHPR1201MB2527.namprd12.prod.outlook.com (2603:10b6:300:df::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10; Wed, 10 Nov 2021 06:35:29 +0000 Received: from DM6NAM11FT054.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b3:cafe::3b) by DS7PR03CA0247.outlook.office365.com (2603:10b6:5:3b3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.16 via Frontend Transport; Wed, 10 Nov 2021 06:35:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; broadcom.com; dkim=none (message not signed) header.d=none;broadcom.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT054.mail.protection.outlook.com (10.13.173.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4690.15 via Frontend Transport; Wed, 10 Nov 2021 06:35:28 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 10 Nov 2021 06:35:25 +0000 From: Xueming Li To: Kalesh AP CC: Luca Boccassi , Ajit Khaparde , Lance Richardson , Somnath Kotur , dpdk stable Date: Wed, 10 Nov 2021 14:28:33 +0800 Message-ID: <20211110063216.2744012-30-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211110063216.2744012-1-xuemingl@nvidia.com> References: <20211110063216.2744012-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 62644df9-478b-4cbf-ceac-08d9a4144960 X-MS-TrafficTypeDiagnostic: MWHPR1201MB2527: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ir7cHEwjyOK0/hQ90EWLwFIOeZjdyfJANaXS8oZMPMNtly68ZlENN04fZwFmZeqc+mmiYTC3E7JG/PTPabEL/czs3pldqvfLaH5zgCffTD3SH+FG2rLHswT8/xalynCI7Pr+/biICcv2Wk7aXr3oQng9kR6j47msfBn3Ifds4WKn5LZGkzl0GGxWqk4J/odYjA/qnyGLzYj28ckHcjgyP+XAa+V+2eiPpDaypIIx1bzrlFNXkWzc/NVFwXvMJ2sFskNlwszxSBdNKUKHCi0C65MTWwmbe0Hs96W/c/VivLotDY9MtNvcRNAPXgji1zU4NCLH+85aAx3/8feXLwlfrJLcGGS7NzHkAFSA71vla+P/smevftHuKJDolbeix1wf7D6GaVyYBFwF5vgFc8Q9idMLzBamr/XwL3NzYRAPriCLIK8UsN+zZd37jvlRXv4AMHqkkoDs++zR1f0e/VCHTfj1iCdO76Wwfn/Pd5vg3bimpHLUnfcL+ulbBUlE85+HHBoN0uvcjeo9CaxgTgxAB3kEvbrM74nylNZFm1Ct80cOFvLUtMyDF4TpAuKvlG5SrToPnrKrdquqhBUCRrj6R2CHL0G9DvyBzMlC4yNZeDW4hG05a17a1tiYvfLwCB20Qp6N+CTvnljkGQfTqn86qr4KVcoNDoYcu3vWNudGxWsqKJmFhKSwMuhBXUHeKGBOYjQ5J0iT08RFSZkXh/YTc1pID4csqerUkiJY4LwwbEN/M1owoO1Ef2kc9/INZF941XTscVgao96vu3vAtS5bx0e2ACC1SZp6aPT5g9K6ddw0WJ2L80UkeJynXwggJQbpTet88AQDlBsJMvSry+6TuQ== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(70206006)(70586007)(86362001)(55016002)(426003)(316002)(8676002)(8936002)(966005)(36756003)(7636003)(6286002)(356005)(508600001)(7696005)(4001150100001)(1076003)(83380400001)(47076005)(2906002)(6666004)(5660300002)(186003)(26005)(16526019)(53546011)(82310400003)(336012)(4326008)(36860700001)(6916009)(54906003)(2616005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 06:35:28.5958 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 62644df9-478b-4cbf-ceac-08d9a4144960 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT054.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB2527 Subject: [dpdk-stable] patch 'net/bnxt: fix ring group free' has been queued to stable release 20.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/8516f354566076ec8b8fd454cf29bf4175282871 Thanks. Xueming Li --- >From 8516f354566076ec8b8fd454cf29bf4175282871 Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Mon, 30 Aug 2021 09:28:11 +0530 Subject: [PATCH] net/bnxt: fix ring group free Cc: Xueming Li [ upstream commit 8269a4e8af5fa7632578fc1f4fa7d44711440e4f ] Added an invalid fw_grp_id check inside bnxt_hwrm_ring_grp_free(). This will prevent invalid fw_grp_id to be passed to the FW which can result in an error. This fixes the following failure in the "port stop" -> "port start" sequence: bnxt_hwrm_ring_grp_free(): error 2:0:00000000:0204 bnxt_hwrm_ring_grp_free(): error 2:0:00000000:0204 Fixes: 9b63c6fd70e3 ("net/bnxt: support Rx/Tx queue start/stop") Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde Reviewed-by: Lance Richardson Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_hwrm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 7d9939d1af..d8ff3c7920 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -1761,6 +1761,9 @@ int bnxt_hwrm_ring_grp_free(struct bnxt *bp, unsigned int idx) struct hwrm_ring_grp_free_input req = {.req_type = 0 }; struct hwrm_ring_grp_free_output *resp = bp->hwrm_cmd_resp_addr; + if (bp->grp_info[idx].fw_grp_id == INVALID_HW_RING_ID) + return 0; + HWRM_PREP(&req, HWRM_RING_GRP_FREE, BNXT_USE_CHIMP_MB); req.ring_group_id = rte_cpu_to_le_16(bp->grp_info[idx].fw_grp_id); -- 2.33.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-10 14:17:03.419181691 +0800 +++ 0029-net-bnxt-fix-ring-group-free.patch 2021-11-10 14:17:01.774080215 +0800 @@ -1 +1 @@ -From 8269a4e8af5fa7632578fc1f4fa7d44711440e4f Mon Sep 17 00:00:00 2001 +From 8516f354566076ec8b8fd454cf29bf4175282871 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 8269a4e8af5fa7632578fc1f4fa7d44711440e4f ] @@ -16 +18,0 @@ -Cc: stable@dpdk.org @@ -27 +29 @@ -index 02613bd00b..0e0e266589 100644 +index 7d9939d1af..d8ff3c7920 100644 @@ -30 +32 @@ -@@ -1897,6 +1897,9 @@ int bnxt_hwrm_ring_grp_free(struct bnxt *bp, unsigned int idx) +@@ -1761,6 +1761,9 @@ int bnxt_hwrm_ring_grp_free(struct bnxt *bp, unsigned int idx)