From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A6D0A034F for ; Wed, 10 Nov 2021 07:37:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8CC3B40683; Wed, 10 Nov 2021 07:37:03 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2073.outbound.protection.outlook.com [40.107.93.73]) by mails.dpdk.org (Postfix) with ESMTP id 1150240142 for ; Wed, 10 Nov 2021 07:37:02 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sa7JvpZA6bNdV3+A5E+xCiMXCLusraBKWBToqxcun+vqeBeBRCvwZRig8sEx4E6u84gpyAVBC+CExXOJHobCao/8b7Nvrf+OJEkCEGGlcJVAeyPHr//2kNHdCmQHIxY3/2sDFY5bKzqeG9n8MJrHFItanvdHfouc+brxXuhGMdnZqOlpSnuq0/OFiY3/u9WmjEMcyfZcTw1VJr15Iepknf+z9sVB/gzPPTEIZ97+eLJlpcmgwRMALFgWtFO3xbj5l4AyJauuN0tc+JNV/dsHIG55UzpAvNagWUlrje+OFlKsSCwUzrbGGsdFaNU5/0ymMucDxrfkx3mFN04vRSTQqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zsuMdPqlmwkRyeg1iV796McdzYNAaDH/4zabOFoDmdQ=; b=RMWLdTipfHb7rDe6KPSNcN+BgM/7+qDvwgvi1kgKKLGkeB/M5J4bkGqx+Il69rulymrwPyVfhhr0YUOVri0UAtdr6+i3+syTEZwcyf1B+P/632QZqn0TJiebpYJXmo40S77ojgNSjAlGO6CtC4JuZtj6k8yj6K55h9hiN7T18LfrK+mcb36krJZ5/y58hD+h/2858gZ08NTorxkfFvtB/JSGzgbv3WNuXM5L1+u7mFdSuLOfoGhUYmpzMOavC1qAVstXHBtTlHkUWte30CrfZDsdrcXWSDXZIecwK67ZhJINL36bxuYGPPiqUqig5d82ZRQpUhKQ/oX0/sD/cR771g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zsuMdPqlmwkRyeg1iV796McdzYNAaDH/4zabOFoDmdQ=; b=jIJr9T0yI6NaYa4Fnbzlt6o+S/rb7xyLTjh6+B/a+LQfhuZkwlTsEeuPBdT9cG/4Cfiewz3CPc/6xUfde00Cmm+rDgV3vKKFe/ThtYVFCiyDYx7tjNTDWf638XF3Y3lfdWrXwDCxvCLMUSEv4ZXw1k7UUFhP7JsUr5gs29LKT0hmCA2xBAPlXFMzk1KJ9JJS14w7cfBMVjzSkr/6xaDiUGWKXoMz9SOPyPn0DkO1a87fp3s2j4YOo7dp5bD5PXs5tgIE1ZMjZYbTXQhXOYCJ9wJsxvolQOPOzE2ejwbkIsGNg/zNjHxnBenSzShdSwbPcyeJ6rByUbTHHyXhZ4umCA== Received: from DS7PR03CA0256.namprd03.prod.outlook.com (2603:10b6:5:3b3::21) by MN2PR12MB4221.namprd12.prod.outlook.com (2603:10b6:208:1d2::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15; Wed, 10 Nov 2021 06:37:00 +0000 Received: from DM6NAM11FT057.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b3:cafe::58) by DS7PR03CA0256.outlook.office365.com (2603:10b6:5:3b3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.16 via Frontend Transport; Wed, 10 Nov 2021 06:37:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT057.mail.protection.outlook.com (10.13.172.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4669.10 via Frontend Transport; Wed, 10 Nov 2021 06:36:59 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 10 Nov 2021 06:36:57 +0000 From: Xueming Li To: Qi Zhang CC: Luca Boccassi , Lijuan Tu , dpdk stable Date: Wed, 10 Nov 2021 14:28:46 +0800 Message-ID: <20211110063216.2744012-43-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211110063216.2744012-1-xuemingl@nvidia.com> References: <20211110063216.2744012-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5f6ab7d9-c049-47f0-5587-08d9a4147f9c X-MS-TrafficTypeDiagnostic: MN2PR12MB4221: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JOfL4G9nHypNguHdTOESGPh2ZoMz9+AIfmGnVP9ga0gHFesQDA3tAJgDYybRwWqv1tKFEOBB/1J5AWrDzHGcXfUJpD1NrE920iERrVtdI6HDn4V7ZZbEwlYSpFYgoZYTAhyLYOBJVQezIGB7DsNjjiY0f71pdX+h5XMku4vLGZntuRo7OuFet4gimnAh9mIuGBE8HCnemTzMsfrMft5f/zhgEWKEafCL6FBxBUF8n3Zis5JngWJZz+wNh1nUd57wgkarItS/it6WOp+fsSTcXBDwUcaKEig0ApVKQSeoYMBcwhUrC6ZbS4JTdSgDyYfGL8r9TQqQ7eAZzT1aNlz+X2QFltNPNWzn4rBX/dJo+yXkEchWwEK7trHd0mlpo+JFV0llWw3t0Y2NBto49WBJO6Wx4Cw/BzYcAUHNaFGXeXwcmjD8kyMFZWCAAK5SAxa+lS2x+hmNL3uJ3O/0SVzMtiVH49YIn5sMRp6fLye/0ge3mbtRQlN2/qNlJ4mt0fIRXy49eemS2FSrmeLk4e56THDFPgInjou3nmcdMZhywdTny4m8CZl30Q4IZmkDDV/Bpej8wnAwNDyyrt56HQGO9LF5l5b1rgUlmhUZkX36zx8QC8/WM7AnW1DQR6c101pX8ZhZoXqFea5jNnY53swweWqZs/87kpisplbwlSbRl0PjgVpcni0e+FpJoSdp4MUdoFgY69aRdMjHBBqXUgGhksQyxcrn+Tr5YlV1Z4c3cIAVDe4tU78kiDvjkwlozqO3znqPva4bhqyqplweAjpZYsLZJGrJ41LORSIrAmodXDkz1gk2ri0LoB8+Tyei+kfi1YAYMXlkh78IQuxTXAxq2w== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(55016002)(16526019)(186003)(36906005)(26005)(966005)(47076005)(70586007)(53546011)(7636003)(7696005)(1076003)(356005)(36756003)(4326008)(8936002)(316002)(83380400001)(86362001)(6666004)(82310400003)(8676002)(70206006)(4001150100001)(426003)(5660300002)(6916009)(2616005)(6286002)(2906002)(336012)(508600001)(36860700001)(54906003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 06:36:59.5739 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5f6ab7d9-c049-47f0-5587-08d9a4147f9c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT057.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4221 Subject: [dpdk-stable] patch 'net/ice: fix performance with writeback policy' has been queued to stable release 20.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/8404c8c99a31cd9d29761b3e29ba6f18d78746a6 Thanks. Xueming Li --- >From 8404c8c99a31cd9d29761b3e29ba6f18d78746a6 Mon Sep 17 00:00:00 2001 From: Qi Zhang Date: Sun, 29 Aug 2021 17:24:52 +0800 Subject: [PATCH] net/ice: fix performance with writeback policy Cc: Xueming Li [ upstream commit af167bcf174b59fa4776297e628a94143cf6a330 ] Apply the same fix that for iavf to DCF commit ead06572bd8f ("net/iavf: fix performance with writeback policy") Fixes: 4b0d391f0eab ("net/ice: add queue config in DCF") Signed-off-by: Qi Zhang Tested-by: Lijuan Tu --- drivers/net/ice/ice_dcf_ethdev.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c index 71f8a4b4cc..b523df47e1 100644 --- a/drivers/net/ice/ice_dcf_ethdev.c +++ b/drivers/net/ice/ice_dcf_ethdev.c @@ -166,10 +166,15 @@ ice_dcf_config_rx_queues_irqs(struct rte_eth_dev *dev, VIRTCHNL_VF_OFFLOAD_WB_ON_ITR) { /* If WB_ON_ITR supports, enable it */ hw->msix_base = IAVF_RX_VEC_START; + /* Set the ITR for index zero, to 2us to make sure that + * we leave time for aggregation to occur, but don't + * increase latency dramatically. + */ IAVF_WRITE_REG(&hw->avf, IAVF_VFINT_DYN_CTLN1(hw->msix_base - 1), - IAVF_VFINT_DYN_CTLN1_ITR_INDX_MASK | - IAVF_VFINT_DYN_CTLN1_WB_ON_ITR_MASK); + (0 << IAVF_VFINT_DYN_CTLN1_ITR_INDX_SHIFT) | + IAVF_VFINT_DYN_CTLN1_WB_ON_ITR_MASK | + (2UL << IAVF_VFINT_DYN_CTLN1_INTERVAL_SHIFT)); } else { /* If no WB_ON_ITR offload flags, need to set * interrupt for descriptor write back. -- 2.33.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-10 14:17:03.993573642 +0800 +++ 0042-net-ice-fix-performance-with-writeback-policy.patch 2021-11-10 14:17:01.797413358 +0800 @@ -1 +1 @@ -From af167bcf174b59fa4776297e628a94143cf6a330 Mon Sep 17 00:00:00 2001 +From 8404c8c99a31cd9d29761b3e29ba6f18d78746a6 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit af167bcf174b59fa4776297e628a94143cf6a330 ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +21 @@ -index 94c6a6e61c..f510bad381 100644 +index 71f8a4b4cc..b523df47e1 100644 @@ -22 +24 @@ -@@ -178,10 +178,15 @@ ice_dcf_config_rx_queues_irqs(struct rte_eth_dev *dev, +@@ -166,10 +166,15 @@ ice_dcf_config_rx_queues_irqs(struct rte_eth_dev *dev,