From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 004DFA034F for ; Wed, 10 Nov 2021 07:38:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EE2CA40142; Wed, 10 Nov 2021 07:38:12 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2056.outbound.protection.outlook.com [40.107.223.56]) by mails.dpdk.org (Postfix) with ESMTP id 391A740683 for ; Wed, 10 Nov 2021 07:38:12 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LY/f1nmgiX0pj2lIrRZOUTvMv52DXXKqucIs9LPiXNHmVcMy7dv1YgsIw30n+AW/qImHsasqb368BvpuDJevggGrbChK99k1R2tjnvGkvN+QhtQs5M75cKpSra2w4Phj8q2sd2FsUTuF5Sr0uOApzKaMTdVXeaBqMTjKqgugN7/OufRkqgXfrp6amSS20CrKNEMmfUpTakTbcnrNKOsYs30VxrSXif4d1lm7f/tY4EMPZ1flHZJ1KyWgQYpFz4RbibD0t4O+y6HthBzs8u5AtfpDNm1HPFVO8RvoPhQaJTwFzSOtWdGHY3KEV/Omd/xENRj6Y69Dls7rjGMVbd9wEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4YOO9FQyyxikJFaRcHyVP/xfEt47TOwLfozVQyeQ6SI=; b=blLpeCEWnSnSzEWQsijksLo8aC1ugkGw+jpCRnPUx2IHjGaVhcow1cGPi3h2RybSdMOdR77sHQcE5DoXSzkRMUtxbGiOyZgI6fNaH5BGruTcdyV+ei4dfQ39dg7gfIdB6zBtW8rNQhf3G14n4vZwllcO/VQ89ip7MWUDgE8kYSoMk6bHPwP/5RbR3wElB2SZrtImRJLRKrey3ptFRSAWEF/sY5RsFtLTOujWdhgn13UJbN6gzZpqtgzOwlA5PDZ0ei4V0xg4lKA6lEanZ20rbzJC/tiJFRSePDGvgxCQCpgGFHyEi9Nk5t1mel3hF5LjTXy1sEZTLQ/3OZsAfzQ1Wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4YOO9FQyyxikJFaRcHyVP/xfEt47TOwLfozVQyeQ6SI=; b=Wms37W+fabJC3X1fmecUElUu70GrJ+CPl5F9jUQBpx7cIQJXRitqqYoU9GEQnuLZ8IJHTbTrGROJOqP2/+2rWT7cUOoG9nYuzIcN2GI6Gtzg4FE6Til4cIxqzZuK8tsuKfgsWgQCWH2plmeLbOomopBwke72FZ/mhGIRAsEdJgPY+gQRUJYElalb0ysK4ZGHcuRnDkLJRiwEsY9fLKbp1W/yamb39a8+rBW2tuvwlLJGdFEMvioqJopSPc11SJ4JB0Rko2FX89X8ruJWGTu1PhFlUbSai8jSPFNK9xeMX/47MzR/KktnNcPkBWZtv6jwBSaDBY61S1TkEhYIgh1gZA== Received: from DS7PR03CA0273.namprd03.prod.outlook.com (2603:10b6:5:3ad::8) by BL1PR12MB5208.namprd12.prod.outlook.com (2603:10b6:208:311::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10; Wed, 10 Nov 2021 06:38:10 +0000 Received: from DM6NAM11FT059.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3ad:cafe::22) by DS7PR03CA0273.outlook.office365.com (2603:10b6:5:3ad::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11 via Frontend Transport; Wed, 10 Nov 2021 06:38:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT059.mail.protection.outlook.com (10.13.172.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4690.15 via Frontend Transport; Wed, 10 Nov 2021 06:38:09 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 10 Nov 2021 06:38:05 +0000 From: Xueming Li To: David Marchand CC: Luca Boccassi , Maxime Coquelin , dpdk stable Date: Wed, 10 Nov 2021 14:28:55 +0800 Message-ID: <20211110063216.2744012-52-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211110063216.2744012-1-xuemingl@nvidia.com> References: <20211110063216.2744012-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7c49fa64-f6ec-42ff-66a6-08d9a414a988 X-MS-TrafficTypeDiagnostic: BL1PR12MB5208: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BER4l06PsAojPelUHKP3DItTQMH9YdM4rUYmkukkAE6EgMCI1963SgDqHmqzGBxBnjC6Kr5z7rnzwlM+/CJa0Lyu7cc35EoB3ZFQgFjIW6Z/yNkXU4Z606dQhz7Tgk5l6L0sWBH8vqqiTdTpIGiwVeVY/QQn4nmZsruOczfMPC8L1gMFKceal0AYOJldQMaZYQ288URso1rS8n/1Y2lVbiF+QDqTaMwrXJQARUonOqNoCf3o4Am/hzcOqsur6wgjr/3cg3ighT9qSb26R69wTyD9AoLY+9Dj+EHVWCBPmpVgA955oY5UvsdTM87LPnHoTUogGOkyZ/QxEayxDEmzcdO6jW3l32RGKdJG3HElONKlCZZW7+OMvQMME0o07lwNvybJZ39ZHPo/EfSlil6bhOBaF5vXSZ4ctrrw81wrn5KXLkqM7YVO/7QLdrU0Vgxo6lkaWZueJt0lxx2/qptzGtgSMHIkETiJqEJtM6QMO+pyPlbn1yc9N0dLsn+D8Tb7yObusKr/aN4RT3Jhltw3+AwoeTW8bhIg2T51syX/jaXRvgrKMkyhKTUC9meblLhLJ50eul9zI55CYgYBLH+QXThWZgg5yEV2ZSsRid5872Kx4IsyrBdT5OvEIbROEyRS52/VdjP8HQ8AgXQREXdBMaNCwETf39q9XdiDg65qo3TbF8KBPFCjwUqEVnIf/U3fxpjdS6HCUOoC1pAPtPHoJSxBmn+qAlmjtqWEwqgcRiJ7zhxNzGqirNYMJqnc7U89PEoINweRhdyzueG5iMfQrY2URzGvlU7DRalZa9dcDWYuDihBY+sk03CFDRDlCUsxAS+yC+xxV431fZd2B3ZiOg== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(6286002)(47076005)(36756003)(6916009)(508600001)(53546011)(6666004)(70586007)(54906003)(2616005)(26005)(16526019)(70206006)(7696005)(5660300002)(86362001)(4001150100001)(4326008)(36860700001)(966005)(8676002)(55016002)(7636003)(336012)(426003)(83380400001)(186003)(82310400003)(1076003)(2906002)(8936002)(356005)(316002)(36906005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 06:38:09.9216 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7c49fa64-f6ec-42ff-66a6-08d9a414a988 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT059.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5208 Subject: [dpdk-stable] patch 'net/virtio: avoid unneeded link interrupt configuration' has been queued to stable release 20.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/b00b073569dffc922323abb98fa845f716b6bf08 Thanks. Xueming Li --- >From b00b073569dffc922323abb98fa845f716b6bf08 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Tue, 31 Aug 2021 17:54:10 +0200 Subject: [PATCH] net/virtio: avoid unneeded link interrupt configuration Cc: Xueming Li [ upstream commit 5be2325ecec83ab9dd5e25dde6112aed56f3e4f6 ] There is no reason to re-register a interrupt handler for LSC if this feature was not requested in the first place. A simple use case is when asking for Rx interrupts without LSC interrupt. Fixes: 26b683b4f7d0 ("net/virtio: setup Rx queue interrupts") Signed-off-by: David Marchand Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 520f3fde54..cfdeb40160 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -1713,13 +1713,15 @@ virtio_configure_intr(struct rte_eth_dev *dev) } } - /* Re-register callback to update max_intr */ - rte_intr_callback_unregister(dev->intr_handle, - virtio_interrupt_handler, - dev); - rte_intr_callback_register(dev->intr_handle, - virtio_interrupt_handler, - dev); + if (dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC) { + /* Re-register callback to update max_intr */ + rte_intr_callback_unregister(dev->intr_handle, + virtio_interrupt_handler, + dev); + rte_intr_callback_register(dev->intr_handle, + virtio_interrupt_handler, + dev); + } /* DO NOT try to remove this! This function will enable msix, or QEMU * will encounter SIGSEGV when DRIVER_OK is sent. -- 2.33.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-10 14:17:04.375595016 +0800 +++ 0051-net-virtio-avoid-unneeded-link-interrupt-configurati.patch 2021-11-10 14:17:01.804079970 +0800 @@ -1 +1 @@ -From 5be2325ecec83ab9dd5e25dde6112aed56f3e4f6 Mon Sep 17 00:00:00 2001 +From b00b073569dffc922323abb98fa845f716b6bf08 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 5be2325ecec83ab9dd5e25dde6112aed56f3e4f6 ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index 9690eb4fb2..061d02f666 100644 +index 520f3fde54..cfdeb40160 100644 @@ -23 +25 @@ -@@ -1685,13 +1685,15 @@ virtio_configure_intr(struct rte_eth_dev *dev) +@@ -1713,13 +1713,15 @@ virtio_configure_intr(struct rte_eth_dev *dev)