From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07470A034F for ; Wed, 10 Nov 2021 07:40:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F275740683; Wed, 10 Nov 2021 07:40:16 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2071.outbound.protection.outlook.com [40.107.223.71]) by mails.dpdk.org (Postfix) with ESMTP id 072D44068B for ; Wed, 10 Nov 2021 07:40:16 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dxAZenYbQUy7PzROeBxSO+HC/+4sIdOLL2/LpwYcvfzZvjCkopM9KYk524C9Z/vUcFAL8H4ALIAu9GdCUVLFNtnmXZXrbYaq6eNxlCXnvAve36sjrP7X9XPzPtnnS7i9QvaomUBKbz4s4PrLY3epbmbGD03OTpFWfgUhb+aslpV4HS1wsMM6dH2A45AwXPNix0eFGXPIN6i219OAyUbRgS3u5Yrh7Mh4eUo21eUCpzFhsWlkTx4i6JxeskYkQNzDznKXGAv2BO62Mbxv//J2PWzv0R7h5W69WhiCUyei+fVTPngIEm2jLTJCqxA3y/63eBtnp/X3kCifc3ViqxxFWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SSWuIM97c/KAqvd3jARGyAMbqHdcOThQpzagLuf5gxc=; b=K6Ecb/aub+p6rTMLDs0HDoeInUXOsCFQulhyi13UfHdLzN/rb7xonoiT0WGMFtD44HpQlVOormFeFTPY66UvJ3oGfska7wpEHlMk+YFyyiexIofjYVrVOW3Qs2BOABZlLaamtene1kX2SebZe4xwwYucPvv//IQIokfumf5uemPApsnx6cZDLkGRS7IrztTSwe+gmCma3vWuM8cpn0hXRDCZWapr/sug5NhES7b8Ihhq3wj4bbQrO2sqQlaxWq2UTrP2WRq4wRsIgCvU74t1s0aWvk/MfH0xfRe9HaauuEkzyccL3cCxq7Q7sl/K/mmrIWConlBvzzuTmW3Xc01e/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SSWuIM97c/KAqvd3jARGyAMbqHdcOThQpzagLuf5gxc=; b=ZD8zi9abXLVIaD/U6VopBnlyA9SU97jf9mN9E891GmfKTx1k1cj26KGAC2sDXEdDfTK0gJIEqkEvXauHRAk/q2W9NtrOSm0yVXKqI7mCzikZnMWH5K9XVMhv5VSqT8DaAItmxSZkXIWKRM5VEnqqoEDapb8rTAG/xTZ8lo9GzYrXpF2VOdudAB+E+YJk0XiFk51MNucF7czQdnzFXuoDi82d8UD8xLTWFUTERp2mHG1MExJlb9sW5/DSWUH0uQl8mAnKqdUuccVW+Csrdm+5UANhMG+krQtsBlwqCzFQ9De9WO7zVrvNH/+gPdxQ8JWdyySsMsUYjMWl1PIFYAdU5g== Received: from DM6PR03CA0075.namprd03.prod.outlook.com (2603:10b6:5:333::8) by CY4PR1201MB2532.namprd12.prod.outlook.com (2603:10b6:903:d8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.15; Wed, 10 Nov 2021 06:40:14 +0000 Received: from DM6NAM11FT024.eop-nam11.prod.protection.outlook.com (2603:10b6:5:333:cafe::b6) by DM6PR03CA0075.outlook.office365.com (2603:10b6:5:333::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.13 via Frontend Transport; Wed, 10 Nov 2021 06:40:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT024.mail.protection.outlook.com (10.13.172.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4690.15 via Frontend Transport; Wed, 10 Nov 2021 06:40:13 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 10 Nov 2021 06:40:11 +0000 From: Xueming Li To: Dapeng Yu CC: Luca Boccassi , Min Hu , dpdk stable Date: Wed, 10 Nov 2021 14:29:15 +0800 Message-ID: <20211110063216.2744012-72-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211110063216.2744012-1-xuemingl@nvidia.com> References: <20211110063216.2744012-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 69e166cb-ec05-4b69-bdd1-08d9a414f316 X-MS-TrafficTypeDiagnostic: CY4PR1201MB2532: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ohJjTKR4YdbIyBjW7ddMXFBju6uQXyuPKhkvRX7kxCMFtyJpOsng/EMM2wzA3pEAw40GDoLrrEwOhWHCEY/RIi0TkcfoKA0vRkGHfAemTVen/8ol0p4k1Etr2YVcovR4pAmoZHn7q5wxjGrHDZAOCvmYKz13qgtLCiBktOJah22wjPOaYM3Xi0DqnltqNQfj1U2aFYizdo8pDy5KsDKWZwDJ17qcnjG9o5R3sXbaWSbzKkDrjjyhNSNcmesESoZ6vGWMpM4XxGkzgQ1nJCGNMd+IswxPucHHZJYerdBMP/prja06luGxMOHvuixSo8iZGHur7lYC5p5RZ3R/g+PJC/thFQwJBmyGmmdQLy1dbcw9xT6ijXoZnBt3WNU775Nl+M8ylYbz7yqKXoh/M0ZrTp2BtB0SMhgdwn7MgPCST0bB2i5rK8obn1nC/SYbmgVEgvOb76tZkXVSD84ayFdohaJu+Z1vI4kTxgHLbCiM7qfVzRurR3Dwn/5EPvRxrBCjrWVnDKde4Aqt96JYUqITrb1w6HjqCHggqkCn+80YuWWr1wBvh/r9LqaoSp8aY6M4byLHmYbkYJG1gEY+E1TytmNRZJdqMk3mbfU7RZUyotQbhc8lXEhZI3e6gm9iYnug+3g8i3vR1KhIN2dN/rMGDBG2dSeCLXfLSWLC5zT/cTxebcR/vnif/UBvNhvbNg6w6w0wEgSnzCVgmI+0JGmN+haV1JA3vhh8VggJYy/53i7aZGFEEWq5OMUYJaXh2zPYJrvv9zPDS8saksQlEvly7Ro83gcPHS6FXYtja0KUfLWVlUQOgAkPQdagL4+iYtp7KqvEDM8PsoeUj/DpOiXimg== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(4326008)(8676002)(5660300002)(47076005)(26005)(8936002)(36756003)(82310400003)(54906003)(70586007)(55016002)(70206006)(336012)(426003)(16526019)(966005)(2906002)(1076003)(186003)(7696005)(6286002)(36860700001)(7636003)(508600001)(316002)(4001150100001)(2616005)(36906005)(53546011)(83380400001)(356005)(86362001)(6916009); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 06:40:13.3191 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 69e166cb-ec05-4b69-bdd1-08d9a414f316 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT024.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB2532 Subject: [dpdk-stable] patch 'net/bonding: fix memory leak on closing device' has been queued to stable release 20.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/8532dae4d660e197c618399a1350d658cbc8c38b Thanks. Xueming Li --- >From 8532dae4d660e197c618399a1350d658cbc8c38b Mon Sep 17 00:00:00 2001 From: Dapeng Yu Date: Wed, 15 Sep 2021 13:08:02 +0800 Subject: [PATCH] net/bonding: fix memory leak on closing device Cc: Xueming Li [ upstream commit ccf0f002d2ec5455102c0259f44535944aa4b154 ] If the bond device was created by vdev mode, the kvlist was not free after the bond device was closed. This patch fixes it. Fixes: 144dc4739975 ("net/bonding: fix leak on remove") Signed-off-by: Dapeng Yu Acked-by: Min Hu (Connor) --- drivers/net/bonding/rte_eth_bond_pmd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index a1d3703e96..baa01b17e5 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -2152,6 +2152,9 @@ bond_ethdev_close(struct rte_eth_dev *dev) */ rte_mempool_free(internals->mode6.mempool); + if (internals->kvlist != NULL) + rte_kvargs_free(internals->kvlist); + return 0; } @@ -3467,8 +3470,6 @@ bond_remove(struct rte_vdev_device *dev) ret = bond_ethdev_stop(eth_dev); bond_ethdev_close(eth_dev); } - if (internals->kvlist != NULL) - rte_kvargs_free(internals->kvlist); rte_eth_dev_release_port(eth_dev); return ret; -- 2.33.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-10 14:17:05.226143855 +0800 +++ 0071-net-bonding-fix-memory-leak-on-closing-device.patch 2021-11-10 14:17:01.830746418 +0800 @@ -1 +1 @@ -From ccf0f002d2ec5455102c0259f44535944aa4b154 Mon Sep 17 00:00:00 2001 +From 8532dae4d660e197c618399a1350d658cbc8c38b Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit ccf0f002d2ec5455102c0259f44535944aa4b154 ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -21 +23 @@ -index 8ed9e036f4..54987d96b3 100644 +index a1d3703e96..baa01b17e5 100644 @@ -24 +26 @@ -@@ -2159,6 +2159,9 @@ bond_ethdev_close(struct rte_eth_dev *dev) +@@ -2152,6 +2152,9 @@ bond_ethdev_close(struct rte_eth_dev *dev) @@ -34 +36 @@ -@@ -3471,8 +3474,6 @@ bond_remove(struct rte_vdev_device *dev) +@@ -3467,8 +3470,6 @@ bond_remove(struct rte_vdev_device *dev)