From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2630A034F for ; Wed, 10 Nov 2021 07:41:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A654740683; Wed, 10 Nov 2021 07:41:33 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2055.outbound.protection.outlook.com [40.107.236.55]) by mails.dpdk.org (Postfix) with ESMTP id C09B34014D for ; Wed, 10 Nov 2021 07:41:31 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OsCGI3Vj0LxjtxDLybAo3cq6CDcaeLfUaNn1xsHiOVCK+wjRweALz00sRQ1qjnSuG1JWNfOAFWF6tRcXCghbKagZNhCiWzHJdTr87wA81WeiWYt2MVPuqLEoObUC6zBRUTLQBZTiYEKJazEmFglg/HfLH2S5HbRXe1eNMCCvejnYEroFEQzNjYFQHu6K4elNAF7CgMRT4kyPMOyCHhUu4oS2mrMEBjhEcaxEYprHnScYl69qHhjBJ6EZi96+aFzUsm6PyVD6v0SM8JNx4tPw9VTqKyD9MYdTWo+E4qaQpstnLesIOsI10EEymo9Loi2dlaHkqp65XSwtqBNDlfopVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JLSLZeqYOeyIJBAM8iUyjKQy74/R2eLH6hZulW8yjtc=; b=WxYMZUmgQAP+V2dV5fMia2Rf+9IIa+afKu2JCD2w6/3xVrB3BuDOA/XzqA7aGxzmUwVwLowheOpqMM/KRfDVxBVuSIDmEfXPAooYg06LzKrqASfHfAFE/m4Qpydvs35cPmuAOoFa1M/+Mdmvt6hoEnp7PX9PvWTBIo98YNrvA1vle7tPBpGCIhxwYMbScKAsv9hOZV1wXD3krLQtUzO0NbiytIqqoOly6fKMwzoKUXr0bEK/ulil9OB1Bfbouh+bhamymcjTlZozLs0xDOIvcj1HvsQe9b7ZyPTTLrS99Qr07r0ZTb0+u4YQp/KhmMN4hwCiy6e9SfGpHDXnLphqdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=gmail.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JLSLZeqYOeyIJBAM8iUyjKQy74/R2eLH6hZulW8yjtc=; b=mQazlMOpPoW9n/KfVEYW4r20V7N1nnPYbWJDkuHuTXkCK3zCWzN2yPga0tcihQbHVNh90XYolS7il1WiM1GhwNNfEPZ/vFQJ70f3XaXe9jo56I1jIMDbV5bxakAzJEHItA+EgP5afD1u132zHEmRsqO/rj/knnD8FL3uRJetsGJLCQwDn1OIUN9b8YTLsg/vpZsrpRf2r2mg3+qPngBgFQq4iR/wk+1F6Ki10mio2KcP4ywvi21DJNgWGwJyop1XTw3N2WNzp9kWN3TgnlBgnuVNHuGHJZjL26MdWk5SqElIpIc4rQIh04dIsypkzawqIWeBTEt/v9fuVod0pHXyTA== Received: from DS7PR05CA0030.namprd05.prod.outlook.com (2603:10b6:5:3b9::35) by BYAPR12MB2952.namprd12.prod.outlook.com (2603:10b6:a03:13b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.13; Wed, 10 Nov 2021 06:41:30 +0000 Received: from DM6NAM11FT023.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b9:cafe::4c) by DS7PR05CA0030.outlook.office365.com (2603:10b6:5:3b9::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.5 via Frontend Transport; Wed, 10 Nov 2021 06:41:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT023.mail.protection.outlook.com (10.13.173.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4669.10 via Frontend Transport; Wed, 10 Nov 2021 06:41:29 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 10 Nov 2021 06:41:26 +0000 From: Xueming Li To: William Tu CC: Luca Boccassi , Dmitry Kozlyuk , dpdk stable Date: Wed, 10 Nov 2021 14:29:24 +0800 Message-ID: <20211110063216.2744012-81-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211110063216.2744012-1-xuemingl@nvidia.com> References: <20211110063216.2744012-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 199b87b0-01c9-405b-2dea-08d9a415206d X-MS-TrafficTypeDiagnostic: BYAPR12MB2952: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PZty3vnEiAFca5ng0EMT682Ex5vD6tHnvIEnWyenleNNdSPTFyM6OtQJFPrSuoI2RWb+TBvlZ1Hcg0NeN0iZv2bxeiU/8TO5q8HOIolX65qPhfII79e2A1PrAxciy2uxRSv+322ItcITqmijjNBMWeP6TFyQr4JyR0fqB3jHX1p//0RvEQsSomP9iDCqAVlsUAg+YoGP9q9z9N/ljS0APdC0QdSRxPSjBk+eaxD8dh5urn0gIuY7Uc4nxdt5bxJHqr1k6w4vliLonHVON7JfuDTqftfAposjdnHdoY1WwW4qkISKeIYDd5qDie4zlJwHa5s1EgKIFLSO1whEWAYY18l1zlevFM0XvQTrLLpKYwAR+VKg2QnEZJAsEwGsTiUBQBVB6vDjg01I3WhBbicQJiRv/Ri1f+bfR/2/YB9S5msGgvHB/A5ds2559zc+MhQ125zpdPoTATqpz5QMsxYt0VT92r1u3eo7VpKy0DT0C9kHqhpuzwrA4SZisyLaPbeNJLeN0mzznT5hVtLZW2BXp0lFvN0unA4YCzoVheJHEhVz5N+zDGbEtNR0BBTMCz9D0Zh+h2xH6qwyqixh5OjKlhcbEiNSq7z3KkbhLaGiYnL0JfZ8all1Z8+S0/aJnWuLFkbGwqzQuCsi4xjek5Iasmngez2f0VStrxPGXFob7h/6lHxIcuz3pvm8v34F84b191qp/MZ93Ue27ojBD1q4KjNcu0UvQUHxa0vhLmg00OH1HZ3VYLGnS4jZ3tidtAQUtCPp8IkqrhtFbXq5SNXumfUfMERY5WyRQ0aP8x8B0X3n1r07ofo8hj4+p//ymhMwzzQdu7X5evKKCWrnNcKT1w== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(4326008)(7636003)(36860700001)(426003)(83380400001)(70206006)(508600001)(70586007)(86362001)(2616005)(47076005)(1076003)(4001150100001)(36756003)(356005)(7696005)(82310400003)(2906002)(966005)(53546011)(54906003)(6916009)(6286002)(8676002)(55016002)(316002)(186003)(26005)(16526019)(5660300002)(8936002)(336012); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 06:41:29.3821 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 199b87b0-01c9-405b-2dea-08d9a415206d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT023.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2952 Subject: [dpdk-stable] patch 'eal/windows: export version function' has been queued to stable release 20.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/8a43d7c5f437814d1c8f5d33353d96a9b989bc81 Thanks. Xueming Li --- >From 8a43d7c5f437814d1c8f5d33353d96a9b989bc81 Mon Sep 17 00:00:00 2001 From: William Tu Date: Thu, 5 Aug 2021 17:48:19 +0000 Subject: [PATCH] eal/windows: export version function Cc: Xueming Li [ upstream commit fe81e52a91d4b1beef15cfc152274498322446b4 ] When OVS inits, it calls rte_version to get the DPDK's version. The patch fixes the error below by exposing rte_version symbol. libopenvswitch.a(dpdk.c.obj) : error LNK2019: unresolved external symbol rte_version referenced in function dpdk_init Fixes: 5b637a848195 ("eal: fix querying DPDK version at runtime") Signed-off-by: William Tu Acked-by: Dmitry Kozlyuk --- lib/librte_eal/version.map | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/version.map b/lib/librte_eal/version.map index 1eeb5f3371..fe065a41d9 100644 --- a/lib/librte_eal/version.map +++ b/lib/librte_eal/version.map @@ -198,6 +198,7 @@ DPDK_21 { rte_uuid_is_null; rte_uuid_parse; rte_uuid_unparse; + rte_version; rte_vfio_clear_group; rte_vfio_container_create; rte_vfio_container_destroy; -- 2.33.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-10 14:17:05.618873137 +0800 +++ 0080-eal-windows-export-version-function.patch 2021-11-10 14:17:01.844079642 +0800 @@ -1 +1 @@ -From fe81e52a91d4b1beef15cfc152274498322446b4 Mon Sep 17 00:00:00 2001 +From 8a43d7c5f437814d1c8f5d33353d96a9b989bc81 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit fe81e52a91d4b1beef15cfc152274498322446b4 ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -17,2 +19,2 @@ - lib/eal/version.map | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) + lib/librte_eal/version.map | 1 + + 1 file changed, 1 insertion(+) @@ -20,9 +22,8 @@ -diff --git a/lib/eal/version.map b/lib/eal/version.map -index b436359596..d800090db0 100644 ---- a/lib/eal/version.map -+++ b/lib/eal/version.map -@@ -267,7 +267,7 @@ DPDK_22 { - rte_uuid_is_null; # WINDOWS_NO_EXPORT - rte_uuid_parse; # WINDOWS_NO_EXPORT - rte_uuid_unparse; # WINDOWS_NO_EXPORT -- rte_version; # WINDOWS_NO_EXPORT +diff --git a/lib/librte_eal/version.map b/lib/librte_eal/version.map +index 1eeb5f3371..fe065a41d9 100644 +--- a/lib/librte_eal/version.map ++++ b/lib/librte_eal/version.map +@@ -198,6 +198,7 @@ DPDK_21 { + rte_uuid_is_null; + rte_uuid_parse; + rte_uuid_unparse; @@ -30,3 +31,3 @@ - rte_vfio_clear_group; # WINDOWS_NO_EXPORT - rte_vfio_container_create; # WINDOWS_NO_EXPORT - rte_vfio_container_destroy; # WINDOWS_NO_EXPORT + rte_vfio_clear_group; + rte_vfio_container_create; + rte_vfio_container_destroy;