From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC75DA034F for ; Wed, 10 Nov 2021 07:43:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B21C940E28; Wed, 10 Nov 2021 07:43:14 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2057.outbound.protection.outlook.com [40.107.92.57]) by mails.dpdk.org (Postfix) with ESMTP id F17794014D for ; Wed, 10 Nov 2021 07:43:13 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=delPbGdDCrb7l184Q60PlfxQGN34LVkrehfDbSlqeGuQfdb5OadV8kw/4u0L6HhPaeDY0i5Fd0gMjR/Qg49F/q6aVbbYrmavsB3Az3hqFHe6OGItjV+DKrDxmIGHG2OLpv7AGCxZvjuqlqsinoDb01uZC1/By7Nv3qKvmucmyeDz1BobHSFTBTzjbG/YwHf51fnYbEoeTURg+HuERAz7hPzneL9Tjn+vm9taaNbOWKm8V7TPnaRKEFlyAnSweQlbX36YpjnX9nXbyYRgVBwy3vZfj8Rk1X1PS5LxFPdtySJLSxhignBq9twrd/ME3bHEPGbjwUzUBKlcS5aG4nA6OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=twFqGEv1MrssAjKQxVdAxzXTUAmVnC3Zr9oDNfrZG4o=; b=A/x1ETs5qFgk1iOYwXWkW7v9NhHpJOuvXpfquEaHR4YD/9zu3U1Ax68G6SLmNZY8nw6VQqLMVyogAXTiThlT4+oEsc+xVMzOw+Eh0dq0XEOWf65SwcyPze0lNQb6UG1f02Bvdg8FoWf5fHEVZYjnfqRjI44SbsGlSjJ9HX5HKO0BftNn6+p8PdcP/BeGy7gjHSuqtbmFLtLXnUV8838GHzjZzwHuZrGpiw8RzvlhD5gbCYYnPQFSX74GTdccDpWUYpYzeXFavKGb5aEo+gu2MnMKgl181yAaja4v1Jw/lic/QNYnaqnPwLchFaKQJOgZqpkrKkSonWS+0gfrHMtG1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=broadcom.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=twFqGEv1MrssAjKQxVdAxzXTUAmVnC3Zr9oDNfrZG4o=; b=q8ejMLF1Om6l2GXTXFCIk+H1tP67zbJIsAxuYF+LLm3qa2Wkj4gHPHUNB5O68WT8J+THlJemXGkXeM39Cm/vopnhg14nd/mGKaoRXhYSzOC8HVHrm83AXs4i2IKyNUrF8adU07/gGp4dKrh7QVdWisQGI5tbOf4wGrp9zMFXEstrV/3WN/zqJlug8rTdFYg3KEL6awKXkXkIUfxI/NIpIxgArqJMJXUjXKCZ927EcjmINR1Ea2ovbIa7c9LIjZbC4ohJuudd3MZgD3CcCRjpf4URvvldCwN5Xm0iZrgLkS3lsB9E9aVfiIuTUzR2VJJDndBW3HnGHPNKqsZYMwIj8Q== Received: from DM5PR07CA0111.namprd07.prod.outlook.com (2603:10b6:4:ae::40) by DM6PR12MB3930.namprd12.prod.outlook.com (2603:10b6:5:1c9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.13; Wed, 10 Nov 2021 06:43:11 +0000 Received: from DM6NAM11FT017.eop-nam11.prod.protection.outlook.com (2603:10b6:4:ae:cafe::8) by DM5PR07CA0111.outlook.office365.com (2603:10b6:4:ae::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10 via Frontend Transport; Wed, 10 Nov 2021 06:43:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; broadcom.com; dkim=none (message not signed) header.d=none;broadcom.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT017.mail.protection.outlook.com (10.13.172.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4669.10 via Frontend Transport; Wed, 10 Nov 2021 06:43:10 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 10 Nov 2021 06:43:06 +0000 From: Xueming Li To: Ajit Khaparde CC: Luca Boccassi , Lance Richardson , dpdk stable Date: Wed, 10 Nov 2021 14:29:42 +0800 Message-ID: <20211110063216.2744012-99-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211110063216.2744012-1-xuemingl@nvidia.com> References: <20211110063216.2744012-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 19a31059-8835-4adb-34da-08d9a4155cb8 X-MS-TrafficTypeDiagnostic: DM6PR12MB3930: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gVkt0l6Cd4cWQaZQkhK2+v20nh1MUrBGYOW2R6ffNouvHSiL6061Oypew/pjY7vER2ARp7mwI0kncUEZGkqKGXqChA5bvkFQVNVuItgLljJDduKpOu1TXKZa7er7iK3P+SOesGmjpvaUhd19JP7+k5AGk1nZ4BqK6oejR7XMB2dJXI7lzr/j+5NAW8jhA4fpJgNZtytJgEPnlDgGGMZltbcveD6aUOa13gS33lwPxKSYsi3EcxBuv3dS9gMvoTxUqEMTwucfLC7LT1+cJOk1zC8X3PpFPio32UFqPZcKea3b3Vad+/dlpj4WYzto9PTRtLQHGpFNB/cJURo2emMJHdm+HlOAo4Vz+c9ygskLuY5+kikeIJj2pgUxDs9m2nHWSOLepZStejReaecE6ck/kOJ5V2p2veS/tYHPgr7xwYA9XOFPPpnco2ufateB5ME0CVeWJvKNb612GYiWp5p5Tdo7oXnVeIDohNeGCr/pSbLiRIAfAoqc795NAgv36/H1QJIVbl4TF8EXjhCFpuXzFw9/MDwMO5emFil39wyLO0BcE+pHMWDAb6ifBUbJUmm8bHK/373KbUI+gxNAL3JkhCVWg+u18+RNruqLeoITImcC2oS3V2wOFGiA7rcOhgKQJ4NVv2cKFEIUbeg4HIXZHiryVuL3Cm0fFpBsWXTnMsnwvVZbThaQuqRoAVWFhej5T2OX3FWkGKmrC0wDQT5CKJ2ultVQDGOPZD77hz2yrFiC9ZUqvncw3jdFZd4gnIzmZPS3TRQJTxto07jXFfu7kb01LWv9ZEs6G+ALj0Z+tYJaEOjy7Jo/gkOa85e1K5KWTzlhhA6n54dxQDJnbzWBlA== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(508600001)(316002)(966005)(36860700001)(26005)(5660300002)(356005)(7636003)(1076003)(6666004)(82310400003)(8936002)(4326008)(6916009)(2906002)(4001150100001)(6286002)(86362001)(7696005)(47076005)(8676002)(54906003)(53546011)(55016002)(186003)(70586007)(36756003)(16526019)(83380400001)(70206006)(426003)(336012)(2616005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 06:43:10.5291 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 19a31059-8835-4adb-34da-08d9a4155cb8 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT017.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3930 Subject: [dpdk-stable] patch 'net/bnxt: fix Tx queue startup state' has been queued to stable release 20.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/f1c89a7eddcb815390761140a83539bb91a4ae72 Thanks. Xueming Li --- >From f1c89a7eddcb815390761140a83539bb91a4ae72 Mon Sep 17 00:00:00 2001 From: Ajit Khaparde Date: Fri, 17 Sep 2021 13:20:45 -0700 Subject: [PATCH] net/bnxt: fix Tx queue startup state Cc: Xueming Li [ upstream commit 0f22fe124bffcbfa15a8179b9cc835ae64b1a3fe ] Default queue state of Tx queues on startup is not correct. Fix this by setting the state when the port is started. Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code") Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson --- drivers/net/bnxt/bnxt_ethdev.c | 10 ++++++++++ drivers/net/bnxt/bnxt_txq.c | 5 ----- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 3c0ab629c3..55034bccb5 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -805,6 +805,16 @@ skip_cosq_cfg: goto err_out; } + for (j = 0; j < bp->tx_nr_rings; j++) { + struct bnxt_tx_queue *txq = bp->tx_queues[j]; + + if (!txq->tx_deferred_start) { + bp->eth_dev->data->tx_queue_state[j] = + RTE_ETH_QUEUE_STATE_STARTED; + txq->tx_started = true; + } + } + rc = bnxt_hwrm_cfa_l2_set_rx_mask(bp, &bp->vnic_info[0], 0, NULL); if (rc) { PMD_DRV_LOG(ERR, diff --git a/drivers/net/bnxt/bnxt_txq.c b/drivers/net/bnxt/bnxt_txq.c index 795056e457..6c5e6948a7 100644 --- a/drivers/net/bnxt/bnxt_txq.c +++ b/drivers/net/bnxt/bnxt_txq.c @@ -164,11 +164,6 @@ int bnxt_tx_queue_setup_op(struct rte_eth_dev *eth_dev, eth_dev->data->tx_queues[queue_idx] = txq; - if (txq->tx_deferred_start) - txq->tx_started = false; - else - txq->tx_started = true; - return 0; err: bnxt_tx_queue_release_op(txq); -- 2.33.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-10 14:17:06.372807544 +0800 +++ 0098-net-bnxt-fix-Tx-queue-startup-state.patch 2021-11-10 14:17:01.860746172 +0800 @@ -1 +1 @@ -From 0f22fe124bffcbfa15a8179b9cc835ae64b1a3fe Mon Sep 17 00:00:00 2001 +From f1c89a7eddcb815390761140a83539bb91a4ae72 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 0f22fe124bffcbfa15a8179b9cc835ae64b1a3fe ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index dc7dee1d2a..08537d8b87 100644 +index 3c0ab629c3..55034bccb5 100644 @@ -23,2 +25,2 @@ -@@ -814,6 +814,16 @@ skip_cosq_cfg: - } +@@ -805,6 +805,16 @@ skip_cosq_cfg: + goto err_out; @@ -41 +43 @@ -index 830416af3d..3ffc334cff 100644 +index 795056e457..6c5e6948a7 100644 @@ -44 +46 @@ -@@ -166,11 +166,6 @@ int bnxt_tx_queue_setup_op(struct rte_eth_dev *eth_dev, +@@ -164,11 +164,6 @@ int bnxt_tx_queue_setup_op(struct rte_eth_dev *eth_dev,