From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D881DA0548 for ; Fri, 12 Nov 2021 07:52:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C65BD40687; Fri, 12 Nov 2021 07:52:07 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2135.outbound.protection.outlook.com [40.107.92.135]) by mails.dpdk.org (Postfix) with ESMTP id D545740687 for ; Fri, 12 Nov 2021 07:52:05 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iXhG2TZu0+A4EqmdbFXc9sHMNeUI/1DGPFTC4s81UpbODfG19CoWkkLXuAmwUkgIDEkzYTd+WuHsJIERKOOMGY4ylfTh0T2OBDazUG/attnI+L14sdoDChD0ZZ9FIccCoLZXgtQl1cXgh5y9Ydgcy5m3DJU0kExbAzPR7C0y6lxrBXkfqGls35wHCUXA8NBVfO4lfkj5kG2e36NXNBIu1WV2m3l4/XcgGzc2bfU5BXENYqMae9W937viazwWpYrLgKlWcvSsZr1g2af3T6e2JxuVaYLGcGOLw4aEzHtzlajJkJn/OvtK7vWMYE3d7Px3sgcbuEZOIqtsrYBPkutK2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A5muz01gVveUfqw4S+y21YxcaOvVuT43PIXo8ZCypj4=; b=lkX0/kYyUnTAiD2uUIhl9P2Cr4teI8UQvXfGavFnR3TiFzZTN3osgHzsTIFQ6qVESyPs5EWBo1KKRXZWmqVP8PlnAKbQbF2udHbochrCEJ47AP5IMOLOJdrjduRX+CfwQdY5tj4ocEwvGcwh7r+AOLSGHxS3H9eOZsgTDVgDCGE4+zH/2Ma0SGn7aDLL6MUm/F2s9wXmDz2ek62p87FK1aJ+QfbpcDTzWJX5vMJGObHFtg8mfomERtgHH4889uZCuZGUrOhI0+zQ96gsSIR9cjSZeews19YmhqknQQHsScxskTuCM5QBkqUrjPdAiR1tGSVGZJUkQKKnWZkPbBabMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A5muz01gVveUfqw4S+y21YxcaOvVuT43PIXo8ZCypj4=; b=rdXJxBisfMuqQwlhLJ9Oq6e/7Vzhml82akSmLLP0f6OeD2r23hl2NiubVsMjAryCfSFJoXdGiNuoHOvN4gQDMcmGiqKi+hKfSZZuMaTQSIfK1P2bQ/chK8e+Lj/EuLkmakt1cecQGggPFt/yAwG0DYBNNV3xjxu+wMokBUxn5fo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5381.namprd13.prod.outlook.com (2603:10b6:a03:3d2::17) by BYAPR13MB2533.namprd13.prod.outlook.com (2603:10b6:a02:c9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.9; Fri, 12 Nov 2021 06:52:02 +0000 Received: from SJ0PR13MB5381.namprd13.prod.outlook.com ([fe80::2018:e8f5:7db8:e47c]) by SJ0PR13MB5381.namprd13.prod.outlook.com ([fe80::2018:e8f5:7db8:e47c%7]) with mapi id 15.20.4669.009; Fri, 12 Nov 2021 06:52:01 +0000 From: heinrich.kuhn@corigine.com To: stable@dpdk.org Cc: Heinrich Kuhn , Simon Horman Subject: [dpdk-stable] [PATCH 20.11] net/nfp: cancel delayed LSC work in port close logic Date: Fri, 12 Nov 2021 08:51:24 +0200 Message-Id: <20211112065124.47457-1-heinrich.kuhn@corigine.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: JNAP275CA0060.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:4f::14) To SJ0PR13MB5381.namprd13.prod.outlook.com (2603:10b6:a03:3d2::17) MIME-Version: 1.0 Received: from localhost.localdomain (155.93.216.149) by JNAP275CA0060.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:4f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15 via Frontend Transport; Fri, 12 Nov 2021 06:51:59 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b59abf10-56cf-441c-7831-08d9a5a8eddf X-MS-TrafficTypeDiagnostic: BYAPR13MB2533: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1079; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WTzgUWduf9wKCVJGrtCs26oTIpy6Jo385hcGPe8R/zvclRigyosd90Pd7zU2EG64B+x/bn2kMk6nAFmQ2TtBegPJs6BkCK9WmTUTrQbZ8dS5XWWNtY3lwP4X3glZSvuVG3DCWHgrQ7iy88OpjvSI6ypW/1wWxzspfmhYf1KhpwZri33XmSX26O2d4m9SHzQi2cG+RkLDHQTLjwgum+x0jkH6him2gc1KP+7lfH8d1+hevaYvHDn+qagrhjFThPpBYQt00lr2lJ1Og9IZ3RNAthdPI5wKoryp4pgvqDOTXWfK8tP4X62SOJ4aaQ6yJhS9sPzbRUq8AhIZ19BUqlhEYl3iirzmockpSMnflYORtm0A5zjILpyNWXSOLzNu+kbnJxHHVGbWexlzvEt5UJO9FOkvI/BukD94/DCs/l9WNXuFl+0le2Izb4gLDdwPSLohwsfwoChNlDA/SMplY/ClwR1SEpYsXhs//qRU50kgQQtQLvQgALDo2VgtcKJ0xJS2i7/TLik/2zbFqxOQtzouHO6grJ8Qz0rCKPgCLNQCpWui/FUQ+SKXpj9aEbYg5E7ULNzE76YMZHXuAekvdjgIaSAJQYdFB4Prx33kvcK9MOSnBAy4U5nQe9uuP2tzEd5NzLbm/2izsURLo4mY37/uPasuw9m0Pwf19IqlbLsWlbldUVXHOVknpEimWaGCj1wD7FFLClqFnfeZj4x790T5g4TwGa/XadtwjLhIBFnfpVw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5381.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(376002)(366004)(346002)(396003)(39840400004)(186003)(316002)(52116002)(38350700002)(38100700002)(66946007)(5660300002)(26005)(6916009)(1076003)(66556008)(6486002)(54906003)(66476007)(6506007)(956004)(6512007)(36756003)(508600001)(8676002)(6666004)(4326008)(2906002)(83380400001)(2616005)(8936002)(86362001)(9686003)(107886003)(46800400005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KsJcF3Bd6kpZLOohkXd+BarLgHOlj3BQNn7yb9tPd0jzpiORS0b/8PmUReFO?= =?us-ascii?Q?KZNbNphH285L4LExadU+cZl8Ox7uMaUIYhD31b31G6Vvm4IT7r2d4Tu6NuuY?= =?us-ascii?Q?FYRzCnY//zWVU/NniYQUUtTvPNNk/smJsJF2V1cClk9ya/oZDsCEK4KHP2dC?= =?us-ascii?Q?aGYTLDqXgSiEk4453C48dzlgVe0tKvflAJbizKpm440VQzp8nizeQHE6qgC9?= =?us-ascii?Q?fA7+XPGp13gBRhpgzR6uyd0Atq1RIJ5LFGZrA3B2pFDhpUKFaLkUfvLb5Qt1?= =?us-ascii?Q?0QfsDZxp/z+xUSOKGb27fLiS/OcD3G51+uu2Lva2CDQYOTKuskdTeOP8V+yP?= =?us-ascii?Q?92Ev8dp7a0iEz9lwm/cNWHIIGxMceLD+aqLfM8MvSyNp4TMwrNTGmm3eRaMk?= =?us-ascii?Q?LVrHFP+hdr2NcJF22iidSFQHGMjIxkyuWyaY2kvIFosChraRrg9fb23YBQn7?= =?us-ascii?Q?kE4RrDzU4QdalWzgqfbsmSlWgktgxIJci3eDW56BPsfijnO1hOwpqddaKkNp?= =?us-ascii?Q?RepLOg/o3XKRKDYTIRn7ohMAqOC1vz/uU+fDYKz2fxpH6wgdrqK4xjLMRdBR?= =?us-ascii?Q?Vuynn10Eetbq8Z1SzwlvAYV0Zok6nZ/r0Tif/soHAfo32daG35vn85xtrypy?= =?us-ascii?Q?wfAPKnh6/vSdpWFIIecKYx0wI1PcvUbwY9E0SNVxyTG7aw/F8vordqD2p/C2?= =?us-ascii?Q?4M70AEVWLPT3wHXemrbb32YkUMOuKj+zPzti2l9lRcGWeoLGjEoRLHvixV63?= =?us-ascii?Q?cQL58cJb5rrP2hRKXaeUMY3H4q9c9UKCNMYmsaLYUlaIl1qJJDNGux7j3GTe?= =?us-ascii?Q?2TGXZ540/yyNuxQUoqRXME6i10Klr4OuP7huijP8jM68QC0Dzr2i4Ens+TJW?= =?us-ascii?Q?5uHWiqvWPSSr/lCiLUhm2xGYYPgyG16I1xrC/zVdhWeUqwGxCRD+clkVXrQI?= =?us-ascii?Q?TtZCspXCubhGSfluX/PYoNQvyOBPtIsh+8+9y+c9IMLgTmR8q979yTn5y4yB?= =?us-ascii?Q?9I3HPp+xxW89QXX+fokETmtLNzU9UcVJ2g5+CPaO93mwUwNGITxLlNShubX8?= =?us-ascii?Q?R2s9XKSg3PTsg6ZXqX4ehqzSctVRye0gVeMYgD1OnreXtVDpFErU0L6SyMkV?= =?us-ascii?Q?t7TV5WgIHmeN6XuiHJmBTQ6IjbW3SnMclt1P3gkF3qTZsBD3qqVUt3ijPnLe?= =?us-ascii?Q?hn29dC6BlKD+LcGvDswvdKUDzeQugAC0D9eQl31CDYTXNjkfhBaCkAu/aDqo?= =?us-ascii?Q?JworqZy//u8G7zA7N9VZg9idEncffhpsTiyXlj97dI1nCwTNxJlvbcBIZbdP?= =?us-ascii?Q?QOjJf9s0GtsUNQ9DXZUCOoX4aHUN/+qRP5d4PI5PFgG4urluv12abvcC0wKU?= =?us-ascii?Q?yHEGuFLnfihjeaHhdRe89zcW4tn6F2N11XQmpeQI4/19WCHL0Y0TYk+pxdGB?= =?us-ascii?Q?fynNoj6jS8sxcfRf7Yi5pQa5/wxgG26VTGdXK6iDEHoCOKf9PChEq3NuCmc5?= =?us-ascii?Q?Iikg80EmMTKXVUIW7fN1/DyLt5NMv9XHRtGkOvO74o31EakHToqhEM1CldZg?= =?us-ascii?Q?dqxZ7uHiOUpzXacgm4Pth9J9HGc7CwwVYziww5AxCBkmj9Eq2iUyZ31zbvHR?= =?us-ascii?Q?fKf8v0r0OeHnOP8Vucsm3qJgIOb3iutqnHvgFiVvwwb+Jxgk6tNaHhxxcpob?= =?us-ascii?Q?4aLOXg=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: b59abf10-56cf-441c-7831-08d9a5a8eddf X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5381.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2021 06:52:01.5959 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aijc0O3W/yqkSl2z4P2wZt/WnQZFT6YHWMMRnaRWXnQeYMkUGzBpv6vLC1TaITlprfXIh09vvuLYNFJxSHYPtn7ozsqz382crqAeJsW5FwM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR13MB2533 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org From: Heinrich Kuhn [ upstream commit 851f03e1eab7d29a81078832b49f2977e9562524 ] The link state change interrupt handler of the NFP PMD will delay the actual LSC work for a short period to ensure the link is stable. If the link of the port changes state and the port is closed immediately after the link event then a segmentation fault will occur. This happens because the delayed LSC work eventually triggers and this logic will try to access private port data that had been released when the port was closed. Fixes: 6c53f87b3497 ("nfp: add link status interrupt") Cc: stable@dpdk.org Signed-off-by: Heinrich Kuhn Signed-off-by: Simon Horman --- drivers/net/nfp/nfp_net.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 91c6678c7..39a6d3f57 100644 --- a/drivers/net/nfp/nfp_net.c +++ b/drivers/net/nfp/nfp_net.c @@ -907,6 +907,10 @@ nfp_net_close(struct rte_eth_dev *dev) nfp_net_dev_interrupt_handler, (void *)dev); + /* Cancel possible impending LSC work here before releasing the port*/ + rte_eal_alarm_cancel(nfp_net_dev_interrupt_delayed_handler, + (void *)dev); + /* * The ixgbe PMD driver disables the pcie master on the * device. The i40e does not... -- 2.30.1 (Apple Git-130)