From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
David Marchand <david.marchand@redhat.com>,
Elad Nachman <eladv6@gmail.com>, <dev@dpdk.org>,
<stable@dpdk.org>, Igor Ryzhov <iryzhov@nfware.com>,
Eric Christian <erclists@gmail.com>
Subject: Re: [PATCH] kni: restrict bifurcated device support
Date: Tue, 23 Nov 2021 11:10:21 -0800 [thread overview]
Message-ID: <20211123111021.08763407@hermes.local> (raw)
In-Reply-To: <0914b58e-de54-50ef-7e48-febf9688eb09@intel.com>
On Tue, 23 Nov 2021 16:51:27 +0000
Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >>>
> >>> diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c
> >>> index 611719b5ee27..d47fc6133cbe 100644
> >>> --- a/kernel/linux/kni/kni_net.c
> >>> +++ b/kernel/linux/kni/kni_net.c
> >>> @@ -838,6 +838,14 @@ kni_net_init(struct net_device *dev)
> >>> dev->header_ops = &kni_net_header_ops;
> >>> dev->ethtool_ops = &kni_net_ethtool_ops;
> >>> dev->watchdog_timeo = WD_TIMEOUT;
> >>> +
> >>> + /*
> >>> + * KNI is unsafe since it requires calling userspace to do
> >>> + * control operations. And the overall quality according to
> >>> + * kernel standards is the same as devices in staging.
> >>> + */
> >>> + add_taint(TAINT_CRAP, LOCKDEP_STILL_OK);
> >>> + netdev_warn(dev, "Adding kernel taint for KNI because it is not safe\n");
> >>
> >> I am for discussing above separate from this patch, since this patch
> >> restores the behavior that exist since KNI module exists.
> >
> > Any user of KNI will already get tainted because KNI is out of tree driver.
> >
>
> I mean the note and explicit 'add_taint()' you mentioned above, can we separate
> it from this bug fix.
I changed my mind, the existing taint that happens from out of tree is enough.
Especially since KNI is now deprecated.
next prev parent reply other threads:[~2021-11-23 19:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 23:58 [dpdk-stable] " Ferruh Yigit
2021-10-09 2:03 ` Stephen Hemminger
2021-11-23 9:54 ` Ferruh Yigit
2021-11-23 16:22 ` Stephen Hemminger
2021-11-23 16:51 ` Ferruh Yigit
2021-11-23 19:10 ` Stephen Hemminger [this message]
2021-11-17 16:42 ` Igor Ryzhov
2021-11-23 16:46 ` [PATCH v2] " Ferruh Yigit
2021-11-24 13:51 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211123111021.08763407@hermes.local \
--to=stephen@networkplumber.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=eladv6@gmail.com \
--cc=erclists@gmail.com \
--cc=ferruh.yigit@intel.com \
--cc=iryzhov@nfware.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).