From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30EE2A0548 for ; Sun, 28 Nov 2021 15:55:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 25D084068A; Sun, 28 Nov 2021 15:55:29 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2044.outbound.protection.outlook.com [40.107.237.44]) by mails.dpdk.org (Postfix) with ESMTP id 1F74740E5A for ; Sun, 28 Nov 2021 15:55:27 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UXakdcdt/JRZw1d+iEmvgzocGNCXSb/bNhvfo4ptAD0lDwa9lKPRcpL8qjOiSioFncSJWSzG6hpuQVS3HW+rwYRavI3ZZ7HakAl6+HT+YXsCpb/HexXbWMY4qPTk6BjFrclI8rObl7vfYoOkp+pVMT8jMfOL/UUedTbRIn4BPvEZX61bW1wexqpAuYyQ3xpzohS2hLl5/LfKFgrqtbT9+2nAnuvSKRYK3VCELSs+96Vqdo5fSm3ufqYObJwZ5opwI3xsGAz3rVRSY3wz6bSHCEGePt4TJ3YqMDE468XWvyvggkJocS1GpCNrZOWIIjAsrsbwrcjAA5MMoV7Kk11nvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NEL6b6vTKUQ3tu73izVZXOuOiV0Vhl5uWuu0+wo0PNg=; b=Gv9kbKTojBujwcIt9gl6K8P+IlMo+4wOrylYkfy8cIMYjAo2AEqvBjcSXWBM0VaeNk7EsdBnobzTOH0N4jTMUr3ugPRa34f0qLAaGBr32T2gjZCOT+5vggH8Qiy89q+VX49rBnw4+vZeTtZz0Q8xcj7Ll5L5GjD4w1FMNQZnIpQsutgEb0gV9jRREqOK4yoi8MkO+BdgUO4cXrwvBWsA6op7um7En9qRIOQuBQHsPBOpyQi+IC1l3ivs6eQqIGIgc9awx4CzH7WwQCpWk2cObeVFK4JBApKGH76rBTVH5+jxI3pqZ/ZWNvMvKdJkYaQwGEzYSaj3SyFIhN4MrRgtBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NEL6b6vTKUQ3tu73izVZXOuOiV0Vhl5uWuu0+wo0PNg=; b=Irbpl3W9T8PbuzvlScpwW+7rjUinNAKIWGzvWTUzVCAFjut1Q/g3oxzUR3ksHkF8uEahWAlRaPzLH/eBqPgNUpsnJTIwb9OLIBjQDk8DnQwfZs0SNL9S9mV9AMe0/V5+qjWVq9Eni0q6bUNfNALIdr9hHe9c77/U/96xGzf4MXfxYEcUbMEi24xzBNZJKNAzPq46u6ENdURHNAUaNzaIZChuDl1kGHvB+UwLzk8x8O61qFR2uROW2G775XF5agU4H1yvnteKL/B8T/2pmsafihqCGOMbII2bcAiMsasraLHlC820QqcaCeoE+bZXRXBh2r77g5KHDSOElSyJnLBiBw== Received: from DM5PR06CA0069.namprd06.prod.outlook.com (2603:10b6:3:37::31) by SA0PR12MB4397.namprd12.prod.outlook.com (2603:10b6:806:93::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Sun, 28 Nov 2021 14:55:25 +0000 Received: from DM6NAM11FT044.eop-nam11.prod.protection.outlook.com (2603:10b6:3:37:cafe::7b) by DM5PR06CA0069.outlook.office365.com (2603:10b6:3:37::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.24 via Frontend Transport; Sun, 28 Nov 2021 14:55:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT044.mail.protection.outlook.com (10.13.173.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4734.22 via Frontend Transport; Sun, 28 Nov 2021 14:55:25 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Sun, 28 Nov 2021 14:55:22 +0000 From: Xueming Li To: Bing Zhao CC: Luca Boccassi , Viacheslav Ovsiienko , dpdk stable Subject: patch 'net/mlx5: fix RETA update without stopping device' has been queued to stable release 20.11.4 Date: Sun, 28 Nov 2021 22:53:13 +0800 Message-ID: <20211128145423.3974892-10-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211128145423.3974892-1-xuemingl@nvidia.com> References: <20211110063216.2744012-1-xuemingl@nvidia.com> <20211128145423.3974892-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0de4080c-60b2-4870-084d-08d9b27f1c1b X-MS-TrafficTypeDiagnostic: SA0PR12MB4397: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IGqhs9YSk2t411hnV7gpdE77NdrVZ4bTCN5WFga+rMz2adIVSjufUbOj5coiYhUA+SXdacqneNLc6Q/LnEMt2cIy5vRkMKG1kDP/f7IBnHpswYUvJOrUL2HeaVDY/wQ8blYPXUeciXxO6YF+fRwELG3A23WpQG81l4afRefaIkv8X60DaFMNt5ZwWowWLYyfz/o4R8pZmi32kqHdQQNjaGsaYSc22KG4mJoAzWeZq/3fzwcnMsy2DQnvz+JoCBoUze4CR6x64CZL90uvOXQiPBzGl1oYvJwKvBNqQpGHdUlrksNYGFg1hIpmjc863wSQamS9md0GOTIZzlUWdhahBIWd1r/BMRRSYFhsQgAN3GojWgefkeVVEVEIWVanF2Ik7Php6lXvZ0K3ZGnT+l1Jfmu68zFXcENv0sEGkx5DUhhye8vDQQ+gCYWk6od3YPZ31OiPkDMay1X2QmbgKts6zspxlw1N0oSBoT3tgxRlQe3ed7JEswhAeWeqxcmP/eWbPrltEFgWMuQmUo8/5onZRK3XBAWgG0T4C05GT4kz6aW6FNfiSQ3b9YRDfkbnax9gCeCF4sjVjGtjUlXBM11KgXiBFXdeu8gETCSXinqkr7aYoNrj+jjaAQU8o6ebhdWIGIQEvtH8RYnTytSVkH09uDc25IBevYaLsySCMsdomwFd+9WdbL20OwXwihakiGYGx8ZYhCYCig2JnEKohYb4VpuZ4tX05nfVVtmuns76aRQYPMSOXWkw8xuBoD5kiLF+CIExeRZ4JXhe7yJxbdjoVEcp4+Bckl1zx9wcb1VknaVawU7LFi/ZLlKWQu69Zr0OTpyQENJUYbXP/kVmbJtBKg== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(6862004)(55016003)(82310400004)(7696005)(36756003)(6286002)(966005)(7636003)(1076003)(4001150100001)(70586007)(70206006)(86362001)(6666004)(4326008)(6636002)(15650500001)(508600001)(336012)(53546011)(356005)(8936002)(47076005)(16526019)(2906002)(2616005)(5660300002)(8676002)(37006003)(83380400001)(54906003)(26005)(316002)(426003)(186003)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2021 14:55:25.0371 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0de4080c-60b2-4870-084d-08d9b27f1c1b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT044.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4397 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/30/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/6d132c0f7329b26ce88cdb082bc50ca69d38e8b6 Thanks. Xueming Li --- >From 6d132c0f7329b26ce88cdb082bc50ca69d38e8b6 Mon Sep 17 00:00:00 2001 From: Bing Zhao Date: Fri, 5 Nov 2021 08:10:57 +0200 Subject: [PATCH] net/mlx5: fix RETA update without stopping device Cc: Xueming Li [ upstream commit 6b5b3005cb1854e471fa1ef3eb579dbd444c05b0 ] The global redirection table is used to create the default flow rules for the ingress traffic with the lowest priority. It is also used to create the default RSS rule in the destination table when there is a tunnel offload. To update the RETA in-flight, there is no restriction in the ethdev API. In the previous implementation of mlx5, a port restart was needed to make the new configuration take effect. The restart is heavy, e.g., all the queues will be released and reallocated, users' rules will be flushed. Since the restart is internal, there is a risk to crash the application when some change in the ethdev is introduced but no workaround is done in mlx5 PMD. The users' rules, including the default miss rule for tunnel offload, should not be impacted by the RETA update. It is improper to flush all rules when updating RETA. With this patch, only the default rules will be flushed and re-created with the new table configuration. Fixes: 3f2fe392bd49 ("net/mlx5: fix crash during RETA update") Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_rss.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rss.c b/drivers/net/mlx5/mlx5_rss.c index 0aa3b4ed98..c79cfcbba8 100644 --- a/drivers/net/mlx5/mlx5_rss.c +++ b/drivers/net/mlx5/mlx5_rss.c @@ -215,12 +215,6 @@ mlx5_dev_rss_reta_update(struct rte_eth_dev *dev, MLX5_ASSERT(reta_conf[idx].reta[pos] < priv->rxqs_n); (*priv->reta_idx)[i] = reta_conf[idx].reta[pos]; } - priv->skip_default_rss_reta = 1; - - if (dev->data->dev_started) { - mlx5_dev_stop(dev); - return mlx5_dev_start(dev); - } - return 0; + return mlx5_traffic_restart(dev); } -- 2.34.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-28 22:41:04.028075704 +0800 +++ 0009-net-mlx5-fix-RETA-update-without-stopping-device.patch 2021-11-28 22:41:03.213542911 +0800 @@ -1 +1 @@ -From 6b5b3005cb1854e471fa1ef3eb579dbd444c05b0 Mon Sep 17 00:00:00 2001 +From 6d132c0f7329b26ce88cdb082bc50ca69d38e8b6 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 6b5b3005cb1854e471fa1ef3eb579dbd444c05b0 ] @@ -28 +30,0 @@ -Cc: stable@dpdk.org @@ -37 +39 @@ -index 75af05b7b0..e2b478b75c 100644 +index 0aa3b4ed98..c79cfcbba8 100644 @@ -40 +42 @@ -@@ -218,12 +218,6 @@ mlx5_dev_rss_reta_update(struct rte_eth_dev *dev, +@@ -215,12 +215,6 @@ mlx5_dev_rss_reta_update(struct rte_eth_dev *dev,