From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EFB7CA0548 for ; Sun, 28 Nov 2021 15:56:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D060840E5A; Sun, 28 Nov 2021 15:56:06 +0100 (CET) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08on2079.outbound.protection.outlook.com [40.107.100.79]) by mails.dpdk.org (Postfix) with ESMTP id 5565242735 for ; Sun, 28 Nov 2021 15:56:05 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BUqZkxYRTjGsv58I2nPgn/l13bCaBa4HkvJICceCTocgv6k9Zmo1RrYx4MifwpBRijrHnIqDU5TJAxqKg61NUwn2SZ5eWHLkq5wyAlJmEmuhgCtd4BX/UVgTjcGsOoGwIrXAghN1SyDDusleHgX+AXk/lhrE5sZdyIknQQR3X/XClssTK0neamR96/9toWci4MZcAQs2Hx2sB9/VqUaReghZptSzcOoteB43rbLKQJR65DFcO6aoeWOKBHwDFwmoJMSv3+TyZxiLs2FW80PB63czxUiuXQ41uq96MoQdS+6bBJzehx3Ofx52XDzuf7HDWJWHmEmfAdALn/kLQrgf+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DMQu8npC0p7ZU0MSrIDfh2pXFHhbD7pQIMto6mloJ+0=; b=WDCWaoRF4K/lOXNpjglrFJNX+S4VvaMDIWYZxGxNkLLkHgTee9iAsniC/QdprRKbiY8j7O7bf04Um+gSUZr91yUFN166vsbe+wMyLzduAcs0NfnJmUSgEuA1Z1m19qEW6dbdxkT8w4XNJENcRSWvDvplPn39l1op3KX4gQma4YGuD5zmNqagW9hGmmtTsnPPYuNrwycwyq5ohPXq4tZnVvJoTDCVzsiEUq0TjyMhXjgY20kjVNncZ5vDaYyK5zI4Fr8apH/yKC5crsQWY8bXh5uew7q26+24NwXuDCuEnNnfRbzN35EiYu0iiXM2gdUmBxqg2q/KfY7/XOxlZRE9DQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DMQu8npC0p7ZU0MSrIDfh2pXFHhbD7pQIMto6mloJ+0=; b=VWmJwmXTRIgwr93sUkm7yuylZsP3Vl6z00zhcBTBBmZV7euIFstkN4d2NZATmz+eTmQz44KezYtYZwky/RlBoPJIn6IR+nKONQwf6bfpif+eC6czVYkiDLxzbf+Bm2A86X2qgUNecRz9GfBe72P7Y3i0XwHcJiQ0dwl+39IjoMIuxJM6DLXbbBJYqhwV6vMYuVRqtyd8p2Xa6WFTaarKQqZtUhzzj6bFBb/BWrnSFnJldNn+WZIlFxcVMwmAbNE1erP1CbbtYYn2ABmYlLnGcN14zf+ICx4wuV9Wts4Q5MlokFBU3/LVPwx9ukg/fsjbNCzj+S8J4FU6qSBf0a9Hfw== Received: from DM6PR13CA0056.namprd13.prod.outlook.com (2603:10b6:5:134::33) by MN2PR12MB3647.namprd12.prod.outlook.com (2603:10b6:208:c4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.24; Sun, 28 Nov 2021 14:56:02 +0000 Received: from DM6NAM11FT060.eop-nam11.prod.protection.outlook.com (2603:10b6:5:134:cafe::c6) by DM6PR13CA0056.outlook.office365.com (2603:10b6:5:134::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.10 via Frontend Transport; Sun, 28 Nov 2021 14:56:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT060.mail.protection.outlook.com (10.13.173.63) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4734.22 via Frontend Transport; Sun, 28 Nov 2021 14:56:01 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Sun, 28 Nov 2021 14:55:59 +0000 From: Xueming Li To: Alvin Zhang CC: Luca Boccassi , Qi Zhang , dpdk stable Subject: patch 'net/iavf: fix pointer of meta data' has been queued to stable release 20.11.4 Date: Sun, 28 Nov 2021 22:53:17 +0800 Message-ID: <20211128145423.3974892-14-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211128145423.3974892-1-xuemingl@nvidia.com> References: <20211110063216.2744012-1-xuemingl@nvidia.com> <20211128145423.3974892-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 489c9846-b7a0-4c32-3c1a-08d9b27f31da X-MS-TrafficTypeDiagnostic: MN2PR12MB3647: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FQX354HikOQDEGdzcBGnlmnmNrrFVMMgmnrXEJqXCZC6Bo5rkK4/dPP8Nzhx2BAu201uJwhjefq/E9zpTqlQj4mbHSl0XilAQLfuFrll0Vf1+/635muti4aTFMXix/GIUY3TGA71D8EB0O0cDDo6XHjatlYcFcdJmB+zjadvUqG5ENKdKQvlKjtLd3NIsdHcRwsnQdTQlBmZPi1xWzaLSH8COaSgOBdwoUJKL8cD/JF9mibGys0/C1y19ypgszdP5TruVnwuZVVBl+DTDRLb14L8E+//kfRJgf5MTRDd6AZyu0D+U/K6ASUo/pD/zhOBmeMRsz1M4ueOyHKhBnuXtmvu45cIN84hnGWK3wmtQa1sUHJQgy62aWhqhqTNgzZbFd6KZVOqEyh66x3RYygsY6u5mXcvlqJHCuxD+cIxZRtzTVRMTGYwwVOzbKLTO+yaZBrqnZycH01slr9LJHRYY63ivGwoYbcP/+XgJvAW2/LQHJwV8fYhHplUpnmLHZq3v+WeC59S6jgzFWRrl4C/qsvmuNIn8iRHC4EpPDCpp7VMai1N/Mf3RkIZKKbWSZRN3kNfz5DlSg9bzoxH4LPOrgir/ANj2Sm8VYF88ZQExWY6xYnpeNAzgiVwY1KwEQgdg1vDQY41mXneppso5EmM7/zj+Wgr4e7BomnU02Wcpibh97fhARmpbMh1lyWsmLr7b8VrTl2gL5J0gnOHqGjNDiZlGAYyOSLJ52gUFYX44Xb64h2yQ9riR2Kcum2/MBXgA4khofRbxMCs/0ksa7l9h8yKLn+YI6PuyLpW9yL5gws04QtJ3MAsiHcnt46pHJT0EvGxDw04o7DS/W0mhdZWWA== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(336012)(426003)(83380400001)(86362001)(47076005)(7696005)(2616005)(2906002)(6286002)(82310400004)(8676002)(4001150100001)(36860700001)(6916009)(55016003)(316002)(53546011)(54906003)(36756003)(5660300002)(16526019)(4326008)(70206006)(186003)(966005)(6666004)(7636003)(508600001)(8936002)(70586007)(356005)(1076003)(26005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2021 14:56:01.5463 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 489c9846-b7a0-4c32-3c1a-08d9b27f31da X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT060.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3647 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/30/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/712ace31c574c287538d606f108ffd7400464214 Thanks. Xueming Li --- >From 712ace31c574c287538d606f108ffd7400464214 Mon Sep 17 00:00:00 2001 From: Alvin Zhang Date: Thu, 11 Nov 2021 14:31:47 +0800 Subject: [PATCH] net/iavf: fix pointer of meta data Cc: Xueming Li [ upstream commit f96789aeaf1851071f5b2ab532d7687c66e1ee41 ] This patch fixes coverity issue by directly passing the address of the meta data to lower function. Coverity issue: 373867 Fixes: 7be10c3004be ("net/iavf: add RSS configuration for VF") Signed-off-by: Alvin Zhang Acked-by: Qi Zhang --- drivers/net/iavf/iavf_hash.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c index 72b0117230..eb7fd3f66f 100644 --- a/drivers/net/iavf/iavf_hash.c +++ b/drivers/net/iavf/iavf_hash.c @@ -901,10 +901,9 @@ iavf_any_invalid_rss_type(enum rte_eth_hash_function rss_func, static int iavf_hash_parse_action(struct iavf_pattern_match_item *match_item, const struct rte_flow_action actions[], - uint64_t pattern_hint, void **meta, + uint64_t pattern_hint, struct iavf_rss_meta *rss_meta, struct rte_flow_error *error) { - struct iavf_rss_meta *rss_meta = (struct iavf_rss_meta *)*meta; struct virtchnl_proto_hdrs *proto_hdrs; enum rte_flow_action_type action_type; const struct rte_flow_action_rss *rss; @@ -1018,7 +1017,7 @@ iavf_hash_parse_pattern_action(__rte_unused struct iavf_adapter *ad, goto error; ret = iavf_hash_parse_action(pattern_match_item, actions, phint, - (void **)&rss_meta_ptr, error); + rss_meta_ptr, error); error: if (!ret && meta) -- 2.34.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-28 22:41:04.209479880 +0800 +++ 0013-net-iavf-fix-pointer-of-meta-data.patch 2021-11-28 22:41:03.220209457 +0800 @@ -1 +1 @@ -From f96789aeaf1851071f5b2ab532d7687c66e1ee41 Mon Sep 17 00:00:00 2001 +From 712ace31c574c287538d606f108ffd7400464214 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit f96789aeaf1851071f5b2ab532d7687c66e1ee41 ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index 55d8a11da3..5e0888ea68 100644 +index 72b0117230..eb7fd3f66f 100644 @@ -23 +25 @@ -@@ -1261,10 +1261,9 @@ iavf_any_invalid_rss_type(enum rte_eth_hash_function rss_func, +@@ -901,10 +901,9 @@ iavf_any_invalid_rss_type(enum rte_eth_hash_function rss_func, @@ -35 +37 @@ -@@ -1378,7 +1377,7 @@ iavf_hash_parse_pattern_action(__rte_unused struct iavf_adapter *ad, +@@ -1018,7 +1017,7 @@ iavf_hash_parse_pattern_action(__rte_unused struct iavf_adapter *ad,