From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 488B1A0548 for ; Sun, 28 Nov 2021 15:58:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 422264068A; Sun, 28 Nov 2021 15:58:01 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2042.outbound.protection.outlook.com [40.107.101.42]) by mails.dpdk.org (Postfix) with ESMTP id 57B8F42746 for ; Sun, 28 Nov 2021 15:57:59 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ka1G1+1yZb/E1CsVH0kK1RHrKv5eTfdZ9yQAT6TJe2Hu9cQMzJS3iDmHRfgtMtbsAgRDTHMRZcOIW02QCEKPb6dU/kyZLB/F5ouLk2wZHTd2EQ7Su+WVI76Q92YDFhjq/ED/XtD4O1ySFiQk6DbJlosAOc/BoqDqI+xrkpg1DCliyaUxtnl3jLEY5GGdXivQSY2beZCiOvoBGZOT6R5UlNtylyqoNGiQ0fXL0G4N9ayzFCiGeItOABYoFUg4KKGSzUxQDZKkj0F+dkmXfv+R8/whntOhV36jsPj9RCDTYakk/g2nu7C2gs545xKPJyWLSAsw0xKZKEcZSY33mKzmkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UiPJqDEbkqVQja9Paq8epGihI5MmQNIg5AXsJgyShjg=; b=nV17rvxU0tfoBhM3Rx39u1Dn2/UJRzAW0egx8ZweG16wbtXwFlAM5y4s/DtZEqqzis5AsgspYqzWnpJmYhuoKI2rNqgr2RCzrLgpZfWuo2wyJWAczr8/BbEfqD3yahKfG4nF776gzb8wJqfOGB8OBIT4F5h64mdht01T9AGL7KexH/F8x22EJHnZwecDh+c1U8jmhLVNlOctKYKCRdwt57JgSVMvKOxq8d6CSdKnGNGVfKbNDah7PgJ//+LJhp9+EYVgyja7nuHCVEJXMnUOTyAhdiavBFQoYHZ0Ux+augP0/fIY6CITlTEbATKwSA432En6jKcov19ARQpka2BswQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UiPJqDEbkqVQja9Paq8epGihI5MmQNIg5AXsJgyShjg=; b=JhQ6i3UkFltgXij5MLuBHDb3IwNn1V6pGZ+NCCZYvNOcXHD+hqQuEWzZhNhcbirNUCqISAjifjy+t9B/632oyjeqHq7CQhHXdZrje9twA6DtPG6F1ZUwtQs4dP9uQ712fBcR+yjlKSQpiXlxjmVd+Mi6dGfIH+BaU+5yFpye2mFHLl5FwBrgAc911V4uzVenj86zOBH+wb+wmjqPZ+uogHONGJxBbLB0HR1K6iSkHtpszkT1vv4qF3uDTMx8kdx32st+MSd+nTyfJPQgvP45NmU2EnuVIwXu0jyOJ37Qz9gLCcsG5GtYNmUVrvD6LUO0p4/LkC6JfcoEe9FUm1iaqg== Received: from DS7PR03CA0338.namprd03.prod.outlook.com (2603:10b6:8:55::31) by MW2PR12MB2378.namprd12.prod.outlook.com (2603:10b6:907:f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Sun, 28 Nov 2021 14:57:57 +0000 Received: from DM6NAM11FT009.eop-nam11.prod.protection.outlook.com (2603:10b6:8:55:cafe::3b) by DS7PR03CA0338.outlook.office365.com (2603:10b6:8:55::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.20 via Frontend Transport; Sun, 28 Nov 2021 14:57:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT009.mail.protection.outlook.com (10.13.173.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4734.22 via Frontend Transport; Sun, 28 Nov 2021 14:57:57 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Sun, 28 Nov 2021 14:57:55 +0000 From: Xueming Li To: Conor Walsh CC: Luca Boccassi , Liang Longfeng , David Marchand , dpdk stable Subject: patch 'examples/performance-thread: remove unused hits count' has been queued to stable release 20.11.4 Date: Sun, 28 Nov 2021 22:53:32 +0800 Message-ID: <20211128145423.3974892-29-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211128145423.3974892-1-xuemingl@nvidia.com> References: <20211110063216.2744012-1-xuemingl@nvidia.com> <20211128145423.3974892-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4f1fce6d-d59b-49d7-4b50-08d9b27f76d2 X-MS-TrafficTypeDiagnostic: MW2PR12MB2378: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A+Q9kqlaOVkSuM33HIB3DPXysM+KBtBAKTmhfoC+Pg0c6K49oLlaju+jeLAOQ5agWwrZ8IV5kt7nPrJ60Dgn+HvNOL0sy9FFDDI1lY+ee+wMivJe6HwqaDYzZrLUo4YiOaZ6LG/r4ggbQmmNYoAafe9PRIeDWwbFjXgrJnOJ7CYnWnQssnTivEguuRQXRpDNI4/qywR56IpqscRUuUBS7Hz8uzlJDs9dPcXGJrzfnFxBc4xCk9t8LXSFdhnz9zugFwX8F/zt1+6xMaXLNc3JiVgieegFp0a82cE7ErhhQX8ZqfMSiJdkPYxrBugqYDD6VRZbamrtchp4VbWr6mxcMd4EaC092/E7qMKEn3zVeOKvM1ByFhWJWydASlmUc+gRYl7AtfXbY8UQrN1ug+EQJLg/rtgkxsF6IxCHllnKdy8ObXkF1SU1kO030++5RsJh7wvu6h99d2uA+UkIM0028Zg2JCVcD9TyAPXbj/W0YGV4APC2m77olo6+SakxPx0Uu/s73ens/ZpYDSkBwkfPJS+M4Yyt7rFnyMm+9isgnlm8CpoMmAUj19+sbTr5Rm7+XmnQDm1uRJwR7yw0c08JOFR5IjiLhLVI9Uoh6GhQfH714EYaBP6AW47bUq9d08Zo6vy6YZuIZA8nIDctx6M73+YxLkm0n3jgyJhOUUM9CwZZg9nKdqKSfr8sUiQnISDdv5+8pwKQYHQdoEz/f0a8ERUtePlpoGEZikaHbstqv1IeiP1ug0J6ue8gSG4dR63zwgLdCefiX5j9YT7qF6Nc3mcqsAg/LTM+FQx4r43n5uck2pHbNTAbFlbA4Qaas8UyAHT/5dUHi/9+k8Qid6kY0w== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(316002)(86362001)(4326008)(5660300002)(26005)(2616005)(55016003)(36860700001)(4001150100001)(70206006)(83380400001)(426003)(1076003)(186003)(16526019)(70586007)(336012)(53546011)(82310400004)(6666004)(356005)(6916009)(2906002)(54906003)(8936002)(36756003)(7636003)(508600001)(6286002)(7696005)(47076005)(8676002)(966005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2021 14:57:57.2640 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4f1fce6d-d59b-49d7-4b50-08d9b27f76d2 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT009.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR12MB2378 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/30/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/0d266c9fe9d9ea2cba73631e12f8c8b53cd3d8f1 Thanks. Xueming Li --- >From 0d266c9fe9d9ea2cba73631e12f8c8b53cd3d8f1 Mon Sep 17 00:00:00 2001 From: Conor Walsh Date: Mon, 15 Nov 2021 17:58:55 +0000 Subject: [PATCH] examples/performance-thread: remove unused hits count Cc: Xueming Li [ upstream commit 130e99db590073dd58da7e5c32dec8c2181527dd ] Reported by clang 13. This patch removes the hits variable from the cpu_load_collector function within the performance thread example app as it is an unused but set variable. Bugzilla ID: 881 Fixes: d48415e1fee3 ("examples/performance-thread: add l3fwd-thread app") Reported-by: Liang Longfeng Signed-off-by: Conor Walsh Reviewed-by: David Marchand --- examples/performance-thread/l3fwd-thread/main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/performance-thread/l3fwd-thread/main.c index 9830efb96f..081a3fa0d2 100644 --- a/examples/performance-thread/l3fwd-thread/main.c +++ b/examples/performance-thread/l3fwd-thread/main.c @@ -1885,7 +1885,6 @@ process_burst(struct rte_mbuf *pkts_burst[MAX_PKT_BURST], int nb_rx, static int __rte_noreturn cpu_load_collector(__rte_unused void *arg) { unsigned i, j, k; - uint64_t hits; uint64_t prev_tsc, diff_tsc, cur_tsc; uint64_t total[MAX_CPU] = { 0 }; unsigned min_cpu = MAX_CPU; @@ -1975,12 +1974,10 @@ cpu_load_collector(__rte_unused void *arg) { printf("cpu# proc%% poll%% overhead%%\n\n"); for (i = min_cpu; i <= max_cpu; i++) { - hits = 0; printf("CPU %d:", i); for (j = 0; j < MAX_CPU_COUNTER; j++) { printf("%7" PRIu64 "", cpu_load.hits[j][i] * 100 / cpu_load.counter); - hits += cpu_load.hits[j][i]; cpu_load.hits[j][i] = 0; } printf("%7" PRIu64 "\n", -- 2.34.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-28 22:41:04.862072127 +0800 +++ 0028-examples-performance-thread-remove-unused-hits-count.patch 2021-11-28 22:41:03.243542368 +0800 @@ -1 +1 @@ -From 130e99db590073dd58da7e5c32dec8c2181527dd Mon Sep 17 00:00:00 2001 +From 0d266c9fe9d9ea2cba73631e12f8c8b53cd3d8f1 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 130e99db590073dd58da7e5c32dec8c2181527dd ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +25 @@ -index 3a6a33bda3..8a35040597 100644 +index 9830efb96f..081a3fa0d2 100644 @@ -34 +36 @@ -@@ -1972,12 +1971,10 @@ cpu_load_collector(__rte_unused void *arg) { +@@ -1975,12 +1974,10 @@ cpu_load_collector(__rte_unused void *arg) {