From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE3A0A0548 for ; Sun, 28 Nov 2021 15:59:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A3CAE4068A; Sun, 28 Nov 2021 15:59:03 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2050.outbound.protection.outlook.com [40.107.244.50]) by mails.dpdk.org (Postfix) with ESMTP id F3C8842732 for ; Sun, 28 Nov 2021 15:59:01 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A0GAM4DVkiLDURdVRUXcP3y2dzhPU10e4iQe9EyrA96ZRlkKAPmHSG/pgXPTo0FUz4R7NmEqenMg9KyZ57P86gAXiv0hbTT55ZymORsUYnC8KPrBoi5lykt3XU9kTFjiiib31FxVhdBZdd0D6/eaYLkmuqD3qO8SOnIWYXZYoRWv62jnHmTAUp3i6ScxJPoe8TsZdmU8Z+hiFKVcmWc24A9/LFyAIncPxbiHXByj0PV7Lf4TFN5E38VKs7EVcuXNCsa6t+eg9Nga/EMr9rIFK3PyIZwoXf+cUrIWIREhQ0Ha17OKErJHNScfzKc4/w7HMy6dppzZbzoolWNiboGfrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EvduZijpqYnx6IYsXm56vXiFguTdjA5otOqAVX6xMpE=; b=jqxjTlZ0CvqfT5+SR6ArfTv/cqGrJ6uj225vWIko5BIBd9PkWGkVD+wG+3GYuGMCPQCo/4ztHDdqJ11Nm8Jz+78/EnQRM3y0EmAJV3ykSJUfd+Xvwl1RrV01KlDLn9vbDiCllmYQlHayJC3UR1cR1IY0YWPUq7VTOdgUWp+KWUeNVfHbnFwhqYbctBxPdlrqpce5BfY97upMMK3m6fBBaD7VWXNdzAyOD8h8A8RhRNA4wi3XFiwcOHIjLLjG6pC+6yEZQRL4JYIkFrdIJ6xBQIDmAQxDCaDD1Nx7rhQRKCAvTkkt3KcQGqBloscrPpe4G8ru1MCPmrhntJp2yFATeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EvduZijpqYnx6IYsXm56vXiFguTdjA5otOqAVX6xMpE=; b=pXrTASWrp7cni1QH/in0s7ohJol9+klOEek2o/MozzcHvmYKBwNbPjlqEMTVk/UL+r3HZ/NEN4FkRHeELCV/73hsmHkJIVmECWGAEnnPqcqvaOX+mGPR11URxPfad0tkO1uOk1DHyLF6BN/JTvgRdL8seaVMUDcpRthfgMQ1cM2Zbughr9zCF5AJNGqZhGXqGd2mVOCnLPB58IYj/g5RsdVzjJKpx4eHTOCYF+7cReSDQuG+WG6j6V9MkjBnRtIRZyQZk9A8OnykKhJGLrp1gxucjh3cgCA4F6FAcLdldykWLKe4zonM4dBn8ZdSeKgsblQ8KuuzQPb+F5uuRUFJaw== Received: from BN9PR03CA0950.namprd03.prod.outlook.com (2603:10b6:408:108::25) by CH0PR12MB5370.namprd12.prod.outlook.com (2603:10b6:610:d5::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Sun, 28 Nov 2021 14:58:59 +0000 Received: from BN8NAM11FT008.eop-nam11.prod.protection.outlook.com (2603:10b6:408:108:cafe::f3) by BN9PR03CA0950.outlook.office365.com (2603:10b6:408:108::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23 via Frontend Transport; Sun, 28 Nov 2021 14:58:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT008.mail.protection.outlook.com (10.13.177.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4734.22 via Frontend Transport; Sun, 28 Nov 2021 14:58:58 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Sun, 28 Nov 2021 14:58:56 +0000 From: Xueming Li To: Gregory Etelson CC: Luca Boccassi , Anatoly Burakov , dpdk stable Subject: patch 'examples/multi_process: fix Rx packets distribution' has been queued to stable release 20.11.4 Date: Sun, 28 Nov 2021 22:53:41 +0800 Message-ID: <20211128145423.3974892-38-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211128145423.3974892-1-xuemingl@nvidia.com> References: <20211110063216.2744012-1-xuemingl@nvidia.com> <20211128145423.3974892-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 061932ca-0545-4104-8a45-08d9b27f9b75 X-MS-TrafficTypeDiagnostic: CH0PR12MB5370: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lRU7vTqSIPVNb9669uiAJyIkZAAzkuqe4Lsb1371ZR2nZVftdUmpRIgGBx/kujrdRIJidwdd+Jdm/YPA0ukFSYCEP49EibV2o3dbzE14mBiNfACjAwxILtj0PQ4cP32rwK2hZKLD2skAZZGPbsrfWElvotnc4S9/22dge2GB2Wj4ezS3+UBLNztjfoD7CXBVIlxrldfzxtgvZdto8RDvyC7BIix3ug24n9gWMQJ0A8bejAs7OY9ix+bSO5yk+ankt6Zn9f4F6j9GgAOik10k/VsrUx1ecR3sTpvqmTRkbWLDYYZ+C2JrLARvfFgsXTwVcQQRHxVGKXPGzpmZOzEd6Vn3jhmar5zv3TZ06jANOKBwPbtiBvM0KQGEYE+vMA+y37pZ1P/UyKQHLkja0zI8nVxLnDD3/yaQ+GAevnQ24rCRypyNdtn1OTxnb7HHJieXJcJDDYj/0qwTJmBGTR+4xBDdU34x27cMXJawl8zrY79MKZJ3HYCI+B26+ZllBEs/+I6DH4N1GJdIeWtkeY+uf+onHuYzuY63v2xvhgKVj/Tv9Md8Z3Fjic+rwRE2x+dj8ymqoOgKS5NSJhjLC1TAbc85qKtQcWHH4QEpzTKQAKJxg4eiMRPKoC5OygRl9CX2BmDfer5WQK7+/bXJqFMeFdK/iQhdW4TyH3fbwpBsVAeUX+JTb6X8XRj2Sg+m4HzP90H/8yJKHr7v3ebf9Pn/FB4HN0cKglMfstumgFi4wiO0iEeGe31pjZ2KTLny9tqC/Hk+0sJklDFMa33WnbeYW2/+Ah2Nz0KhRTN1vPL6Zfp7k6F6X6nVG1VA9cYl41EOJKaYNv9mcEwGkhWPxXRvAg== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(36756003)(508600001)(7636003)(426003)(8936002)(36860700001)(54906003)(86362001)(2906002)(6666004)(8676002)(5660300002)(6862004)(2616005)(356005)(966005)(6286002)(6636002)(37006003)(7696005)(4326008)(316002)(47076005)(186003)(70586007)(53546011)(16526019)(26005)(70206006)(82310400004)(4001150100001)(55016003)(1076003)(83380400001)(336012); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2021 14:58:58.5529 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 061932ca-0545-4104-8a45-08d9b27f9b75 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT008.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5370 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/30/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/bb4c5550b15b4b26cffa97f7122d93569d87316c Thanks. Xueming Li --- >From bb4c5550b15b4b26cffa97f7122d93569d87316c Mon Sep 17 00:00:00 2001 From: Gregory Etelson Date: Wed, 10 Nov 2021 18:57:59 +0200 Subject: [PATCH] examples/multi_process: fix Rx packets distribution Cc: Xueming Li [ upstream commit 69f9d8aa357d2299e057b7e335f340e20a0c5e7e ] MP servers distributes Rx packets between clients according to round-robin scheme. Current implementation always started packets distribution from the first client. That procedure resulted in uniform distribution in cases when Rx packets number was around clients number multiplication. However, if RX burst repeatedly returned single packet, round-robin scheme would not work because all packets were assigned to the first client only. The patch does not restart packets distribution from the first client. Packets distribution always continues to the next client. Fixes: af75078fece3 ("first public release") Signed-off-by: Gregory Etelson Acked-by: Anatoly Burakov --- examples/multi_process/client_server_mp/mp_server/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/multi_process/client_server_mp/mp_server/main.c b/examples/multi_process/client_server_mp/mp_server/main.c index 9bcee460fd..89a996eb58 100644 --- a/examples/multi_process/client_server_mp/mp_server/main.c +++ b/examples/multi_process/client_server_mp/mp_server/main.c @@ -233,7 +233,7 @@ process_packets(uint32_t port_num __rte_unused, struct rte_mbuf *pkts[], uint16_t rx_count) { uint16_t i; - uint8_t client = 0; + static uint8_t client; for (i = 0; i < rx_count; i++) { enqueue_rx_packet(client, pkts[i]); -- 2.34.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-28 22:41:05.281707508 +0800 +++ 0037-examples-multi_process-fix-Rx-packets-distribution.patch 2021-11-28 22:41:03.286874917 +0800 @@ -1 +1 @@ -From 69f9d8aa357d2299e057b7e335f340e20a0c5e7e Mon Sep 17 00:00:00 2001 +From bb4c5550b15b4b26cffa97f7122d93569d87316c Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 69f9d8aa357d2299e057b7e335f340e20a0c5e7e ] @@ -21 +23,0 @@ -Cc: stable@dpdk.org @@ -30 +32 @@ -index b4761ebc7b..f54bb8b75a 100644 +index 9bcee460fd..89a996eb58 100644 @@ -33 +35 @@ -@@ -234,7 +234,7 @@ process_packets(uint32_t port_num __rte_unused, +@@ -233,7 +233,7 @@ process_packets(uint32_t port_num __rte_unused,