From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0042DA0548 for ; Sun, 28 Nov 2021 15:59:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED0F34111B; Sun, 28 Nov 2021 15:59:10 +0100 (CET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08on2042.outbound.protection.outlook.com [40.107.102.42]) by mails.dpdk.org (Postfix) with ESMTP id 6536C4068A for ; Sun, 28 Nov 2021 15:59:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T8A27MKz7cu/LRjG6e3RSCg4At/2D0NKr1k02OyM0kxneBbJNe9hMEpZlwX6jUbDp0/+xCbH3XnkMtHc0n32lrDkWcFFWfyMDCBYyovTZcaOcNHp2aX2uag5YOtHETJgLHfkrTbGiwIFKo3rh2rlAZREwYOlzynjzUMBlCgYelOLQ+/2HXE6iZtC/gBHrxaTiOr81dUD8Eq5hMS/FQP/lOzdh76KTk3w08/dB592LmbZgvyXNPOwEl9PfjcCJjb/3srbsKVIxqsWOlT24F5/OUezYL/ZgNECRWFnRqDxrVGYktyc5GbLvAv5jClb5MtlaaZWJzVjTxup3AQ8X1n4cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Zxq+a+dLDkFr8ikQiCA4wD99OdK39E/4UnOhuSiuiM=; b=Tf0kN3Jqd98lw6kQPqvN2b03NDUMJbCnQFFKlJhAivI7WZGWa609h50qXGnfwHeTI0nO6cBmv5+QBEU37ceBvaL0KuahaPngfEVSMZGBZ45oa4ipdWNVSAAkd1HIqDe6yw2MC16QLvgOini86As1k9nf7BfXYB1dpCxVflxk7uUeO5IuVncPlYXABt7oncQJORMZKR1af1Rvw6llZNCs+JWML3rfc9x3qyzF1Hk7eSMp36OzREBNE9S++o/F7Y+MBYtOsC+7SrrAnOcrTzgB5iQF/4GVW1kjpG4e6+1WaGGMOBMq3/AoQ7A2SjlSj0i8TF2TvIaPdw8Exo5ev93jiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Zxq+a+dLDkFr8ikQiCA4wD99OdK39E/4UnOhuSiuiM=; b=VdK7bQVAvFmxA5KzAKODEjq8VmoovDyrCp+VazNFaPUyeuJ+QxGPhn6z8sxSXkTpdbtrsQ7zerSRPyOagYX58IQhUjrEcFQ1TF4SfPLGk27VP8QsatnoihoGRMRaA+JL2Ir9LlMD6oiizvpffBlqstiaT+CeJo3vZvnA2TPwaHNLcV+/ICpYUy2YwRTFsLhwlXo/6ah1IxgypeSL72o2SYgh8kQfw6WUEVVziU8uq8rwmcAY4lWvChjRx+L9O5QOeXR/CnF8iMKqja6metvqIt4ZEzDGZDgQ/FsZmI6awNz6mJrsEBIRa3jNU9S7p8lucAEwtcXRRK1fKxOMxeRqyw== Received: from BN9PR03CA0730.namprd03.prod.outlook.com (2603:10b6:408:110::15) by BL1PR12MB5127.namprd12.prod.outlook.com (2603:10b6:208:31b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Sun, 28 Nov 2021 14:59:07 +0000 Received: from BN8NAM11FT004.eop-nam11.prod.protection.outlook.com (2603:10b6:408:110:cafe::2c) by BN9PR03CA0730.outlook.office365.com (2603:10b6:408:110::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.20 via Frontend Transport; Sun, 28 Nov 2021 14:59:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT004.mail.protection.outlook.com (10.13.176.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4734.22 via Frontend Transport; Sun, 28 Nov 2021 14:59:07 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Sun, 28 Nov 2021 14:59:01 +0000 From: Xueming Li To: Dmitry Kozlyuk CC: Luca Boccassi , Bruce Richardson , dpdk stable Subject: patch 'config/x86: skip GNU binutils bug check for LLVM' has been queued to stable release 20.11.4 Date: Sun, 28 Nov 2021 22:53:43 +0800 Message-ID: <20211128145423.3974892-40-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211128145423.3974892-1-xuemingl@nvidia.com> References: <20211110063216.2744012-1-xuemingl@nvidia.com> <20211128145423.3974892-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5d4e12d0-0717-4663-9248-08d9b27fa0bf X-MS-TrafficTypeDiagnostic: BL1PR12MB5127: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CU423hDoFsOEiSykEMoEDSdlElkf0yHFr3A+/0U8t8/W9jSF0ade6gpGtD0CZQ7sPy3qSnXoKWrZpGQAy5UoIL6DLQOUe7vB/duF5tlIK5CpPx96LLydUz5s1xzdWUvoTQ/m5JCI8fu3oRJBe3WkAczSImPtOYsbx8/LYdUNBLIxRty1J73dYpaIOSl0VmSOBWMHwYbVRdFWuTUzUCba8lJCFV9jkFWbpTiLOMxKY5yU4sjhuPeUUj3pV6ugP8pDgpkBF3iQZHA0pWsJNR60tRhAS6eCxptWKH3ZlKQEMORiodcUUPH/lUjmh8EFFQ/2z+5hCn9GNVQ60nWki15uYTv2tL6dA4TB/OxyptrIkWIeON7jD0WMQfs6LBfamOJEN8OaCrQTWloC0zhvDYFWg2YKP6KxqCjyZmveA/LxlL/l9aiWl72liWrcAAP6U4ooNuHmIbdy41XQc87lHSDX6xVbrDbiIj5TsjV3DwjkajZSWz+q4N+D6G8wzi8Z1ucTEZ9II1oe2uusiaiA7Q1d6tk6BhzFQIqibA45LCvUJmUSRO99ZvV1OpUv7rW0IDXdodt+nlJZIEbbfv/1LFq2tMjEiZiJLRtKRlfkqVIwNoDO39/SPJiTXG2TiGixj8BHAtWTjpCvECNFrf6C87WtaOPcjXk3qiVtj+hISfesOe3Cz9hYFSBq7TgWCJSCkEOwPKkcO1VKHaRYrqEugTDrV+gDcNrFD6G9w9WVZv9xoQTSDzkyoc7g2KUn6DtLLKd+/zzgUu4AaGxby9m45L6ZWRee+53Jkhaa2hfR15oO0DsC210tVQ4UFugjm6UZPUiIlN6rcgRWA8G+go9enJ7xWw== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(7636003)(8936002)(5660300002)(2906002)(54906003)(83380400001)(7696005)(47076005)(4326008)(356005)(316002)(53546011)(6666004)(16526019)(186003)(1076003)(426003)(86362001)(36860700001)(336012)(4001150100001)(966005)(70586007)(70206006)(8676002)(6286002)(36756003)(82310400004)(26005)(55016003)(508600001)(2616005)(6916009); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2021 14:59:07.5466 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5d4e12d0-0717-4663-9248-08d9b27fa0bf X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT004.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5127 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/30/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/27cfa20c2a997f4b49d5fd2a2531d8a0fc1cb72d Thanks. Xueming Li --- >From 27cfa20c2a997f4b49d5fd2a2531d8a0fc1cb72d Mon Sep 17 00:00:00 2001 From: Dmitry Kozlyuk Date: Sat, 13 Nov 2021 00:48:24 +0300 Subject: [PATCH] config/x86: skip GNU binutils bug check for LLVM Cc: Xueming Li [ upstream commit 04f9fac660d018d0b163dcafed2805909f576ee9 ] AVX512 was disabled when GNU binutils were missing or had a known bug, even if LLVM binutils were used for the build, because binutils-avx512-check.sh was invoked regardless and failed. In particular, this was the case for FreeBSD with clang (default). Run the check only when GNU binutils are used. Fixes: 68b1f1cda5b4 ("build: check AVX512 rather than binutils version") Signed-off-by: Dmitry Kozlyuk Acked-by: Bruce Richardson --- config/x86/meson.build | 7 ++++--- lib/librte_acl/meson.build | 2 +- lib/librte_fib/meson.build | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/config/x86/meson.build b/config/x86/meson.build index 31bfa63b1c..0007b6b49f 100644 --- a/config/x86/meson.build +++ b/config/x86/meson.build @@ -2,9 +2,10 @@ # Copyright(c) 2017-2020 Intel Corporation # get binutils version for the workaround of Bug 97 -if not is_windows - binutils_ok = run_command(binutils_avx512_check) - if binutils_ok.returncode() != 0 and cc.has_argument('-mno-avx512f') +binutils_ok = true +if not is_windows and (is_linux or cc.get_id() == 'gcc') + binutils_ok = run_command(binutils_avx512_check).returncode() == 0 + if not binutils_ok and cc.has_argument('-mno-avx512f') machine_args += '-mno-avx512f' warning('Binutils error with AVX512 assembly, disabling AVX512 support') endif diff --git a/lib/librte_acl/meson.build b/lib/librte_acl/meson.build index ee4e229e59..c261101de7 100644 --- a/lib/librte_acl/meson.build +++ b/lib/librte_acl/meson.build @@ -30,7 +30,7 @@ if dpdk_conf.has('RTE_ARCH_X86') # compile AVX512 version if: # we are building 64-bit binary AND binutils can generate proper code - if dpdk_conf.has('RTE_ARCH_X86_64') and binutils_ok.returncode() == 0 + if dpdk_conf.has('RTE_ARCH_X86_64') and binutils_ok # compile AVX512 version if either: # a. we have AVX512 supported in minimum instruction set diff --git a/lib/librte_fib/meson.build b/lib/librte_fib/meson.build index 18eadcc56c..2438a2791c 100644 --- a/lib/librte_fib/meson.build +++ b/lib/librte_fib/meson.build @@ -8,7 +8,7 @@ deps += ['rib'] # compile AVX512 version if: # we are building 64-bit binary AND binutils can generate proper code -if dpdk_conf.has('RTE_ARCH_X86_64') and binutils_ok.returncode() == 0 +if dpdk_conf.has('RTE_ARCH_X86_64') and binutils_ok # compile AVX512 version if either: # a. we have AVX512F supported in minimum instruction set baseline # b. it's not minimum instruction set, but supported by compiler -- 2.34.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-28 22:41:05.402977689 +0800 +++ 0039-config-x86-skip-GNU-binutils-bug-check-for-LLVM.patch 2021-11-28 22:41:03.323540920 +0800 @@ -1 +1 @@ -From 04f9fac660d018d0b163dcafed2805909f576ee9 Mon Sep 17 00:00:00 2001 +From 27cfa20c2a997f4b49d5fd2a2531d8a0fc1cb72d Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 04f9fac660d018d0b163dcafed2805909f576ee9 ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org @@ -18,3 +20,3 @@ - config/x86/meson.build | 7 ++++--- - lib/acl/meson.build | 2 +- - lib/fib/meson.build | 2 +- + config/x86/meson.build | 7 ++++--- + lib/librte_acl/meson.build | 2 +- + lib/librte_fib/meson.build | 2 +- @@ -24 +26 @@ -index 29f3dea181..603359e55a 100644 +index 31bfa63b1c..0007b6b49f 100644 @@ -32,2 +34,2 @@ -- binutils_ok = run_command(binutils_avx512_check) -- if binutils_ok.returncode() != 0 and cc.has_argument('-mno-avx512f') +- binutils_ok = run_command(binutils_avx512_check) +- if binutils_ok.returncode() != 0 and cc.has_argument('-mno-avx512f') @@ -36,12 +38,12 @@ -+ binutils_ok = run_command(binutils_avx512_check).returncode() == 0 -+ if not binutils_ok and cc.has_argument('-mno-avx512f') - machine_args += '-mno-avx512f' - warning('Binutils error with AVX512 assembly, disabling AVX512 support') - endif -diff --git a/lib/acl/meson.build b/lib/acl/meson.build -index f3dc513846..fbe17f9454 100644 ---- a/lib/acl/meson.build -+++ b/lib/acl/meson.build -@@ -36,7 +36,7 @@ if dpdk_conf.has('RTE_ARCH_X86') - # compile AVX512 version if: - # we are building 64-bit binary AND binutils can generate proper code ++ binutils_ok = run_command(binutils_avx512_check).returncode() == 0 ++ if not binutils_ok and cc.has_argument('-mno-avx512f') + machine_args += '-mno-avx512f' + warning('Binutils error with AVX512 assembly, disabling AVX512 support') + endif +diff --git a/lib/librte_acl/meson.build b/lib/librte_acl/meson.build +index ee4e229e59..c261101de7 100644 +--- a/lib/librte_acl/meson.build ++++ b/lib/librte_acl/meson.build +@@ -30,7 +30,7 @@ if dpdk_conf.has('RTE_ARCH_X86') + # compile AVX512 version if: + # we are building 64-bit binary AND binutils can generate proper code @@ -49,2 +51,2 @@ -- if dpdk_conf.has('RTE_ARCH_X86_64') and binutils_ok.returncode() == 0 -+ if dpdk_conf.has('RTE_ARCH_X86_64') and binutils_ok +- if dpdk_conf.has('RTE_ARCH_X86_64') and binutils_ok.returncode() == 0 ++ if dpdk_conf.has('RTE_ARCH_X86_64') and binutils_ok @@ -52,7 +54,7 @@ - # compile AVX512 version if either: - # a. we have AVX512 supported in minimum instruction set -diff --git a/lib/fib/meson.build b/lib/fib/meson.build -index 593c8c47c8..9b848d0841 100644 ---- a/lib/fib/meson.build -+++ b/lib/fib/meson.build -@@ -14,7 +14,7 @@ deps += ['rib'] + # compile AVX512 version if either: + # a. we have AVX512 supported in minimum instruction set +diff --git a/lib/librte_fib/meson.build b/lib/librte_fib/meson.build +index 18eadcc56c..2438a2791c 100644 +--- a/lib/librte_fib/meson.build ++++ b/lib/librte_fib/meson.build +@@ -8,7 +8,7 @@ deps += ['rib'] @@ -64,3 +66,3 @@ - # compile AVX512 version if either: - # a. we have AVX512F supported in minimum instruction set baseline - # b. it's not minimum instruction set, but supported by compiler + # compile AVX512 version if either: + # a. we have AVX512F supported in minimum instruction set baseline + # b. it's not minimum instruction set, but supported by compiler