From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 424ECA0548 for ; Sun, 28 Nov 2021 15:59:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 35A2C4068A; Sun, 28 Nov 2021 15:59:36 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2081.outbound.protection.outlook.com [40.107.94.81]) by mails.dpdk.org (Postfix) with ESMTP id 6CF944068A for ; Sun, 28 Nov 2021 15:59:34 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mx3c/DkrMFKjSmA0YZcLV17lQXssE902SxcIXeWwMt52qiOZUZu3qJDAE7x++dsC/L++uOZxKCzn5tAXTEIL7NjP+siTceqVrX+C2EM8C6jwY35kmm8qBgV/YesLfBA/eTeeARGD1jv4VHcZxwamHUxbe0gM2M5Yjf2tabKBaIHUu0ELQzCCa+4iJT/x/D2CC7+F00DCRF2JnBIGpkdLQnGfMV9vFijGwLnUbaTjmMGtY+PmJnvq2Jz/cyiv12XgQw9V+Im0YDI0vjr1sRItrtmyu92IcUykwG2os4jGv/WMKXgkN1JjK4cvBsgMrZCTnYevqdM6HmgJnkZkax0A6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TMHAcL0TY/IQmDAllUUwU6f4pP7pjc4QfRgnLXVpYwU=; b=FEWbzv5z719ySdM1iK1DK/f8y1r/3Eqm2LIrLxcogPZbNAyoyZiABfp0Q0vqgyuhmSCAlZDG+0CjmoIdCwJ8kfqtNiKSBqbxb7JAr2qMyf0woYIq7O7rpCUlAdmvIp4pI+CWSLS2w3xU0RI6Jl6brBqu12/RKzGwTu3qi3NgBbF0ACQy7X5hEJWJBR/+uPEIBsjrfuJe0jGkWpbnNGvCoCTfBI/z9JBqHIm0m3Q2WimuGA/S97yUG4Gc8GePkfB3joOaAdmEGDUSJr3Kh4gnMxWJqAKEYRH5MRB0NmG3c64+BHJT/XPJhrWgVMVC+XkKLEEmjxHwPrrXl7Fq7gdBeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TMHAcL0TY/IQmDAllUUwU6f4pP7pjc4QfRgnLXVpYwU=; b=MzYk3c9MBC59wB03AE0//ZIhiqD2NnsaNsBkrC1d26aZBEkIJsDGR21mDoX3wP8NdLDAUXdbD6YAw3hlTP4CopXigd4ktVaAyUxwNTF0MjC/frObxdYnqVoFnkDcm+WkNPeV8q+Q33PheACiOmepMgyAAWEgF/KE4qm8fNdpiFjulym7cRvhYODhHykyUwUvaOtvT0RqVXf+gr0QLHR4DT3S4wV4iCZ7jraGlj7B22tXOmEqpdM0hKzHanjeeiGDbVyhukugvxdMO/0Or9X/DFT9twtTIZiVyzRF6UPmk3bBNV0ZBmyTn37rXMtOSMSgZO3q/wzAkMKW4zkKXJoCpA== Received: from BN9PR03CA0742.namprd03.prod.outlook.com (2603:10b6:408:110::27) by MN2PR12MB3087.namprd12.prod.outlook.com (2603:10b6:208:d2::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Sun, 28 Nov 2021 14:59:32 +0000 Received: from BN8NAM11FT004.eop-nam11.prod.protection.outlook.com (2603:10b6:408:110:cafe::29) by BN9PR03CA0742.outlook.office365.com (2603:10b6:408:110::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22 via Frontend Transport; Sun, 28 Nov 2021 14:59:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT004.mail.protection.outlook.com (10.13.176.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4734.22 via Frontend Transport; Sun, 28 Nov 2021 14:59:32 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Sun, 28 Nov 2021 14:59:27 +0000 From: Xueming Li To: Raslan Darawsheh CC: Luca Boccassi , Wisam Jaddo , "dpdk stable" Subject: patch 'app/flow-perf: fix parsing of invalid option' has been queued to stable release 20.11.4 Date: Sun, 28 Nov 2021 22:53:45 +0800 Message-ID: <20211128145423.3974892-42-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211128145423.3974892-1-xuemingl@nvidia.com> References: <20211110063216.2744012-1-xuemingl@nvidia.com> <20211128145423.3974892-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 30c0be61-792e-40b6-a9fc-08d9b27faf57 X-MS-TrafficTypeDiagnostic: MN2PR12MB3087: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qj2Rp2ryxWbOA8iZ2Bu+qERaDZZC9iitPrRnGCLKkU6pCZAQn3e4NJHW6BsRX83Rb8EQBTBOsca49EqCrrYtzKr2izJ8gsrMoLikT3eW6IwyecStWP7qj++SoWptJn5N7sBSBchCcY7B1AQpkrTMm65LO8O7wOb6y8Cwy3VPAZBu67oIIt60G9kGMYpA+uHGOL+BK/ckDJnLvkgRi2cSZoxbU2dtzxXjaQnbcJ5LIVyXroI0cVwIykeZ6N8rYR5xtpz6AcarWDRPFpSu6XSupzAtcu2+Xb/R4hnMV+uokGrD2L+v5Ct52jCVZpkxDSw1x4iqI6dmklkC+xVfeUJoN2XRGH+CUlDZuY+36GXq8R4/RVwqvT0yz4f9wBXCoCurd/EqthgN+1hFY3dy7GUifqoov6Eog5hCm03KLCx7jucPRCs3OcHTxr76RjWIpNNekeSCWoIgdKKyUvit9D67F4xESeu9L8/HtR5Cgv7xHl6Tfq97NEpGVNlEkkXbDs4npUgq7m6m+dIHb6nRb/zel1HlMx02Gt+PbzDh1ngQeDSv/3+ZQXRguPB8ywCjflpFIN09T0ARreuIfm9sGhFf8OG1z/bzG2xjm49L9QyGMI3K7uMTUCKJzOQBzphxZI0Zy1LP7eEEvDkOTkcLnbSqMDfMW7/m1W7H7relvEIhi7/66XbAGLHMdqDpAa8hDnpQ5SsavbIi3rTsyTV9PgxtfD5KwTM6vfos0J+/T9n293K0WI9ea4sOS82Lub/87yNKAoZPbOdJuuMQGGJGzB/q+L+YqG/EE2FDKB4Kt05+sskSUi2vVguNR9iEm7uCvmExdbPPMbIsOV1zAQjY/2tuMQ== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(8676002)(26005)(86362001)(186003)(16526019)(83380400001)(356005)(336012)(426003)(70206006)(53546011)(2616005)(7696005)(70586007)(47076005)(6286002)(8936002)(5660300002)(6636002)(316002)(508600001)(55016003)(2906002)(4001150100001)(36756003)(82310400004)(4326008)(37006003)(7636003)(1076003)(966005)(36860700001)(54906003)(6666004)(6862004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2021 14:59:32.0355 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 30c0be61-792e-40b6-a9fc-08d9b27faf57 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT004.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3087 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/30/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/7b247102a4157359d341bfa2b6df094fb5f607dc Thanks. Xueming Li --- >From 7b247102a4157359d341bfa2b6df094fb5f607dc Mon Sep 17 00:00:00 2001 From: Raslan Darawsheh Date: Tue, 16 Nov 2021 16:12:26 +0200 Subject: [PATCH] app/flow-perf: fix parsing of invalid option Cc: Xueming Li [ upstream commit 22ffcce31b9489705bca6eaf87f4714437cc16da ] Currently, if an invalid parameter is passed to the application it will cause a crash due to missing default in options. For example: ./dpdk-test-flow-perf -a 01:00.0 -- --invalid This adds missing default for options, and prints the invalid option. Fixes: 3344cf2e3001 ("app/flow-perf: add flow performance skeleton") Signed-off-by: Raslan Darawsheh Acked-by: Wisam Jaddo --- app/test-flow-perf/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c index f525bc913a..3b3ecdc75e 100644 --- a/app/test-flow-perf/main.c +++ b/app/test-flow-perf/main.c @@ -591,6 +591,7 @@ args_parse(int argc, char **argv) { "raw-decap", 1, 0, 0 }, { "vxlan-encap", 0, 0, 0 }, { "vxlan-decap", 0, 0, 0 }, + { 0, 0, 0, 0 }, }; RTE_ETH_FOREACH_DEV(i) @@ -751,7 +752,7 @@ args_parse(int argc, char **argv) default: usage(argv[0]); rte_exit(EXIT_FAILURE, "Invalid option: %s\n", - argv[optind]); + argv[optind - 1]); break; } } -- 2.34.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-28 22:41:05.485167594 +0800 +++ 0041-app-flow-perf-fix-parsing-of-invalid-option.patch 2021-11-28 22:41:03.323540920 +0800 @@ -1 +1 @@ -From 22ffcce31b9489705bca6eaf87f4714437cc16da Mon Sep 17 00:00:00 2001 +From 7b247102a4157359d341bfa2b6df094fb5f607dc Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 22ffcce31b9489705bca6eaf87f4714437cc16da ] @@ -16 +18,0 @@ -Cc: stable@dpdk.org @@ -25 +27 @@ -index 2b612aa32c..11f1ee0e1e 100644 +index f525bc913a..3b3ecdc75e 100644 @@ -28,4 +30,4 @@ -@@ -715,6 +715,7 @@ args_parse(int argc, char **argv) - { "policy-mtr", 1, 0, 0 }, - { "meter-profile", 1, 0, 0 }, - { "packet-mode", 0, 0, 0 }, +@@ -591,6 +591,7 @@ args_parse(int argc, char **argv) + { "raw-decap", 1, 0, 0 }, + { "vxlan-encap", 0, 0, 0 }, + { "vxlan-decap", 0, 0, 0 }, @@ -36 +38 @@ -@@ -951,7 +952,7 @@ args_parse(int argc, char **argv) +@@ -751,7 +752,7 @@ args_parse(int argc, char **argv)