From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C11BA0548 for ; Sun, 28 Nov 2021 16:01:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 540F340FDF; Sun, 28 Nov 2021 16:01:21 +0100 (CET) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08on2085.outbound.protection.outlook.com [40.107.100.85]) by mails.dpdk.org (Postfix) with ESMTP id B0FFA40FDF for ; Sun, 28 Nov 2021 16:01:19 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cFa+GAFf1HHl4GIzGV1aSXfKNO9YFys6wM/ZMn0O1LhR9jtOLMhOirpxwiAJIFMOXemQQ9PyxbFVj/LnWzQNIQesiTVM5tyQmCgUQaCO5ZWreB+5/x/FRAeSmxuwGc7pnUEqhyEkGTPXpxS+48K893Cbyp60gHoWyXvQpgFo7YXVQFkCfwTZ6e5yZIH3koxXVFh0xb8IcZxV5jJXf1M9hk8oaxpCz1sLQlLE44X0105yDFCRrzGfhggntX9qw73tFmabH6sZ5ZFSwSz9SPpPsCwfNMydqEVjGRYnRBjI0pZxiCnN0EqUuhV1gLvhHpHvFSS1ZfRMhAkdPw5G8wcLuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gj1Iekpu2pkO7Bbh1F2nbUEvAvUvGhjKxfnhMsHx0AY=; b=CDvdaRYykZxhJx9n9gJbONCj64AV34nHwZiy4DcQha4hv+RuxdgT+N6ppJySTRU8Ja/FFmmpNzGf5xs4u270v8qH/mx7GCHOGCRDsiCNePzTU74LWVZRKHCb7HVUM9aYFh91DI9MYDragGqWhukwFCukmbkWgsphllfMKzfEAJB5KUCCWGRgoADIssRCZXzbG04C+MjbJKxb2qKz1rabJx/2opVDDmjkkk6eVftZzU1GnFYnsLd2Wmco74xbZ+Bm4V3bcJLjOjvFK6UN/9QN+IqDe3SIyCZJceWJyr6qamHeIrd9y35aci8WLfW731s/C88qPbV/Fc3VFtlU9W4WBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gj1Iekpu2pkO7Bbh1F2nbUEvAvUvGhjKxfnhMsHx0AY=; b=e7QWCCnRiZUpPWpyVYE0Nic8ny4VjxD6swPJBKtOiAk47RL945meBackfGIyCwBYOq12Cn3IV6UkcVYXK4wP8LxLlXd+T3zi4S1dpBogQcgMigy9nmMyJj/eJPB3tE5GTneNTXuOZFeF2nF0U007+UE6Q/ZmfStQHdNKGtwYe2jDrrlG0UbeAOXxucY92dVtqk/Mih5i/lupcH20+iRjcew4s7RmPGDX8yMqYZ6Kvz7qhee/L8HwqxG4lR0eX/nwTb0EpmjGCUD5DRp2Z8QWWzzYxAlpX19BrdBttpuap7AgFDxnBfezka0HXJLEy4ld7v7XJKI0VWC18A5Gs1OyxA== Received: from BN6PR13CA0063.namprd13.prod.outlook.com (2603:10b6:404:11::25) by CH0PR12MB5235.namprd12.prod.outlook.com (2603:10b6:610:d2::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Sun, 28 Nov 2021 15:01:17 +0000 Received: from BN8NAM11FT064.eop-nam11.prod.protection.outlook.com (2603:10b6:404:11:cafe::b7) by BN6PR13CA0063.outlook.office365.com (2603:10b6:404:11::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.7 via Frontend Transport; Sun, 28 Nov 2021 15:01:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT064.mail.protection.outlook.com (10.13.176.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4734.22 via Frontend Transport; Sun, 28 Nov 2021 15:01:16 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Sun, 28 Nov 2021 15:00:33 +0000 From: Xueming Li To: Kumara Parameshwaran CC: Luca Boccassi , Ferruh Yigit , dpdk stable Subject: patch 'net/failsafe: fix secondary process probe' has been queued to stable release 20.11.4 Date: Sun, 28 Nov 2021 22:53:56 +0800 Message-ID: <20211128145423.3974892-53-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211128145423.3974892-1-xuemingl@nvidia.com> References: <20211110063216.2744012-1-xuemingl@nvidia.com> <20211128145423.3974892-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f1933770-ea8b-4c07-5ff7-08d9b27feddd X-MS-TrafficTypeDiagnostic: CH0PR12MB5235: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jIp4oBgNqLnvdQxcmhc1zVgfWAMZoQhNgzxvkGic6/aVC6x0/9Lhr1IAwJ62crk0Qkwr7wuPMWZ610zAr17BMZ/YvwZU3fbgdWsxoCJQRxT09OySz5l/bZt0shC9XqNGg1LFYUT7b7Fs6fmCWGr+PXbeklbIH9r3qu82O7swaYN+wPqEYytgnlLBC4GrV6hdsVrGJQOR4IF80WqR2r8Aa5VXPRoX5zmUK74qj/vV5kOFI1sogmQX9JQwi3/i6u0CoUXlH8m9kYFBK+nhbDdMJh/bNcVGB529uXChxCRhAhIufw+/8FL5Yox/WEmzo6q4LHTUG0PbjG/RqEg3f/FkQE9bEq0UGhkq1QsnnnqfEm3CDTScwcFj7lwf628aLT/E1BmiR/DXnlBIfKw+3vhwHwVDLt48ktykZddSi/SwD3iJQj80Fgxgv8Q7tYweOARrlTvB4WfYDEDO/8Npv0JsACnFVrzVGnZYwN8SDGyEzQCg9TFAw0nqbLBgKzFjupHMAqN2gvDCz5ipC21l5H+CGifUw4KDSQNpwmWG+AjJJB4A8KfnRkKXk95TC5qFdMJTjrdPUigPzmdBL3FbsKZo8sUCcEFya1QO/qu9FjmB4GJZYbLl1FdhtNZXQs3olp9ns/AubZNvHVsb+3W4hnlSjVTwYJxnmOotG/D4iH6DkC0F/xkulRrIASchAW06fHO4QcMGJUDkS5HaX7yr11Qcvq99YD4AaJBR1JfAOFkV881kc/Cibx7CR/MDoHvjpLlkgo0fpAEIZ3QOAAi+VjiRvEtLRuMKxKOPN/R7Rn0/EXF0JmwgxmFoz3y/r1KO0IObXCxctOf9UUbaLRv0VvbrEw== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(47076005)(508600001)(6286002)(966005)(26005)(16526019)(8936002)(55016003)(54906003)(6916009)(36756003)(82310400004)(86362001)(2906002)(7696005)(83380400001)(1076003)(8676002)(4001150100001)(5660300002)(356005)(336012)(53546011)(4326008)(70586007)(70206006)(2616005)(426003)(6666004)(36860700001)(186003)(7636003)(316002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2021 15:01:16.8696 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f1933770-ea8b-4c07-5ff7-08d9b27feddd X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT064.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5235 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/30/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/db9d14af1c2572ace1ec790052533fcc6b100f14 Thanks. Xueming Li --- >From db9d14af1c2572ace1ec790052533fcc6b100f14 Mon Sep 17 00:00:00 2001 From: Kumara Parameshwaran Date: Thu, 11 Nov 2021 18:14:58 +0530 Subject: [PATCH] net/failsafe: fix secondary process probe Cc: Xueming Li [ upstream commit 47f5dee19e5f9a2cf1883a7119675d7a25470aca ] Remove the vdev args check for secondary process which prevents the secondary from attaching to the device created by the primary process via the hotplug framework. This check was removed for other vdevs but was missed for failsafe. Fixes: 4852aa8f6e21 ("drivers/net: enable hotplug on secondary process") Signed-off-by: Kumara Parameshwaran Reviewed-by: Ferruh Yigit --- drivers/net/failsafe/failsafe.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c index ba81c82174..0b9b537984 100644 --- a/drivers/net/failsafe/failsafe.c +++ b/drivers/net/failsafe/failsafe.c @@ -329,8 +329,7 @@ rte_pmd_failsafe_probe(struct rte_vdev_device *vdev) INFO("Initializing " FAILSAFE_DRIVER_NAME " for %s", name); - if (rte_eal_process_type() == RTE_PROC_SECONDARY && - strlen(rte_vdev_device_args(vdev)) == 0) { + if (rte_eal_process_type() == RTE_PROC_SECONDARY) { eth_dev = rte_eth_dev_attach_secondary(name); if (!eth_dev) { ERROR("Failed to probe %s", name); -- 2.34.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-28 22:41:05.993428912 +0800 +++ 0052-net-failsafe-fix-secondary-process-probe.patch 2021-11-28 22:41:03.373540015 +0800 @@ -1 +1 @@ -From 47f5dee19e5f9a2cf1883a7119675d7a25470aca Mon Sep 17 00:00:00 2001 +From db9d14af1c2572ace1ec790052533fcc6b100f14 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 47f5dee19e5f9a2cf1883a7119675d7a25470aca ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -21 +23 @@ -index ad6b43538e..3c754a5f66 100644 +index ba81c82174..0b9b537984 100644 @@ -24 +26 @@ -@@ -340,8 +340,7 @@ rte_pmd_failsafe_probe(struct rte_vdev_device *vdev) +@@ -329,8 +329,7 @@ rte_pmd_failsafe_probe(struct rte_vdev_device *vdev)