From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 737A6A0C41 for ; Tue, 30 Nov 2021 17:41:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6AB7441177; Tue, 30 Nov 2021 17:41:42 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id 0316B410F7 for ; Tue, 30 Nov 2021 17:41:42 +0100 (CET) Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id D043F40037 for ; Tue, 30 Nov 2021 16:41:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638290501; bh=6b9DTSpiNghRG/mE+sFMB/pqm05AMzV3tJbPCXjhzK4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=j2L/JhnPvONe4Ih0pVTfc6L2C3I1yqtgkk/9v7RbL2idK+UYU9aqWFXj+ZFWvnTkl HlRa83UbZezS61vf9Tvjlu4dwdeZrsTuYhgX8KkGXAmJAyMY+9bRAjniyYZLrsJAcc GsY60RsLx0rndj84qqtqq4De8RxJ5iLVO2tYpA+nfGc574/d16rflbM2FyMUDGe52d rCfy+TCMT8uRP5//gY7qZqCOUaXxqDYRzMrMXAOE0nfeUMHzG4QNdIksUKJp04fgIs WQP5plOKXlWgTwiCArYNm4rT34vPEv85C2/3+j7U76hvH9ZDimhWn5MWrgE4MghSwv iBx3ZouRYCZBg== Received: by mail-ed1-f71.google.com with SMTP id v22-20020a50a456000000b003e7cbfe3dfeso17451148edb.11 for ; Tue, 30 Nov 2021 08:41:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6b9DTSpiNghRG/mE+sFMB/pqm05AMzV3tJbPCXjhzK4=; b=jeWR57ELnnld6gu/8ioOKozMMX6eCa8UoWccIb75i4oA0945MBwU3gHimIt6KiBGNw DWIUBceWmH3e1WSL6GP8Gx5TXKf/aTdR5a4qjgY33u6blynYn2rw8q+9T5e5rotQQoEg lyT5Ph2NmLblBaWHNMqNklV142opio/cewgXSWv5k9MPiHpV165f3a+cOuy/K0y1oM/q gABAcjkN9aTyNBLJiHITXulY0u2a3d/CRCDGTa6TGeV2v1YHBAlIkf6LJvwrQFJQCYys JrksRXqCMQEAgtDnrg7CWIhoo2/+/zwyaIj4JrW74UWlXEJ8I862qVGMr08Elu4CdB2B goTQ== X-Gm-Message-State: AOAM533iuicX4t8mH3HI8CfLTbSdXHyGV8ZFAqk7jVnUVYqYUo+f6TR3 IlqC3LBiqcbgmL93AvNFM5cB54cN+Y2K46XbkS2BF/ZOz/KSaHYnYao9e7JuBVAk/M9DP89NCvH XgScCM5HNtY3z8+7kV5KNCpj4 X-Received: by 2002:a17:906:314e:: with SMTP id e14mr202985eje.165.1638290501248; Tue, 30 Nov 2021 08:41:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJygiEpuF5a3yae1MkAkg1KjkMDOaD7DsazYDjvzS4yp+7sgYLI+mosHhjFKX1OdvakkejDEuA== X-Received: by 2002:a17:906:314e:: with SMTP id e14mr202973eje.165.1638290501113; Tue, 30 Nov 2021 08:41:41 -0800 (PST) Received: from localhost.localdomain ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id mp9sm9690411ejc.106.2021.11.30.08.41.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 08:41:40 -0800 (PST) From: christian.ehrhardt@canonical.com To: Xueming Li Cc: dpdk stable Subject: patch 'eal: fix device iterator when no bus is selected' has been queued to stable release 19.11.11 Date: Tue, 30 Nov 2021 17:35:11 +0100 Message-Id: <20211130163605.2460997-107-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> References: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before December 10th 2021. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/2ce7e45bf97132b85b9f0b558ce09ff332c8aa7b Thanks. Christian Ehrhardt --- >From 2ce7e45bf97132b85b9f0b558ce09ff332c8aa7b Mon Sep 17 00:00:00 2001 From: Xueming Li Date: Wed, 27 Oct 2021 16:22:21 +0800 Subject: [PATCH] eal: fix device iterator when no bus is selected [ upstream commit fc382022c6adcde57eb30e58186198275ad493d7 ] Devargs used in device iterator initialization wasn't set to zero, random data like bus string lead to invalid address access. This patch initializes devargs. Bugzilla ID: 862 Fixes: c99a2d4c6b7f ("eal: implement device iteration initialization") Signed-off-by: Xueming Li --- lib/librte_eal/common/eal_common_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c index 363a2ca95e..9d56a0e292 100644 --- a/lib/librte_eal/common/eal_common_dev.c +++ b/lib/librte_eal/common/eal_common_dev.c @@ -567,7 +567,7 @@ int rte_dev_iterator_init(struct rte_dev_iterator *it, const char *dev_str) { - struct rte_devargs devargs; + struct rte_devargs devargs = { .bus = NULL }; struct rte_class *cls = NULL; struct rte_bus *bus = NULL; -- 2.34.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-30 16:50:12.018147916 +0100 +++ 0107-eal-fix-device-iterator-when-no-bus-is-selected.patch 2021-11-30 16:50:05.910874410 +0100 @@ -1 +1 @@ -From fc382022c6adcde57eb30e58186198275ad493d7 Mon Sep 17 00:00:00 2001 +From 2ce7e45bf97132b85b9f0b558ce09ff332c8aa7b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit fc382022c6adcde57eb30e58186198275ad493d7 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -17 +18 @@ - lib/eal/common/eal_common_dev.c | 2 +- + lib/librte_eal/common/eal_common_dev.c | 2 +- @@ -20,5 +21,5 @@ -diff --git a/lib/eal/common/eal_common_dev.c b/lib/eal/common/eal_common_dev.c -index 148a23830a..e1e9976d8d 100644 ---- a/lib/eal/common/eal_common_dev.c -+++ b/lib/eal/common/eal_common_dev.c -@@ -573,7 +573,7 @@ int +diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c +index 363a2ca95e..9d56a0e292 100644 +--- a/lib/librte_eal/common/eal_common_dev.c ++++ b/lib/librte_eal/common/eal_common_dev.c +@@ -567,7 +567,7 @@ int