From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93759A0C41 for ; Tue, 30 Nov 2021 17:42:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E916410F7; Tue, 30 Nov 2021 17:42:13 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id 1C37D410F7 for ; Tue, 30 Nov 2021 17:42:12 +0100 (CET) Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id D81E73F1B1 for ; Tue, 30 Nov 2021 16:42:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638290531; bh=STajiLwohft1uWUDFE2AICNRHz91Fu3icDgdaL/IuwU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nFkYEfBQUfnT1vjq9o9F+Kgn71tB+zBKZOYQyspOU2Ky3Ce9KbBXJz+QCDbsaEqE0 8/ZSfMTUBa2czyipMd8zRCqQUVSut672yOzi9SKg0Wm5A9Vw2m6Ze9e66+mgFYnGew hKSM6mmb+lWDdhonyQAk3WJh2Ft/6Nft8E1uNOGc3fJY9oEfMks2197P/Q+3u8h/li WnSGqBAsjblSg1P03QNt+Rr3ZizuBswfPf7pm9fDQJgwipdpzgx85BbONm2TxqpdoD CYIvdypgqvyHlk1Ie/e+zyasaV/p3sBkOf3gPYizIzvmUGAZUAOyc7rl2l3s1GlfYX p2wF5Mf7f51XQ== Received: by mail-ed1-f71.google.com with SMTP id v22-20020a50a456000000b003e7cbfe3dfeso17452261edb.11 for ; Tue, 30 Nov 2021 08:42:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=STajiLwohft1uWUDFE2AICNRHz91Fu3icDgdaL/IuwU=; b=xCecR9TB9KOfjLi3mzyyNT/Neb6Au+Bq52JD90mEuUs4nC4izmCHmjFWcyVUrs3vD9 DHkCTPdtDruc5SGorUP/3jTsm+n7FrMYUKz8RhGgy5XGDZDzlNIy39PEj09TtscBnxey J06vF2pqwKZ25xynwXmP0LHg62aMV/8TnrPGWHN+dN6xHQVoIrzitPisgW9nFSDFsRye Lj6n/DXdSLZ65OmfDtg78y5ZQt0cb5y0CzhnjbJ2IiUNhAgzerRk72oafqlpNnzMtPnq jO2/JS3JQhsTpqeN+jpE1+idZOApsEzsT/k941tYgYctBYP4h2psvfBELkURUpICZ8MS Bhyw== X-Gm-Message-State: AOAM530O0/WEsMAPB06E8POaDVjm69X+Np5eQCe77HoxXoivMm7omRRF 9ElzUVPRh2af5IHTBygk3ANp1vXPw5v2GFHOUGcS2I07uoOcHCO/7RcHKYDhZaH8e2YHD/ZLiuI fPtWSeEa+9UTxY0jSaM0KT8nc X-Received: by 2002:a17:907:7896:: with SMTP id ku22mr257231ejc.410.1638290531342; Tue, 30 Nov 2021 08:42:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJzjmKo4jMhLo7A7R424MpXKJ7YdH3PHGVQT3rN6eG8AAnjoEqd4wtpB11N3S4KvI9n0WmPqLg== X-Received: by 2002:a17:907:7896:: with SMTP id ku22mr257204ejc.410.1638290531185; Tue, 30 Nov 2021 08:42:11 -0800 (PST) Received: from localhost.localdomain ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id q17sm11839723edd.10.2021.11.30.08.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 08:42:10 -0800 (PST) From: christian.ehrhardt@canonical.com To: Hyong Youb Kim Cc: John Daley , dpdk stable Subject: patch 'net/enic: avoid error message when no advanced filtering' has been queued to stable release 19.11.11 Date: Tue, 30 Nov 2021 17:35:20 +0100 Message-Id: <20211130163605.2460997-116-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> References: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before December 10th 2021. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/0dfb8b4a26a4b12da79fae719ad745673c43ae5f Thanks. Christian Ehrhardt --- >From 0dfb8b4a26a4b12da79fae719ad745673c43ae5f Mon Sep 17 00:00:00 2001 From: Hyong Youb Kim Date: Mon, 25 Oct 2021 17:04:18 -0700 Subject: [PATCH] net/enic: avoid error message when no advanced filtering [ upstream commit af397b3c93f82b0803c0890874d7ee3b5127522d ] Probing the availability of Flow Manager API may print the following error log. PMD: rte_enic_pmd: Devcmd 88 failed with error code -1 The error indicates a flow manager operation failed and happens when advanced filtering is disabled on vNIC. It is harmless but confusing to the user. Since advanced filtering is a prerequisite, check first if it is available and avoid the error message altogether. Fixes: ea7768b5bba8 ("net/enic: add flow implementation based on Flow Manager API") Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/base/vnic_dev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/enic/base/vnic_dev.c b/drivers/net/enic/base/vnic_dev.c index 5535aa8774..4ce44362a9 100644 --- a/drivers/net/enic/base/vnic_dev.c +++ b/drivers/net/enic/base/vnic_dev.c @@ -520,6 +520,9 @@ static int vnic_dev_flowman_enable(struct vnic_dev *vdev, u32 *mode, u64 ops; static u32 instance; + /* Advanced filtering is a prerequisite */ + if (!vnic_dev_capable_adv_filters(vdev)) + return 0; /* flowman devcmd available? */ if (!vnic_dev_capable(vdev, CMD_FLOW_MANAGER_OP)) return 0; -- 2.34.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-30 16:50:12.714328542 +0100 +++ 0116-net-enic-avoid-error-message-when-no-advanced-filter.patch 2021-11-30 16:50:05.942874646 +0100 @@ -1 +1 @@ -From af397b3c93f82b0803c0890874d7ee3b5127522d Mon Sep 17 00:00:00 2001 +From 0dfb8b4a26a4b12da79fae719ad745673c43ae5f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit af397b3c93f82b0803c0890874d7ee3b5127522d ] + @@ -17 +18,0 @@ -Cc: stable@dpdk.org @@ -26 +27 @@ -index 9c42595ced..00d7782e6e 100644 +index 5535aa8774..4ce44362a9 100644 @@ -29,3 +30,3 @@ -@@ -594,6 +594,9 @@ static int vnic_dev_flowman_enable(struct vnic_dev *vdev, uint32_t *mode, - uint64_t ops; - static uint32_t instance; +@@ -520,6 +520,9 @@ static int vnic_dev_flowman_enable(struct vnic_dev *vdev, u32 *mode, + u64 ops; + static u32 instance;