From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F590A0C41 for ; Tue, 30 Nov 2021 17:42:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 63EE3410F7; Tue, 30 Nov 2021 17:42:47 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 30C1A41142 for ; Tue, 30 Nov 2021 17:42:46 +0100 (CET) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 0BAA240016 for ; Tue, 30 Nov 2021 16:42:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638290565; bh=tjFGH9BvlRKpPKHexUUS7Embjd3EYGImRGU+GqR9+GA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QRv8YVqhvEb57GcE6Cr2uZc/9Q5BTjRimuPIum3z5+AlXc4mgTc39/Go5gpztgt4+ OmjTseJ8vPxHmZjAA34SvlGpI/m1MUAUkyBPU0WhqiEm88cEfLgx4o0VEPoqgc14IL /XkBb5a2kV2ekAk2PyX+iHDOzJ6sUANPXaWhXY0X9leQO5WUZQv8aiNwmBwKHo1afx SJkj35vb2uz91Y3DmHlro+asIs54VSv1WDuZXhckPkWYimsKwQuM334+kDyGBK5NMn 3eQnJfOuhJt7jnwX18DdQTcXp+Ig5OzZhFKgt0UAnwmAbZ9nNlD5johC7p5I7w6z6T 8XUNu6FidJpeg== Received: by mail-ed1-f70.google.com with SMTP id q17-20020aa7da91000000b003e7c0641b9cso17476171eds.12 for ; Tue, 30 Nov 2021 08:42:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tjFGH9BvlRKpPKHexUUS7Embjd3EYGImRGU+GqR9+GA=; b=20wy5P4+bSZnfG+SCdXNQrGxVwFW+wRQeYkjtc6BUqkyU51IyXm5J+Ss9aLs4xkUjq JFyPdj2Ec4EDUM3QAnjzRIXv6S2JU5Suqcu/ZPxUltyDxIFJA2rlXstpRkFIu7HYBskV 46ynCqAa6WzzorA3qe34Iv+j8oh8NiOrahhsZYZVJPJScXFq/nDeMFg3anF0C1faygNF SnMiR4J/2v/G2Ny5ztcy8Yk9UMJJu+3O0+f3FAN6Iisy5WqEGJ8ztFAOfncQGV2lJh5I 5L7RRk5jJBcsY0MSSPgQnCYVl/f0nuk9LLrRFzQlGlUvkE1eunWLTmA5xNmiMRTFOwJ5 pPMA== X-Gm-Message-State: AOAM532ejIoEYPlYoT3lDsd7DvufBKztahkaV5GX4s61mk+YQErj4Duf /DLzDMbh1I4pym1FKbU6KzrqEfBAXTzRLaRrnH3zVA108gtvL6FGWFex5rc5xJm4huNb+Z1Hx+O bCVrduGp/vcgUC43Z2hYYeJGY X-Received: by 2002:a50:ef12:: with SMTP id m18mr23807eds.381.1638290564775; Tue, 30 Nov 2021 08:42:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJxYuM3hJlqaz3XaWDice0k3js4nKb5T+DLchk0laGYnIA3Dr+iWDW85DXcDhTKxIo0FsYDCXA== X-Received: by 2002:a50:ef12:: with SMTP id m18mr23769eds.381.1638290564571; Tue, 30 Nov 2021 08:42:44 -0800 (PST) Received: from localhost.localdomain ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id bd12sm11541754edb.11.2021.11.30.08.42.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 08:42:44 -0800 (PST) From: christian.ehrhardt@canonical.com To: Jim Harris Cc: David Marchand , dpdk stable Subject: patch 'power: fix build with clang 13' has been queued to stable release 19.11.11 Date: Tue, 30 Nov 2021 17:35:33 +0100 Message-Id: <20211130163605.2460997-129-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> References: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before December 10th 2021. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/3cc36e068b4298160caa9e77c5545bd8f8e019f6 Thanks. Christian Ehrhardt --- >From 3cc36e068b4298160caa9e77c5545bd8f8e019f6 Mon Sep 17 00:00:00 2001 From: Jim Harris Date: Fri, 5 Nov 2021 15:53:51 +0000 Subject: [PATCH] power: fix build with clang 13 [ upstream commit 0353121c33846c40ff2e2282448f324c93d3ce9d ] clang-13 rightfully complains that the tot_ppi variable in update_stats is set but not used, since the final accumulated tot_ppi results isn't used anywhere. Fixes: 450f0791312c ("power: add traffic pattern aware power control") Signed-off-by: Jim Harris Reviewed-by: David Marchand --- lib/librte_power/rte_power_empty_poll.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/librte_power/rte_power_empty_poll.c b/lib/librte_power/rte_power_empty_poll.c index 0a8024ddca..6aa5a5735f 100644 --- a/lib/librte_power/rte_power_empty_poll.c +++ b/lib/librte_power/rte_power_empty_poll.c @@ -207,7 +207,7 @@ update_training_stats(struct priority_worker *poll_stats, static inline uint32_t __attribute__((always_inline)) update_stats(struct priority_worker *poll_stats) { - uint64_t tot_edpi = 0, tot_ppi = 0; + uint64_t tot_edpi = 0; uint32_t j, percent; struct priority_worker *s = poll_stats; @@ -237,7 +237,6 @@ update_stats(struct priority_worker *poll_stats) for (j = 0; j < BINS_AV; j++) { tot_edpi += s->edpi_av[j]; - tot_ppi += s->ppi_av[j]; } tot_edpi = tot_edpi / BINS_AV; -- 2.34.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-30 16:50:13.444869755 +0100 +++ 0129-power-fix-build-with-clang-13.patch 2021-11-30 16:50:05.966874821 +0100 @@ -1 +1 @@ -From 0353121c33846c40ff2e2282448f324c93d3ce9d Mon Sep 17 00:00:00 2001 +From 3cc36e068b4298160caa9e77c5545bd8f8e019f6 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 0353121c33846c40ff2e2282448f324c93d3ce9d ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -16 +17 @@ - lib/power/rte_power_empty_poll.c | 3 +-- + lib/librte_power/rte_power_empty_poll.c | 3 +-- @@ -19,4 +20,4 @@ -diff --git a/lib/power/rte_power_empty_poll.c b/lib/power/rte_power_empty_poll.c -index 975aa92997..8a2d60c576 100644 ---- a/lib/power/rte_power_empty_poll.c -+++ b/lib/power/rte_power_empty_poll.c +diff --git a/lib/librte_power/rte_power_empty_poll.c b/lib/librte_power/rte_power_empty_poll.c +index 0a8024ddca..6aa5a5735f 100644 +--- a/lib/librte_power/rte_power_empty_poll.c ++++ b/lib/librte_power/rte_power_empty_poll.c @@ -24 +25 @@ - static __rte_always_inline uint32_t + static inline uint32_t __attribute__((always_inline))