From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91116A0C41 for ; Tue, 30 Nov 2021 17:42:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B26F41186; Tue, 30 Nov 2021 17:42:48 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 8D43841142 for ; Tue, 30 Nov 2021 17:42:46 +0100 (CET) Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 340D04001B for ; Tue, 30 Nov 2021 16:42:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638290566; bh=1TzLlSRhj4WPw16q8C+bVDurKZ2m6WCmKAaoD3wxe/4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PtClqwv5Hk24k3Pn/BL+jBXWxqjZ6QtiiMAbmB0/f7LL3X2VATThiZ1P2TyVmJAsH E4rZl8axXJiEn4TrEv+wG2x7o84efOoLVfeFWxAfK+p102KD+ony7Y2HbCPyfwizo2 lZIHcZiP3uN5mjLl9avCjggr4GX1sipIA/mU6w6dh07eVaKXn8JPSkptVZL1Iq+P0I kPMBb90jRkrQ5NA0YxeUNJi/zJEkIuHkwkIyyIJaIkozr3tAmd4KdL/lXYsfuTVa77 DJNoc5zwCJ8RdxNLlPtAtGJ1DasTIlUV64zociDgfIHz0WgI95ZZcGPnLhnJIG0/Li +S+aNVusTW4Dg== Received: by mail-ed1-f69.google.com with SMTP id i19-20020a05640242d300b003e7d13ebeedso17454955edc.7 for ; Tue, 30 Nov 2021 08:42:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1TzLlSRhj4WPw16q8C+bVDurKZ2m6WCmKAaoD3wxe/4=; b=u5rf5AF47NKe/Jbpfc+zLb1YYkjTXhdUhz82Alnxr1/HEHdgnwdSz8i8QO32dM0IA8 5v689ZOKbx5g49tWIwhAtZA0cORQKfkfZEKGEbGy90SSN4hHQMK39VkLBPHRmck4bjFI KOocU+67/2vlvaL//ukeeb6/8875YpAdq/gSnaOzdpxywgT/zLqTMKD9nhmHl0S1SyBe sjTzu614MDxBI8VoZJIYhr6pZlgdLQ0TEBDSBqJTdsNx64eiWXl4uQNXsRR9GRT6AdT6 IaR93l1RKS0eDz4Ptatg/UM07o2q77dr7tAA0a9MT7OsYpP8bflBiFDI+MmCA8xY300I KtFQ== X-Gm-Message-State: AOAM533lUBT3e/2Yo1WxoGCfDDdGAxzKXRBKWHSPh192nmKgqdxzyRSy NSsClsQUN9XINIlDBc01xFtADfhZVyuGk16kXeIA6/5UlSuMIIvGMQda8S35qlD109pB6OvndA4 VN/FJkIzNemSf1HtELxmM87zb X-Received: by 2002:aa7:dd47:: with SMTP id o7mr166788edw.34.1638290565797; Tue, 30 Nov 2021 08:42:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJx+wEoc6QTUWqRkoJSw/CY/nYyLm2hhMxczzQen+GS53yqag52sLSwwf7M2vygC/N4kyagNMA== X-Received: by 2002:aa7:dd47:: with SMTP id o7mr166766edw.34.1638290565647; Tue, 30 Nov 2021 08:42:45 -0800 (PST) Received: from localhost.localdomain ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id bd12sm11541754edb.11.2021.11.30.08.42.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 08:42:45 -0800 (PST) From: christian.ehrhardt@canonical.com To: Bing Zhao Cc: Viacheslav Ovsiienko , dpdk stable Subject: patch 'net/mlx5: fix RETA update without stopping device' has been queued to stable release 19.11.11 Date: Tue, 30 Nov 2021 17:35:34 +0100 Message-Id: <20211130163605.2460997-130-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> References: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before December 10th 2021. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/e3f1ad1116f8d6bfd2bb32c3ac0e27c67495c29d Thanks. Christian Ehrhardt --- >From e3f1ad1116f8d6bfd2bb32c3ac0e27c67495c29d Mon Sep 17 00:00:00 2001 From: Bing Zhao Date: Fri, 5 Nov 2021 08:10:57 +0200 Subject: [PATCH] net/mlx5: fix RETA update without stopping device [ upstream commit 6b5b3005cb1854e471fa1ef3eb579dbd444c05b0 ] The global redirection table is used to create the default flow rules for the ingress traffic with the lowest priority. It is also used to create the default RSS rule in the destination table when there is a tunnel offload. To update the RETA in-flight, there is no restriction in the ethdev API. In the previous implementation of mlx5, a port restart was needed to make the new configuration take effect. The restart is heavy, e.g., all the queues will be released and reallocated, users' rules will be flushed. Since the restart is internal, there is a risk to crash the application when some change in the ethdev is introduced but no workaround is done in mlx5 PMD. The users' rules, including the default miss rule for tunnel offload, should not be impacted by the RETA update. It is improper to flush all rules when updating RETA. With this patch, only the default rules will be flushed and re-created with the new table configuration. Fixes: 3f2fe392bd49 ("net/mlx5: fix crash during RETA update") Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_rss.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rss.c b/drivers/net/mlx5/mlx5_rss.c index a0daafe81d..468358a589 100644 --- a/drivers/net/mlx5/mlx5_rss.c +++ b/drivers/net/mlx5/mlx5_rss.c @@ -221,12 +221,6 @@ mlx5_dev_rss_reta_update(struct rte_eth_dev *dev, assert(reta_conf[idx].reta[pos] < priv->rxqs_n); (*priv->reta_idx)[i] = reta_conf[idx].reta[pos]; } - priv->skip_default_rss_reta = 1; - - if (dev->data->dev_started) { - mlx5_dev_stop(dev); - return mlx5_dev_start(dev); - } - return 0; + return mlx5_traffic_restart(dev); } -- 2.34.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-30 16:50:13.492476594 +0100 +++ 0130-net-mlx5-fix-RETA-update-without-stopping-device.patch 2021-11-30 16:50:05.966874821 +0100 @@ -1 +1 @@ -From 6b5b3005cb1854e471fa1ef3eb579dbd444c05b0 Mon Sep 17 00:00:00 2001 +From e3f1ad1116f8d6bfd2bb32c3ac0e27c67495c29d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 6b5b3005cb1854e471fa1ef3eb579dbd444c05b0 ] + @@ -28 +29,0 @@ -Cc: stable@dpdk.org @@ -37 +38 @@ -index 75af05b7b0..e2b478b75c 100644 +index a0daafe81d..468358a589 100644 @@ -40,2 +41,2 @@ -@@ -218,12 +218,6 @@ mlx5_dev_rss_reta_update(struct rte_eth_dev *dev, - MLX5_ASSERT(reta_conf[idx].reta[pos] < priv->rxqs_n); +@@ -221,12 +221,6 @@ mlx5_dev_rss_reta_update(struct rte_eth_dev *dev, + assert(reta_conf[idx].reta[pos] < priv->rxqs_n);