From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF93CA0C41 for ; Tue, 30 Nov 2021 17:43:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C4F3741177; Tue, 30 Nov 2021 17:43:00 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id 38B86410F7 for ; Tue, 30 Nov 2021 17:42:59 +0100 (CET) Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 1C9553F1B2 for ; Tue, 30 Nov 2021 16:42:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638290579; bh=TuAPKshibTnwCjjFjhmarxHk09DP31HikEGG00AL5YE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=dJX3y+7rYsIhKSb2Z89dAknm4PXyT/wdj43ICjy6pkCVOPmJBjdmVDYJTjJa/iXAC iI/+ncul9cHBUNNuaTz2VXPgTj4Yme3lpqHdZOpijnSJkXJxDUH2t4pBxoe/fW15Ut 9duHsGCGkb/U2fydkHBGWcOfY3ghz8bi45WIxWZR12vaLlnSEiZ7WovfcA1sPtAgzI UcKKTNgIyvYnirLC9l5Go6oI3pbe4F8zp1jWat04HUoYjvU7qvRSH7LwAy31pWt+uU w01SB+9wEjKbb6IsyMIX7hBe5fmqmh6qBZwU8l179ddrlTIR7+XTwHjSTnEfJvYwNs oYacBt1nbYhvQ== Received: by mail-ed1-f72.google.com with SMTP id w18-20020a056402071200b003e61cbafdb4so17492179edx.4 for ; Tue, 30 Nov 2021 08:42:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TuAPKshibTnwCjjFjhmarxHk09DP31HikEGG00AL5YE=; b=wWfNoBM3ouDtOBLo+HtSnNQY+z63Z2e+KMpDEZ6vir2Kpn37HbDEi+AN66Ra79xLja Cw12wrMiSCWLFyNDkqpWaY/NsdfzgzuummWE/UMJK9e3WzkYD2nQk4gkoM0njxailrwT VOpjvngRM2zarw7BIakJpj2tOt/3v7nQXpsjASxVUjh5xSH8S10UeTnMcGJiwN9iXqDA Eori92ikLHBqBWC/PgFx+GwuMrsAEdLDorAzP8GONWA68IxTj0+V8AUm4LIa7/DdhxM1 bfbUH66onEhuEGXaI6mJUmjoMfo4S2QQjQtCq8gVdGkjqjlcl+vDosToir50r8STie0l /h+Q== X-Gm-Message-State: AOAM530e9APcTekw5K5t8Ahw4M/F2HtMkBpSJnSEZv4+N2WUoODwRs4V kc/xQz1MwuzJSHHpuqLCJkRTweV+7hRtzi5pGdLDe0Bt6jhaTq4HzOZMKsAYdIz7YyYXqwTUnNq grQvHfEhllh/G/K2MPqsP1YLG X-Received: by 2002:a50:fd16:: with SMTP id i22mr132391eds.224.1638290578804; Tue, 30 Nov 2021 08:42:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJwJNm2wGcaAZO1XIntUOcMbc08ROlyu9FmvlnPI8WBnUIbpjfRJZb31ZqPPxgNm/WrQuOPu3g== X-Received: by 2002:a50:fd16:: with SMTP id i22mr132374eds.224.1638290578672; Tue, 30 Nov 2021 08:42:58 -0800 (PST) Received: from localhost.localdomain ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id c8sm11188092edu.60.2021.11.30.08.42.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 08:42:58 -0800 (PST) From: christian.ehrhardt@canonical.com To: Conor Walsh Cc: Liang Longfeng , David Marchand , dpdk stable Subject: patch 'net/hinic/base: remove some unused variables' has been queued to stable release 19.11.11 Date: Tue, 30 Nov 2021 17:35:37 +0100 Message-Id: <20211130163605.2460997-133-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> References: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before December 10th 2021. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/962fa4d5b464fc98af6dcffde2ade1d2d265425c Thanks. Christian Ehrhardt --- >From 962fa4d5b464fc98af6dcffde2ade1d2d265425c Mon Sep 17 00:00:00 2001 From: Conor Walsh Date: Mon, 15 Nov 2021 17:58:54 +0000 Subject: [PATCH] net/hinic/base: remove some unused variables [ upstream commit b5dedf261c907df478413f5c9e4ba97fc568bb4e ] Reported by clang 13. Bugzilla ID: 881 Fixes: a4957d87e05a ("net/hinic/base: add mgmt module") Reported-by: Liang Longfeng Signed-off-by: Conor Walsh Reviewed-by: David Marchand --- drivers/net/hinic/base/hinic_pmd_mgmt.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/hinic/base/hinic_pmd_mgmt.c b/drivers/net/hinic/base/hinic_pmd_mgmt.c index d5fd16f235..6357fbe8ae 100644 --- a/drivers/net/hinic/base/hinic_pmd_mgmt.c +++ b/drivers/net/hinic/base/hinic_pmd_mgmt.c @@ -133,16 +133,12 @@ static void prepare_header(struct hinic_msg_pf_to_mgmt *pf_to_mgmt, static void prepare_mgmt_cmd(u8 *mgmt_cmd, u64 *header, void *msg, int msg_len) { - u32 cmd_buf_max = MAX_PF_MGMT_BUF_SIZE; - memset(mgmt_cmd, 0, MGMT_MSG_RSVD_FOR_DEV); mgmt_cmd += MGMT_MSG_RSVD_FOR_DEV; - cmd_buf_max -= MGMT_MSG_RSVD_FOR_DEV; memcpy(mgmt_cmd, header, sizeof(*header)); mgmt_cmd += sizeof(*header); - cmd_buf_max -= sizeof(*header); memcpy(mgmt_cmd, msg, msg_len); } @@ -615,7 +611,6 @@ static int recv_mgmt_msg_handler(struct hinic_msg_pf_to_mgmt *pf_to_mgmt, void *msg_body = header + sizeof(msg_header); u8 *dest_msg; u8 seq_id, seq_len; - u32 msg_buf_max = MAX_PF_MGMT_BUF_SIZE; u8 front_id; u16 msg_id; @@ -635,7 +630,6 @@ static int recv_mgmt_msg_handler(struct hinic_msg_pf_to_mgmt *pf_to_mgmt, } dest_msg = (u8 *)recv_msg->msg + seq_id * HINIC_MSG_SEG_LEN; - msg_buf_max -= seq_id * HINIC_MSG_SEG_LEN; memcpy(dest_msg, msg_body, seq_len); if (!HINIC_MSG_HEADER_GET(msg_header, LAST)) -- 2.34.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-30 16:50:13.655973085 +0100 +++ 0133-net-hinic-base-remove-some-unused-variables.patch 2021-11-30 16:50:05.970874851 +0100 @@ -1 +1 @@ -From b5dedf261c907df478413f5c9e4ba97fc568bb4e Mon Sep 17 00:00:00 2001 +From 962fa4d5b464fc98af6dcffde2ade1d2d265425c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b5dedf261c907df478413f5c9e4ba97fc568bb4e ] + @@ -19 +21 @@ -index 9b399502de..6ecca407a1 100644 +index d5fd16f235..6357fbe8ae 100644