From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9024A0C41 for ; Tue, 30 Nov 2021 17:43:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E1F54410F7; Tue, 30 Nov 2021 17:43:19 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id E58CD411A7 for ; Tue, 30 Nov 2021 17:43:17 +0100 (CET) Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id B4CC64000A for ; Tue, 30 Nov 2021 16:43:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638290597; bh=q8qCCGhj241l/5W5hLtc4qcJlKB81qohJG/mAE1wd8M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=itOG/OvhSpgcT2M9pcJgSOuoJfnhTx2cdVns8N701oLMTqKXRuuHjQ7C6/2odAMxL DiHJONlgRp2VmEOTFqTACMJC6G/Y9iyJt2HO+C3y/PO+0dHtO0HIalJOJaIQL8VtCk urIZVA99eJBRg3OxN8DyOErZ/vmfi9RzKbgcfZ4PAFkRncVYdHM5J2PI2ot0UriEbO qJfvq2HGzXJ9yPYjq29F5IGFwYj3twJGdKoTjQJA5BA31MbP9xHti++IYxfbXxX0AB JleKf3/UlYPDX8TbRDUWiuqjEqtRvzLMVAXWSUlSgbNmJm9J78uxQXkJf6Jj6oELIW SbyjJdCQBuujQ== Received: by mail-ed1-f71.google.com with SMTP id w4-20020aa7cb44000000b003e7c0f7cfffso17500670edt.2 for ; Tue, 30 Nov 2021 08:43:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=q8qCCGhj241l/5W5hLtc4qcJlKB81qohJG/mAE1wd8M=; b=Q/06W2M7wOzL55lbtZmRWe/fX7wCDQ3+LiwAmvyWuWyfnqU3eX0zKgAR7Adiy2h4CX CjJ6vn9lBtmOPWPPcG24UeBdFxO3xWUJwofx2dxV4DX5ZkQrszTou2zsatnuvHq/Vn2X brxixkMVIAxJDv9+RhfjnNW8PchQt542BPdTK20E+tbx19ZdsIvmoVyL+gwb2Wd1tiOI 12EtuMtgp1hRL7viRXaMeFqqdvFzHem1Tg19Hwbxrj+8S07k5lIj0gIVT0/eqsn9yxdy t7kloaZy7lT9ghxh4TCot5JJCaOV5mdaSuvUhXHk4XU04+8NwL/VZ+NgpOwXYYG91nph 7nfQ== X-Gm-Message-State: AOAM5305ybm76FivjXdp3efLJjAX/VWf3Oae0Ln6eVHobiXChr9V3yu5 wLmQrDIu6rcHQiHplhu8A/XHZ8BSaUSpZvIputjPl15/evMvsm1IE8GO33henGXFo82jy6wPjOm mu0IUSaeiSsijagzVfS/mWgxq X-Received: by 2002:a17:906:4fc4:: with SMTP id i4mr234375ejw.81.1638290596168; Tue, 30 Nov 2021 08:43:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJxwQoS9hc7gB073GXnGbbCW+Rga5wnAtZOkq2PLdskkXIvNw320tL2i3nVkwCPcdPf4u8w+TQ== X-Received: by 2002:a17:906:4fc4:: with SMTP id i4mr234357ejw.81.1638290596009; Tue, 30 Nov 2021 08:43:16 -0800 (PST) Received: from localhost.localdomain ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id dy4sm11454065edb.92.2021.11.30.08.43.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 08:43:15 -0800 (PST) From: christian.ehrhardt@canonical.com To: Conor Walsh Cc: Liang Longfeng , David Marchand , dpdk stable Subject: patch 'examples/performance-thread: remove unused hits count' has been queued to stable release 19.11.11 Date: Tue, 30 Nov 2021 17:35:44 +0100 Message-Id: <20211130163605.2460997-140-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> References: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before December 10th 2021. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/43442efcf4a0ba642977e80cd2ec5843e9cb7849 Thanks. Christian Ehrhardt --- >From 43442efcf4a0ba642977e80cd2ec5843e9cb7849 Mon Sep 17 00:00:00 2001 From: Conor Walsh Date: Mon, 15 Nov 2021 17:58:55 +0000 Subject: [PATCH] examples/performance-thread: remove unused hits count [ upstream commit 130e99db590073dd58da7e5c32dec8c2181527dd ] Reported by clang 13. This patch removes the hits variable from the cpu_load_collector function within the performance thread example app as it is an unused but set variable. Bugzilla ID: 881 Fixes: d48415e1fee3 ("examples/performance-thread: add l3fwd-thread app") Reported-by: Liang Longfeng Signed-off-by: Conor Walsh Reviewed-by: David Marchand --- examples/performance-thread/l3fwd-thread/main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/performance-thread/l3fwd-thread/main.c index aee075f2d2..4792d92122 100644 --- a/examples/performance-thread/l3fwd-thread/main.c +++ b/examples/performance-thread/l3fwd-thread/main.c @@ -1885,7 +1885,6 @@ process_burst(struct rte_mbuf *pkts_burst[MAX_PKT_BURST], int nb_rx, static int __attribute__((noreturn)) cpu_load_collector(__rte_unused void *arg) { unsigned i, j, k; - uint64_t hits; uint64_t prev_tsc, diff_tsc, cur_tsc; uint64_t total[MAX_CPU] = { 0 }; unsigned min_cpu = MAX_CPU; @@ -1975,12 +1974,10 @@ cpu_load_collector(__rte_unused void *arg) { printf("cpu# proc%% poll%% overhead%%\n\n"); for (i = min_cpu; i <= max_cpu; i++) { - hits = 0; printf("CPU %d:", i); for (j = 0; j < MAX_CPU_COUNTER; j++) { printf("%7" PRIu64 "", cpu_load.hits[j][i] * 100 / cpu_load.counter); - hits += cpu_load.hits[j][i]; cpu_load.hits[j][i] = 0; } printf("%7" PRIu64 "\n", -- 2.34.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-30 16:50:13.998555623 +0100 +++ 0140-examples-performance-thread-remove-unused-hits-count.patch 2021-11-30 16:50:05.986874968 +0100 @@ -1 +1 @@ -From 130e99db590073dd58da7e5c32dec8c2181527dd Mon Sep 17 00:00:00 2001 +From 43442efcf4a0ba642977e80cd2ec5843e9cb7849 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 130e99db590073dd58da7e5c32dec8c2181527dd ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index 3a6a33bda3..8a35040597 100644 +index aee075f2d2..4792d92122 100644 @@ -27 +28 @@ - static int __rte_noreturn + static int __attribute__((noreturn)) @@ -34 +35 @@ -@@ -1972,12 +1971,10 @@ cpu_load_collector(__rte_unused void *arg) { +@@ -1975,12 +1974,10 @@ cpu_load_collector(__rte_unused void *arg) {