From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FA1CA0C41 for ; Tue, 30 Nov 2021 17:43:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F9ED410F7; Tue, 30 Nov 2021 17:43:32 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id CEAF541142 for ; Tue, 30 Nov 2021 17:43:31 +0100 (CET) Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id A7B773F1ED for ; Tue, 30 Nov 2021 16:43:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638290611; bh=BCjDLd3I8rJxtu0r2HlNu4nx1PxAeIb4lLRhTWfy/Ug=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZVz4qpXcJtchOc7rA1feuP+Sk0nmr3bg8ytWgfWYtBp/Aeec47a3thlQkVHhOD/1L sFDCi3deog67220RN2qw94wCagzkZQ6HMJ+s+VZ7uvYCOcxJpFVS22+i091khKPTFi 3iUBJtuzEa+lRdv5hBNM2U3gb8Shp4e/VV50SF2RyjpJp9UZzkj9NJXRSaXnxo17EV 7FT5rUhvphllGMnKZvnkxMIiYXLXBTlhODHj5Y6jmERZfzkDTzCqf6YcRdcTnGAgLM RKjP6JBT4bii1QZ6CC0mc6lDPp5sNmlXsPfBQaDujSkvf/dQiQk+RsC8p8ncXs35Fp /XgdVtQrKYb+Q== Received: by mail-ed1-f69.google.com with SMTP id s12-20020a50ab0c000000b003efdf5a226fso11310719edc.10 for ; Tue, 30 Nov 2021 08:43:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BCjDLd3I8rJxtu0r2HlNu4nx1PxAeIb4lLRhTWfy/Ug=; b=rTLVusx+xhVB/VxOObZGF2pJV1MxslCrtd4QdMLFNm8seBNzcf0W6+9wnx42VNgFy/ logro84Vt3cgF+rZcrImPEcb63JNHQgaLpVp9CRb+9mGrl2PAtIf5us2AzR2UDXi2aVS AZwISvv0Anr+KCPXvwXXm46LtEKNIENPRGJ2D9W8H+uEz0QewHAMSllV24OiGVvyCMaO ADd1KqetWK3d4FWXbRM6FHkkp+umusbim++0iH9IG9Gfkfc/Yq8+wLMg0P+TDSeGArnj bJim6ohP4pAc8bB5B9xamhEatXbOKgjw/gi1qcVtL+XHdCTHPYmwqMTeUb8pT/c0g1QP dmYw== X-Gm-Message-State: AOAM533sJK+baECXNa8A7QJxByPqPtRm+z2qZQi6Gi985fg2FBDpi3h6 23/LaMF2p2fN3TR0BNRxVLDGamne6sIFi0+WC37zkoaTDsFp1hpc6hXHpNuD6/mkdS/wVfF6CZ4 gyIKUcPfhQj9x/z7KD0AoDpez X-Received: by 2002:a05:6402:1395:: with SMTP id b21mr49886edv.299.1638290611140; Tue, 30 Nov 2021 08:43:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJzxQS7GgTOYusL95fDa+iH8xhBJuDlad45MD66viSnoBy1EK9YVqn/gj2E7xm2eX60bD75nHw== X-Received: by 2002:a05:6402:1395:: with SMTP id b21mr49871edv.299.1638290610999; Tue, 30 Nov 2021 08:43:30 -0800 (PST) Received: from localhost.localdomain ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id kx3sm9157364ejc.112.2021.11.30.08.43.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 08:43:30 -0800 (PST) From: christian.ehrhardt@canonical.com To: Harneet Singh Cc: Anatoly Burakov , dpdk stable Subject: patch 'examples/l3fwd-power: fix early shutdown' has been queued to stable release 19.11.11 Date: Tue, 30 Nov 2021 17:35:49 +0100 Message-Id: <20211130163605.2460997-145-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> References: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before December 10th 2021. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/c98edab429c991ee3b2e22fff3c3a688e224d00d Thanks. Christian Ehrhardt --- >From c98edab429c991ee3b2e22fff3c3a688e224d00d Mon Sep 17 00:00:00 2001 From: Harneet Singh Date: Fri, 29 Oct 2021 14:05:56 +0000 Subject: [PATCH] examples/l3fwd-power: fix early shutdown [ upstream commit 19781e7a038ac3fdae4d71904268daa6ee399001 ] Currently, EAL init cannot be interrupted with SIGINT because the signal handler is already overridden by the time EAL init happens. Fix it by moving signal handler installation to after EAL initialization, to allow SIGNIT to interrupt EAL initialization. Fixes: d7937e2e3d12 ("power: initial import") Fixes: 613ce6691c0d ("examples/l3fwd-power: implement proper shutdown") Signed-off-by: Harneet Singh Acked-by: Anatoly Burakov --- examples/l3fwd-power/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index 70a47ed650..fdad035bc0 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -2216,9 +2216,6 @@ main(int argc, char **argv) uint8_t num_telstats = RTE_DIM(telstats_strings); const char *ptr_strings[num_telstats]; - /* catch SIGINT and restore cpufreq governor to ondemand */ - signal(SIGINT, signal_exit_now); - /* init EAL */ ret = rte_eal_init(argc, argv); if (ret < 0) @@ -2226,6 +2223,9 @@ main(int argc, char **argv) argc -= ret; argv += ret; + /* catch SIGINT and restore cpufreq governor to ondemand */ + signal(SIGINT, signal_exit_now); + /* init RTE timer library to be used late */ rte_timer_subsystem_init(); -- 2.34.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-30 16:50:14.286360444 +0100 +++ 0145-examples-l3fwd-power-fix-early-shutdown.patch 2021-11-30 16:50:06.026875261 +0100 @@ -1 +1 @@ -From 19781e7a038ac3fdae4d71904268daa6ee399001 Mon Sep 17 00:00:00 2001 +From c98edab429c991ee3b2e22fff3c3a688e224d00d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 19781e7a038ac3fdae4d71904268daa6ee399001 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index 6988a0ed34..b8b3be2b8a 100644 +index 70a47ed650..fdad035bc0 100644 @@ -26,3 +27,3 @@ -@@ -2540,9 +2540,6 @@ main(int argc, char **argv) - uint16_t portid; - const char *ptr_strings[NUM_TELSTATS]; +@@ -2216,9 +2216,6 @@ main(int argc, char **argv) + uint8_t num_telstats = RTE_DIM(telstats_strings); + const char *ptr_strings[num_telstats]; @@ -36 +37 @@ -@@ -2550,6 +2547,9 @@ main(int argc, char **argv) +@@ -2226,6 +2223,9 @@ main(int argc, char **argv)