From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2DA0A0C41 for ; Tue, 30 Nov 2021 17:43:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB89A410F7; Tue, 30 Nov 2021 17:43:45 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id 91FE5410F7 for ; Tue, 30 Nov 2021 17:43:44 +0100 (CET) Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id E77F33F1ED for ; Tue, 30 Nov 2021 16:43:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638290622; bh=Nh428jrTBdOSVMFcQE+GenXVrLn7iWJsKvQSI1AYN8s=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GaXK4eqiaSA6MTWxnc1LcUSGkJEjNmRtjQL9HHyCfi1VnCZUDG5SnbriqubPvYWzs L9wogDSoZcgTnKc71CM0nFkighrH/f4Ba8I6eb9piEoRLl9BLvTB8yu7aFRY+rZMvA tJsEnoGkxHPb/8MevzfPNzfIkhtkaqIlRc48c6/MYYdxhcn2Ofp2GrF89bkyTjSsrV aQEKvpQ0hPfeSy6naCSoNmrlhkVvhul7F+CxAREb4Eae6tCNgIjzoUTIXoFChNQy+q NpbVwyDmdohpnI6pa5lTeQgWbiznyjKg/GJqhl7MyVNz/HOAODtuqHF/5btbT2eD6x ebZEfUtsM0E7w== Received: by mail-ed1-f71.google.com with SMTP id n11-20020aa7c68b000000b003e7d68e9874so17484078edq.8 for ; Tue, 30 Nov 2021 08:43:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Nh428jrTBdOSVMFcQE+GenXVrLn7iWJsKvQSI1AYN8s=; b=HIMZLp/9AaUKgHxsUQSTxU5HrF8VrnRYbbn1js53jIa4LhsR+7hxKBJU6JCNYYc86b 8/p5cnekbsyRlJMMlcG/gIiQ9FZA+qOauQ4A6kEc8WP9fRzYLIbZFPrE6QumJyFae/m2 BmjW1qCO9IsaNKLuMwCK0KOOSL8E+AK9qMFduXOv7gFBpkZBy8auKepegv9QbxJMURmS 774vqpA6eB0TPB6zrQ87nd+HckC0P5A9PVQH9WJlci3eiWwz915LoS96suB3DsLPltTt 8BzCzIXvocTT0FumsE+Zi6CaaSfW15aL5D88S9thOWaPShK1HBTPi3xGCBRton5ZXMDF e1DA== X-Gm-Message-State: AOAM533oB+HIQtiO3FaZEp801cR5sj5RqoEe62ZaxJOcG+EFKEZ1Jf/D vT8/UVel4r05I1KZvMfNI8BKZ9Ii7Nc+yolJSsbpDPzbXiwG7vok8Y0qAFZCv8U/Z1ckp849u6o wjOUeE3MW7r1UnLQdAoZqF9qi X-Received: by 2002:a05:6402:2751:: with SMTP id z17mr128678edd.296.1638290622379; Tue, 30 Nov 2021 08:43:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJysJL5gL96uu7PBIvbkId6gkHzpv+ngqzR/69oh1gOSGEBmwE8QSOuduOyyIPLhJ52UGIgjrA== X-Received: by 2002:a05:6402:2751:: with SMTP id z17mr128654edd.296.1638290622231; Tue, 30 Nov 2021 08:43:42 -0800 (PST) Received: from localhost.localdomain ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id ds17sm9711078ejc.45.2021.11.30.08.43.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 08:43:41 -0800 (PST) From: christian.ehrhardt@canonical.com To: Gregory Etelson Cc: Anatoly Burakov , dpdk stable Subject: patch 'examples/multi_process: fix Rx packets distribution' has been queued to stable release 19.11.11 Date: Tue, 30 Nov 2021 17:35:50 +0100 Message-Id: <20211130163605.2460997-146-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> References: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before December 10th 2021. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/2f782b75e8801616e2e8dedf5f05755d7ced135f Thanks. Christian Ehrhardt --- >From 2f782b75e8801616e2e8dedf5f05755d7ced135f Mon Sep 17 00:00:00 2001 From: Gregory Etelson Date: Wed, 10 Nov 2021 18:57:59 +0200 Subject: [PATCH] examples/multi_process: fix Rx packets distribution [ upstream commit 69f9d8aa357d2299e057b7e335f340e20a0c5e7e ] MP servers distributes Rx packets between clients according to round-robin scheme. Current implementation always started packets distribution from the first client. That procedure resulted in uniform distribution in cases when Rx packets number was around clients number multiplication. However, if RX burst repeatedly returned single packet, round-robin scheme would not work because all packets were assigned to the first client only. The patch does not restart packets distribution from the first client. Packets distribution always continues to the next client. Fixes: af75078fece3 ("first public release") Signed-off-by: Gregory Etelson Acked-by: Anatoly Burakov --- examples/multi_process/client_server_mp/mp_server/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/multi_process/client_server_mp/mp_server/main.c b/examples/multi_process/client_server_mp/mp_server/main.c index b349d90d92..61cef86a05 100644 --- a/examples/multi_process/client_server_mp/mp_server/main.c +++ b/examples/multi_process/client_server_mp/mp_server/main.c @@ -233,7 +233,7 @@ process_packets(uint32_t port_num __rte_unused, struct rte_mbuf *pkts[], uint16_t rx_count) { uint16_t i; - uint8_t client = 0; + static uint8_t client; for (i = 0; i < rx_count; i++) { enqueue_rx_packet(client, pkts[i]); -- 2.34.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-30 16:50:14.326380682 +0100 +++ 0146-examples-multi_process-fix-Rx-packets-distribution.patch 2021-11-30 16:50:06.026875261 +0100 @@ -1 +1 @@ -From 69f9d8aa357d2299e057b7e335f340e20a0c5e7e Mon Sep 17 00:00:00 2001 +From 2f782b75e8801616e2e8dedf5f05755d7ced135f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 69f9d8aa357d2299e057b7e335f340e20a0c5e7e ] + @@ -21 +22,0 @@ -Cc: stable@dpdk.org @@ -30 +31 @@ -index b4761ebc7b..f54bb8b75a 100644 +index b349d90d92..61cef86a05 100644 @@ -33 +34 @@ -@@ -234,7 +234,7 @@ process_packets(uint32_t port_num __rte_unused, +@@ -233,7 +233,7 @@ process_packets(uint32_t port_num __rte_unused,