From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5332BA0C41 for ; Tue, 30 Nov 2021 17:43:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D917410F7; Tue, 30 Nov 2021 17:43:50 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id 7296B4118F for ; Tue, 30 Nov 2021 17:43:47 +0100 (CET) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 50C433F1ED for ; Tue, 30 Nov 2021 16:43:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638290627; bh=IjHehv9t15tlsWZ9uQ0didpwH5nFZcNFWa76MP3Wf3U=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gYheu5qN4W+sa98j+gwKf6jIDAFPHvb2Ff336RbPJV3YSStk+/dNTu1njh6OtQ0uM 5sL3KufZOpIurH3T3ngPN9en8KKWPtqSTqZH4uueXkpq0vNH1CqAXjuW2qA1MSpXNK HwvmqW/eDyazQBubhEBAmNfDEAg83GhVWWMON3fC2YRvJSgdCnXdxdT8n6aMmUENSO a1aQmwM3AINfac7fhBEznatSS2lo4cA0FQH6o9WIixY8ZBE4zQ9//78kOrqDaooo5K SvcnPnBws43vCXxNyLRl+9EXc2dhZzQVu76GyumXmaK8Jq4M3oS274fKCgJbXpBfUC sJhH/I1xFWDhw== Received: by mail-ed1-f70.google.com with SMTP id v1-20020aa7cd41000000b003e80973378aso17432050edw.14 for ; Tue, 30 Nov 2021 08:43:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IjHehv9t15tlsWZ9uQ0didpwH5nFZcNFWa76MP3Wf3U=; b=ABOATaKl4UE68YS3RnV2708ET1JJmuC4tgDyepdfrtjWSo6a5zhF15Oldo9ndeRdyv GG+LbQCvh/wtWbnLI+Jf41FmgheNKYrOaeigDbJIUa8PI3qN+tOe7ZVPgTHtB4qZNmnm 9z9Im/ohWRZGjxAbUmR1ZFuae2NVeODMVYiJEWvctPwVFisiI0eEyCY8i98rNulsdWTu zJaSiYk8rv7kZL+bRc44hajbg84HWQcE2zrL4eR6ubjzYHWCFC4yn1wI+sVGJMvvVFTS +Gka69kGVju1jeu1gf7Ll6XJK7Rqa6DfuUPLKSSGDe/lbQBpa2oW2lYUxgnb2huSDF1E UwdA== X-Gm-Message-State: AOAM532m3sCsQlZRxvm51TDRd3AWXl+JY72P9D1ynN5r3/lYwo1h4rPX PpV+WoIA6MzfoliyKnsHvPEGRTFrakcxXt347wbq3XkgWD+jlR6gFco0vqe7G9jLcwnxcVOHm1t c3uARIBesr3tJioxSyoBDzoB2 X-Received: by 2002:a17:906:b084:: with SMTP id x4mr276929ejy.214.1638290626773; Tue, 30 Nov 2021 08:43:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJzWp+QUnzQL4Q9givWaZzLdMDRlDbVEr1oQeHXUux6RexbRA0hsGLyZF3ju6fAPbiOXk/Z+8g== X-Received: by 2002:a17:906:b084:: with SMTP id x4mr276904ejy.214.1638290626583; Tue, 30 Nov 2021 08:43:46 -0800 (PST) Received: from localhost.localdomain ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id ds17sm9711078ejc.45.2021.11.30.08.43.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 08:43:46 -0800 (PST) From: christian.ehrhardt@canonical.com To: Kumara Parameshwaran Cc: Ferruh Yigit , dpdk stable Subject: patch 'net/failsafe: fix secondary process probe' has been queued to stable release 19.11.11 Date: Tue, 30 Nov 2021 17:35:54 +0100 Message-Id: <20211130163605.2460997-150-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> References: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before December 10th 2021. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/bb085aa7c14b188e45453f9324f82ca7fcae4c7f Thanks. Christian Ehrhardt --- >From bb085aa7c14b188e45453f9324f82ca7fcae4c7f Mon Sep 17 00:00:00 2001 From: Kumara Parameshwaran Date: Thu, 11 Nov 2021 18:14:58 +0530 Subject: [PATCH] net/failsafe: fix secondary process probe [ upstream commit 47f5dee19e5f9a2cf1883a7119675d7a25470aca ] Remove the vdev args check for secondary process which prevents the secondary from attaching to the device created by the primary process via the hotplug framework. This check was removed for other vdevs but was missed for failsafe. Fixes: 4852aa8f6e21 ("drivers/net: enable hotplug on secondary process") Signed-off-by: Kumara Parameshwaran Reviewed-by: Ferruh Yigit --- drivers/net/failsafe/failsafe.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c index 72362f35de..978c55007a 100644 --- a/drivers/net/failsafe/failsafe.c +++ b/drivers/net/failsafe/failsafe.c @@ -348,8 +348,7 @@ rte_pmd_failsafe_probe(struct rte_vdev_device *vdev) INFO("Initializing " FAILSAFE_DRIVER_NAME " for %s", name); - if (rte_eal_process_type() == RTE_PROC_SECONDARY && - strlen(rte_vdev_device_args(vdev)) == 0) { + if (rte_eal_process_type() == RTE_PROC_SECONDARY) { eth_dev = rte_eth_dev_attach_secondary(name); if (!eth_dev) { ERROR("Failed to probe %s", name); -- 2.34.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-30 16:50:14.581719270 +0100 +++ 0150-net-failsafe-fix-secondary-process-probe.patch 2021-11-30 16:50:06.110875878 +0100 @@ -1 +1 @@ -From 47f5dee19e5f9a2cf1883a7119675d7a25470aca Mon Sep 17 00:00:00 2001 +From bb085aa7c14b188e45453f9324f82ca7fcae4c7f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 47f5dee19e5f9a2cf1883a7119675d7a25470aca ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index ad6b43538e..3c754a5f66 100644 +index 72362f35de..978c55007a 100644 @@ -24 +25 @@ -@@ -340,8 +340,7 @@ rte_pmd_failsafe_probe(struct rte_vdev_device *vdev) +@@ -348,8 +348,7 @@ rte_pmd_failsafe_probe(struct rte_vdev_device *vdev)