From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF04DA0C41 for ; Tue, 30 Nov 2021 17:37:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E6CB1410F7; Tue, 30 Nov 2021 17:37:24 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 0B4CA411CB for ; Tue, 30 Nov 2021 17:37:24 +0100 (CET) Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id E23323FFF2 for ; Tue, 30 Nov 2021 16:37:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638290243; bh=8khZpVFQPZLLIxunxacsDif2nAS/yucvgLLj0x8SM5E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=t24IeUuTJvI5yiuoRz1d3YySsqN9J1nRPyhftVR8U9jbwIJZa3AgIRNcNF/GeAbko mrH3HdR6hJMyqGtnYj/rWxLQHsEV18j5Ve9ElHn1qjhYmReb5hctO/DNag9S2dqSnl 5BDPTvodLek0T4BvOfcszqLv8xM6/l8YD8m55bITQpwVH+iLW6xGoH9G5oY5yCVOub /ifqcCd0E/ecfG0MzkshwrhRjJG+XjqPbO69XXzlkzxH7sJ1ZRi8zJURAI0k6QjLnd Zf0T4j3+dIpWkmeyhCXSkOS5cowMCe3hLVv6SQjv0tqgNglXyTcORJHjcD9wsOt1C0 5/lTssnwvCA1A== Received: by mail-ed1-f69.google.com with SMTP id p4-20020aa7d304000000b003e7ef120a37so17395480edq.16 for ; Tue, 30 Nov 2021 08:37:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8khZpVFQPZLLIxunxacsDif2nAS/yucvgLLj0x8SM5E=; b=NzhtjxQVK8pgA58KLShUHbjuXhR1jK1k8a8YX4XhYFoVJ0FGCLnbEmICnI5p5d2CDe CUGNluORLl11ZMPxLFMbuCA6XIKH6qYh3qxzp8GGM3HaBseyiFZPmgOjQObNQXpPR8Yc Zjwiwq7Qy/SSaaKiGtpflCSjTm2LOJAjpKq+vIXMvfOjnQ5PRMTRZGyi55eHQ+D1Pzn7 QXImcMu7ydOrPCWiYFEhy3MKpp9tqNZEY8QD505i1XT9arqaO4Id6+cLP1xi+ejP1t18 LarUMip2v1RL4GgJGFtoslBp3XpLpg0Dvi/i/+FlczHQ1k6f9yt/BHz6+WJSbYmh9Ywk Yykg== X-Gm-Message-State: AOAM533Dw9cjoRlUyBdh+7b9wIamdrCngh+rOV7nqSp93Gg3BZZ6Y4Nz F6MHgO4WBdA8vcG1MEApj6/SheIIZspFm431ls9xJsimHaxgcBoszFt/trgKzncKpZrIEg95Vsg 2P8+eQCg62OPcN5iDd75Ev3MN X-Received: by 2002:a17:906:9482:: with SMTP id t2mr226765ejx.288.1638290243330; Tue, 30 Nov 2021 08:37:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJwJ964kzHM7ECzjQLuyytpD3uMuO0+AkE0lVVFX2mZGdavy6pAp4G8SUw1KrpwTa2NNku+JXg== X-Received: by 2002:a17:906:9482:: with SMTP id t2mr226739ejx.288.1638290243105; Tue, 30 Nov 2021 08:37:23 -0800 (PST) Received: from localhost.localdomain ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id a13sm8722422edk.29.2021.11.30.08.37.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 08:37:22 -0800 (PST) From: christian.ehrhardt@canonical.com To: Thomas Monjalon Cc: Devendra Singh Rawat , Rasesh Mody , dpdk stable Subject: patch 'net/qede: fix minsize build' has been queued to stable release 19.11.11 Date: Tue, 30 Nov 2021 17:33:49 +0100 Message-Id: <20211130163605.2460997-25-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> References: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before December 10th 2021. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/72a15cbd51f11c5a20fd4268c4b9637392af192e Thanks. Christian Ehrhardt --- >From 72a15cbd51f11c5a20fd4268c4b9637392af192e Mon Sep 17 00:00:00 2001 From: Thomas Monjalon Date: Sun, 8 Aug 2021 14:51:34 +0200 Subject: [PATCH] net/qede: fix minsize build MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 11c2e4b41c962414e7183222a6504697493d9433 ] Error occurs when configuring meson with --buildtype=minsize with GCC 11.1.0: In function ‘__internal_ram_wr_relaxed’, inlined from ‘internal_ram_wr’ at ecore_int_api.h:166:2, inlined from ‘qede_update_rx_prod.constprop’ at qede_rxtx.c:736:2: drivers/net/qede/base/bcm_osal.h:136:9: error: ‘rx_prods’ is used uninitialized [-Werror=uninitialized] | rte_write32_relaxed((_val), (_reg_addr)) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ecore_int_api.h:151:17: note: in expansion of macro ‘DIRECT_REG_WR_RELAXED’ | DIRECT_REG_WR_RELAXED(p_hwfn, &((u32 OSAL_IOMEM *)addr)[i], | ^~~~~~~~~~~~~~~~~~~~~ drivers/net/qede/qede_rxtx.c: In function ‘qede_update_rx_prod.constprop’: drivers/net/qede/qede_rxtx.c:724:33: note: ‘rx_prods’ declared here | struct eth_rx_prod_data rx_prods = { 0 }; | ^~~~~~~~ Signed-off-by: Thomas Monjalon Acked-by: Devendra Singh Rawat Acked-by: Rasesh Mody --- drivers/net/qede/qede_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c index 64e6de4743..d45675af89 100644 --- a/drivers/net/qede/qede_rxtx.c +++ b/drivers/net/qede/qede_rxtx.c @@ -717,9 +717,10 @@ qede_update_rx_prod(__rte_unused struct qede_dev *edev, { uint16_t bd_prod = ecore_chain_get_prod_idx(&rxq->rx_bd_ring); uint16_t cqe_prod = ecore_chain_get_prod_idx(&rxq->rx_comp_ring); - struct eth_rx_prod_data rx_prods = { 0 }; + struct eth_rx_prod_data rx_prods; /* Update producers */ + memset(&rx_prods, 0, sizeof(rx_prods)); rx_prods.bd_prod = rte_cpu_to_le_16(bd_prod); rx_prods.cqe_prod = rte_cpu_to_le_16(cqe_prod); -- 2.34.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-30 16:50:07.572544582 +0100 +++ 0025-net-qede-fix-minsize-build.patch 2021-11-30 16:50:05.606872180 +0100 @@ -1 +1 @@ -From 11c2e4b41c962414e7183222a6504697493d9433 Mon Sep 17 00:00:00 2001 +From 72a15cbd51f11c5a20fd4268c4b9637392af192e Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 11c2e4b41c962414e7183222a6504697493d9433 ] + @@ -35 +37 @@ -index 298f4e3e42..35cde561ba 100644 +index 64e6de4743..d45675af89 100644 @@ -38 +40 @@ -@@ -721,9 +721,10 @@ qede_update_rx_prod(__rte_unused struct qede_dev *edev, +@@ -717,9 +717,10 @@ qede_update_rx_prod(__rte_unused struct qede_dev *edev,