From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17401A0C41 for ; Tue, 30 Nov 2021 17:37:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 118B5410F7; Tue, 30 Nov 2021 17:37:36 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 4563F410F7 for ; Tue, 30 Nov 2021 17:37:35 +0100 (CET) Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 252533FFE1 for ; Tue, 30 Nov 2021 16:37:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638290255; bh=UvnZ3nHpvq1LghJtqGygAuIgryvaQrHn7rQWvZqHaJQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bYzb3XmmU0sk2ysM4rKz24hnsM0Dym8gYGimNaFU1v/4myi6zaa8R5L1v1WpIegbn VUMLbNdMcuo91O+5FLK/5ZRUjIGp1k25kKnII6Bjad97ywK92keW1aH9A7lqiSUtu2 8dSaZHSzWwz30KiQW4PUtoY5G9KAAmPJFa9VTNp1ew9QdBM3k50ESOLCzP9TORS/tU Ryq7PRnQnCyrs2s6uZdRRK+Ixgdy3bPz/f6ddu7P0bKfW0tcZCsxwhQWZkl2yoCoBI gNXp3xcs/UUbwrRUe7KGliPF7MigCj87pas4pFJn99mZiigCIU3yXd+gw10kGsEyqH 98WfeBNEl0UtA== Received: by mail-ed1-f71.google.com with SMTP id eg20-20020a056402289400b003eb56fcf6easo17378395edb.20 for ; Tue, 30 Nov 2021 08:37:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UvnZ3nHpvq1LghJtqGygAuIgryvaQrHn7rQWvZqHaJQ=; b=chXsyGYrWz7eVOmHLSgN6MBJKhflXFn/uORw8gxOj3NC2ht/PdMPktK118F8j840Fb 7eK2VQ4EEh3PN3UexZI7FgQHLpJHAuwyh1RW23if1sqiHPrcpM6Pc5qcyPH9HOdL+2DL opwRPfn9onNqQhWWBWAs0p/JastvmH1CYCbvRnDSqKlOj2OWFnVSVpde0im6AymotnPH 6fAUYLU2qBH5p4tJGD1uQ7oBwCLRDr4GQQIwrIoDP5Gt6wgVul9A+/JSLE95YjZnbKLt l0fPwF9nEjPAXaCyKdHjsdqLs9gCNlj0RbmdsSheG43A6r77f0PTDILQcLOvqIL/xj6P CIfw== X-Gm-Message-State: AOAM531lUKwbscOVINNS7Gob9SQlbiE7QCFxTsu5XsJpX0itdLnZSqKd YnxVQn+1nwcPDcV8EflGL+SpIwwdU9/7xAsv8FOrSwyYUBAe2QDF67qe+0Hb+Pe+VONIAOgAnGH cBnL8dKJBhLOmhhQ3GPvSU7X/ X-Received: by 2002:a17:906:4787:: with SMTP id cw7mr171681ejc.311.1638290254545; Tue, 30 Nov 2021 08:37:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJyfgJRVBefuJQ49LUkTHa1rq7fgNzLmfi4HpAmOQXZeL2YPtJKg3Drls4B1fggAqXP3b5YlFA== X-Received: by 2002:a17:906:4787:: with SMTP id cw7mr171668ejc.311.1638290254412; Tue, 30 Nov 2021 08:37:34 -0800 (PST) Received: from localhost.localdomain ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id sd28sm10442587ejc.37.2021.11.30.08.37.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 08:37:34 -0800 (PST) From: christian.ehrhardt@canonical.com To: Ruifeng Wang Cc: Harry van Haaren , dpdk stable Subject: patch 'examples/service_cores: fix lcore count check' has been queued to stable release 19.11.11 Date: Tue, 30 Nov 2021 17:33:50 +0100 Message-Id: <20211130163605.2460997-26-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> References: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before December 10th 2021. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/f07a95e2a9ca39b2871312f3577fd3db2d4c6c70 Thanks. Christian Ehrhardt --- >From f07a95e2a9ca39b2871312f3577fd3db2d4c6c70 Mon Sep 17 00:00:00 2001 From: Ruifeng Wang Date: Mon, 30 Aug 2021 16:04:12 +0800 Subject: [PATCH] examples/service_cores: fix lcore count check [ upstream commit 328720c594f235aa44c78fe360e8e6f31b5e989f ] The example has various profiles to run services on specified number of lcores. Due to incorrect boundary condition, service can be dispatched to a core that does not exist. This puts main core into endless wait. Max available number of service cores is all detected lcores excluding main core. Fixes: 7f6ee6aee717 ("examples/service_cores: check cores before run") Signed-off-by: Ruifeng Wang Acked-by: Harry van Haaren --- examples/service_cores/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/service_cores/main.c b/examples/service_cores/main.c index c5753cc52d..e0cb4f9acb 100644 --- a/examples/service_cores/main.c +++ b/examples/service_cores/main.c @@ -118,7 +118,7 @@ apply_profile(int profile_id) struct profile *p = &profiles[profile_id]; const uint8_t core_off = 1; - if (p->num_cores > rte_lcore_count() + 1) { + if (p->num_cores > rte_lcore_count() - 1) { printf("insufficent cores to run (%s)", p->name); return; -- 2.34.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-30 16:50:07.624678984 +0100 +++ 0026-examples-service_cores-fix-lcore-count-check.patch 2021-11-30 16:50:05.606872180 +0100 @@ -1 +1 @@ -From 328720c594f235aa44c78fe360e8e6f31b5e989f Mon Sep 17 00:00:00 2001 +From f07a95e2a9ca39b2871312f3577fd3db2d4c6c70 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 328720c594f235aa44c78fe360e8e6f31b5e989f ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 83915b9a53..9f52082254 100644 +index c5753cc52d..e0cb4f9acb 100644