From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5EC7A0C41 for ; Tue, 30 Nov 2021 17:39:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A078841177; Tue, 30 Nov 2021 17:39:13 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id F091741190 for ; Tue, 30 Nov 2021 17:39:10 +0100 (CET) Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id D1BFB3FFF1 for ; Tue, 30 Nov 2021 16:39:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638290350; bh=c0GNA7ij9MbUk+wcohxopB6HguaOYFfmpSISyWbESmE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=g8vqClUcXPLqyuzm0RbrU85z6N2AjozYp28oKqwTDZc1dLhgNsJd5YroUwlaXF7qI C7qtiY7iz1UBHkjX8NbGk6Rl3eFwdz9HZwGoIZ0Mf0QevqyuzK2EdGd1GOfny5wmcg fGgOsJwHtScuXLujug89XQdnmNGmCf/BDZ1360+XNBJMQvvnsqyI65C8Ri+yXYAlmg nLywiSwcOHBF+LwYbIb0W9fYAoig/xivP+TjlA8YfwSBzfFjO/oZ5HEGZhWEzFh+WZ Dxi9vlkaPOLme/Sy++RX//3GOzAEnROFLDdqpuYQFJlYqF8kUcPDxdgUuWLpIrALpy Skxmh9ByNmwOg== Received: by mail-ed1-f69.google.com with SMTP id y9-20020aa7c249000000b003e7bf7a1579so17434028edo.5 for ; Tue, 30 Nov 2021 08:39:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=c0GNA7ij9MbUk+wcohxopB6HguaOYFfmpSISyWbESmE=; b=1fLLQJ6H0qBKQeOckmGD9nrajdXzcs1o7hxh+DoTxIsprEI3TIWoMOpTxBiGphajFF 065WTmjCFxlB4mfTU5WpADbP0E8y/0Yq1Sf4e2TPOfXRnNj3GIz2XsOlvAflqr5oCe3r LiIuoehDrkXQnHf41m26SNZAWe7S8AehfKKLFwK5H0zVuK+ZjiJeLIso2yL8IHXen6Bw 43YkIYPytbiXcVYWm8K7NUBAFM0dLAc2XYnc/tVOgTNmnnnKPSDMsrg5Iy18lOb8eiSQ hRCc16oXt03i2Kj7g2VUm0T3mEqg83ZtKy1YFMI2zbnVteMu/YfIVmQYowE7BJBRiiVd 63WQ== X-Gm-Message-State: AOAM533QUlez1R9xCc6l7j/3cNz0SmA7f+KFzeoZph9UuYhDonUR1WXo 6ew22Qw/eGjDWxckgaOb5V/iJqah0GRhQM2P4L8LZ8nImsosni7lLXWoGuHsbWIU8mTeWN6KxiV ROtuXxuhwa37wy+55M3u5iPAo X-Received: by 2002:a17:906:ae48:: with SMTP id lf8mr157158ejb.451.1638290350527; Tue, 30 Nov 2021 08:39:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJyIZBT4xYe36YVe4/cCcj0FKJa90jsYJvSGbXgPm5pazP5E8tHsGX8dL6A8nqA6He3I7XyytQ== X-Received: by 2002:a17:906:ae48:: with SMTP id lf8mr157139ejb.451.1638290350380; Tue, 30 Nov 2021 08:39:10 -0800 (PST) Received: from localhost.localdomain ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id v13sm9034212ejo.36.2021.11.30.08.39.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 08:39:09 -0800 (PST) From: christian.ehrhardt@canonical.com To: Ciara Power Cc: Fan Zhang , dpdk stable Subject: patch 'examples/fips_validation: remove unused allocation' has been queued to stable release 19.11.11 Date: Tue, 30 Nov 2021 17:34:24 +0100 Message-Id: <20211130163605.2460997-60-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> References: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before December 10th 2021. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/688244964296f60dbeb630c607cccfdab79b5b6a Thanks. Christian Ehrhardt --- >From 688244964296f60dbeb630c607cccfdab79b5b6a Mon Sep 17 00:00:00 2001 From: Ciara Power Date: Thu, 12 Aug 2021 14:24:34 +0000 Subject: [PATCH] examples/fips_validation: remove unused allocation [ upstream commit 25d392e1999b3d766f3a9f142372cc1220fa2c97 ] The val.val pointer is allocated memory, however this memory is then freed in get_writeback_data() without being used beforehand. The pointer is then allocated memory again before use, so the very first allocation is removed as it was unnecessary. Fixes: f4797bae0050 ("examples/fips_validation: support plain SHA") Signed-off-by: Ciara Power Acked-by: Fan Zhang --- examples/fips_validation/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c index 2f8238886b..5a4a25cb61 100644 --- a/examples/fips_validation/main.c +++ b/examples/fips_validation/main.c @@ -1373,7 +1373,6 @@ fips_mct_sha_test(void) int ret; uint32_t i, j; - val.val = rte_malloc(NULL, (MAX_DIGEST_SIZE*SHA_MD_BLOCK), 0); for (i = 0; i < SHA_MD_BLOCK; i++) md[i].val = rte_malloc(NULL, (MAX_DIGEST_SIZE*2), 0); -- 2.34.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-30 16:50:09.493265796 +0100 +++ 0060-examples-fips_validation-remove-unused-allocation.patch 2021-11-30 16:50:05.726873060 +0100 @@ -1 +1 @@ -From 25d392e1999b3d766f3a9f142372cc1220fa2c97 Mon Sep 17 00:00:00 2001 +From 688244964296f60dbeb630c607cccfdab79b5b6a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 25d392e1999b3d766f3a9f142372cc1220fa2c97 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index a8daad1f48..c0e68b8848 100644 +index 2f8238886b..5a4a25cb61 100644 @@ -24 +25 @@ -@@ -1632,7 +1632,6 @@ fips_mct_sha_test(void) +@@ -1373,7 +1373,6 @@ fips_mct_sha_test(void)