From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF0D5A0C41 for ; Tue, 30 Nov 2021 17:39:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DFF7D410F7; Tue, 30 Nov 2021 17:39:25 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id C2E12410F7 for ; Tue, 30 Nov 2021 17:39:23 +0100 (CET) Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 9D22F4000A for ; Tue, 30 Nov 2021 16:39:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638290363; bh=MP5TFxWaedVx2hjydvgFZiHSCWwwfYdcXkYM2GwRmnw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JnC5lNd/C9X3V8YWkv8oL+P/SfUaocIqwJw1EBpmnW6xbbIcFnby31wibOnvw8naD e26rL4MRduuinUHeTPl0qDr8CfCbJ3vOraw6BhtKy+P/f2j6BZG6HCjXluJ9JxiF2W lXXEfMfrqcjsMFGpEP5rIFdhVui+ZkYxVnlwKPFOAUzmeyVxPEs8HxNRDUu9SIHZwk cbSAuiuMx++NwyPRiPDpDc7Jah2xL6go8/z4dElCgcZAIEeMaNK6N+pRYjFaS/F0c4 b8BjO1t+r0dx/jmQJ5qI0Zj0sKYAdV50SZc2cJROkNLzkdPNncpOvc2qbflrs143kc Ny4DBvxa5swSA== Received: by mail-ed1-f72.google.com with SMTP id m12-20020a056402430c00b003e9f10bbb7dso17437508edc.18 for ; Tue, 30 Nov 2021 08:39:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MP5TFxWaedVx2hjydvgFZiHSCWwwfYdcXkYM2GwRmnw=; b=t55cc9HslZdMEwQq13gzEWCZzP/p04OCrjDuOyneYNFgEEGMYWeRHagnSGfxZRKE+W 9ibMWMVpvooR1c9KTDTlS7O8rG1d5iht7hiTK1+CXfvygniROYTUs6NwkHb9QTEucVmX JSbdllWNxmF663ljE4JWXWrhViy2IzsShw88n2hAhLrHBARNTurXnYEOqA67wyXx41ca IZSpa2VE3gdjhMkMmoXlFfO6PTbnR8eEByRfDs8nWc+F9oPwlKpzAvvGULgc5wvo9Ycx JVfE2aHVoJxPDCwj2BJD/xLsKooL+hfX+Es0fMrDu21XQeY+zBGKAP6Sp9LAWTOFyfEJ 47bg== X-Gm-Message-State: AOAM530UV4a8jR9MVXxX+zT8dnrqNBeKax56UubUBJzAEXFVu+xhqxM0 xzNZJTA8D1s/jw5fsGDwFISNlaeNc9OiFiKTOKQ7P4kr21TXRGFIaVkAPBXBdUhHMM2abwhED1W FOYN1pNTjOqQIEznRn3xU+gQp X-Received: by 2002:a05:6402:4249:: with SMTP id g9mr91093edb.316.1638290362956; Tue, 30 Nov 2021 08:39:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJzSv99qiu2cuxrlIe/Tjqli05ZH5oL3Af5JUzU5QHcI4/d4Um5nC5x5DIF70laPURZxu5nhaA== X-Received: by 2002:a05:6402:4249:: with SMTP id g9mr91073edb.316.1638290362841; Tue, 30 Nov 2021 08:39:22 -0800 (PST) Received: from localhost.localdomain ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id f7sm11590549edw.44.2021.11.30.08.39.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 08:39:22 -0800 (PST) From: christian.ehrhardt@canonical.com To: Joyce Kong Cc: Ruifeng Wang , Harry van Haaren , dpdk stable Subject: patch 'test/service: fix some comment' has been queued to stable release 19.11.11 Date: Tue, 30 Nov 2021 17:34:26 +0100 Message-Id: <20211130163605.2460997-62-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> References: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before December 10th 2021. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/1bb03e0139635d74d3035da64b925f9998fb2fc0 Thanks. Christian Ehrhardt --- >From 1bb03e0139635d74d3035da64b925f9998fb2fc0 Mon Sep 17 00:00:00 2001 From: Joyce Kong Date: Thu, 19 Aug 2021 01:11:25 -0500 Subject: [PATCH] test/service: fix some comment [ upstream commit 79afbbfeea44f624242ad93c28072d73da631e1b ] Change the inaccurate comment of 'set pass flag' to 'clear pass flag' as the '*pass_test = 0' code actually implements clearing. Fixes: f038a81e1c56 ("service: add unit tests") Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Acked-by: Harry van Haaren --- app/test/test_service_cores.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_service_cores.c b/app/test/test_service_cores.c index 2a4978e29a..2a52c1d452 100644 --- a/app/test/test_service_cores.c +++ b/app/test/test_service_cores.c @@ -66,7 +66,7 @@ static int32_t dummy_mt_unsafe_cb(void *args) rte_delay_ms(250); rte_atomic32_clear((rte_atomic32_t *)atomic_lock); } else { - /* 2nd thread will fail to take lock, so set pass flag */ + /* 2nd thread will fail to take lock, so clear pass flag */ *pass_test = 0; } -- 2.34.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-30 16:50:09.598234200 +0100 +++ 0062-test-service-fix-some-comment.patch 2021-11-30 16:50:05.730873089 +0100 @@ -1 +1 @@ -From 79afbbfeea44f624242ad93c28072d73da631e1b Mon Sep 17 00:00:00 2001 +From 1bb03e0139635d74d3035da64b925f9998fb2fc0 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 79afbbfeea44f624242ad93c28072d73da631e1b ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index ece104054e..8659a1526c 100644 +index 2a4978e29a..2a52c1d452 100644 @@ -23 +24 @@ -@@ -68,7 +68,7 @@ static int32_t dummy_mt_unsafe_cb(void *args) +@@ -66,7 +66,7 @@ static int32_t dummy_mt_unsafe_cb(void *args) @@ -25 +26 @@ - __atomic_store_n(lock, 0, __ATOMIC_RELAXED); + rte_atomic32_clear((rte_atomic32_t *)atomic_lock);