From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8A78A0C41 for ; Tue, 30 Nov 2021 17:39:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9475141148; Tue, 30 Nov 2021 17:39:39 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 7DC8F41148 for ; Tue, 30 Nov 2021 17:39:38 +0100 (CET) Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 51D8E3F044 for ; Tue, 30 Nov 2021 16:39:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638290378; bh=jkxCdTXbLsAMANFNirDBRahbCZaEpKLyGevFd5My6uc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=TE1Hvnw9knh2inH4+fXSNH0AU5cwIUV4KjbXmkjmeqmx1rukCoByKHJ/GG2RpW1cF HNvJ+aV/i7s2YKZVcfh2cOQElECeEWT500K03jH8eFISTxs7YDrFLigcCbtAIhgLuU srEb58G0Ful594A42IebM2qq61S+okA/W0ghHH2cDyK5vdoIH9zOoNZ+kRnOzsx1bt x8ioFfDiAZQdqpjBR1LiVGSqqRxPoyr90rogTwRet+HQx6VOzNwqo++a9deKMLGWP3 N8TobkQr4SLjtmFo2I51ryhLZ50iWFtPgz1Q9aSyyHXa9Rt/EOyFrQnYL92JF85B2b ay6FdC8r6Dtkg== Received: by mail-ed1-f71.google.com with SMTP id p4-20020aa7d304000000b003e7ef120a37so17401299edq.16 for ; Tue, 30 Nov 2021 08:39:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jkxCdTXbLsAMANFNirDBRahbCZaEpKLyGevFd5My6uc=; b=y3jwqfwm/MgFAE+ggLy8xh8isbazMGqW12fZBJt2LaaRq0ZbNhOWN6ofXqt4+OHlCN C4exRdhngI9CZuE5uJzTY3NvFbktaqhF1oUGr8Tf22N9Pb002UYvbRf6oYXPEgOomQfv vXJhZyi09XKsMX/1zHx6U+8pGsUhRfZkqq7vc5Zi7pg6pMVrBXSk3hBEm2m+JWbpNHPF xbta6FMloqorhyAkJmMrGosLY+7hN8dXVpPvBSue9xMhFamG1gFFcXXh9SSvriRrVbXW NkKtlFNesoiuxJTw1RCYX7QKYDvwq/WR2O8vHkiuHvdnbpPIl8CKn+tpb7wFhCecaKdl 13Mg== X-Gm-Message-State: AOAM532YFrMfoAlYH6guAiVS9jXYQ8aE3oyCCN7ehIjYkC6fV9/G7t82 QHPXvquc/zNMrq1UQKnihc4hSX91b9JQ7+a4pBXRVLiAxN2mzRu90mxQPuaExMikh6HWRk7LgqS tDVVgglmrleI12TyRfwyAWR80 X-Received: by 2002:aa7:dc07:: with SMTP id b7mr11549edu.327.1638290377879; Tue, 30 Nov 2021 08:39:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJxAwHdn+90mrpGtsgIF3/VMyoe2XyPFQVMDsaWkniui71jRsaQjLjf9mzTirQmbvCo/Ekn7MQ== X-Received: by 2002:aa7:dc07:: with SMTP id b7mr11526edu.327.1638290377731; Tue, 30 Nov 2021 08:39:37 -0800 (PST) Received: from localhost.localdomain ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id cs12sm9456701ejc.15.2021.11.30.08.39.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 08:39:37 -0800 (PST) From: christian.ehrhardt@canonical.com To: David Christensen Cc: Ruifeng Wang , dpdk stable Subject: patch 'test/atomic: fix 128-bit atomic test with many cores' has been queued to stable release 19.11.11 Date: Tue, 30 Nov 2021 17:34:31 +0100 Message-Id: <20211130163605.2460997-67-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> References: <20211130163605.2460997-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before December 10th 2021. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/c43649313a202a7b8d4fc10f12ffe5db2246d34f Thanks. Christian Ehrhardt --- >From c43649313a202a7b8d4fc10f12ffe5db2246d34f Mon Sep 17 00:00:00 2001 From: David Christensen Date: Wed, 8 Sep 2021 10:48:20 -0700 Subject: [PATCH] test/atomic: fix 128-bit atomic test with many cores [ upstream commit 17a042376be17f6c615b93b189a53eaca1b8bd48 ] When checking the results of the rte_atomic128_cmp_exchange() function, current code compares the values of a uint32_t and a uint64_t variable. If the number of lcores used by the test is large, or the value of the iteration count N is increased, the variable size mismatch can cause a false test failure. Modify the comparison to compare uint64_t values. Fixes: fa3253c534b1 ("test/atomic: add 128-bit atomic compare exchange test") Signed-off-by: David Christensen Tested-by: Ruifeng Wang Reviewed-by: Ruifeng Wang --- app/test/test_atomic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_atomic.c b/app/test/test_atomic.c index de3030d221..91ee29c004 100644 --- a/app/test/test_atomic.c +++ b/app/test/test_atomic.c @@ -591,7 +591,7 @@ test_atomic(void) rte_atomic32_clear(&synchro); iterations = count128.val[0] - count128.val[1]; - if (iterations != 4*N*(rte_lcore_count()-1)) { + if (iterations != (uint64_t)4*N*(rte_lcore_count()-1)) { printf("128-bit compare and swap failed\n"); return -1; } -- 2.34.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-11-30 16:50:09.844791658 +0100 +++ 0067-test-atomic-fix-128-bit-atomic-test-with-many-cores.patch 2021-11-30 16:50:05.738873149 +0100 @@ -1 +1 @@ -From 17a042376be17f6c615b93b189a53eaca1b8bd48 Mon Sep 17 00:00:00 2001 +From c43649313a202a7b8d4fc10f12ffe5db2246d34f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 17a042376be17f6c615b93b189a53eaca1b8bd48 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index f10f555af8..ce0c259bd7 100644 +index de3030d221..91ee29c004 100644