From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3132BA0C4C for ; Wed, 1 Dec 2021 08:26:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 023E64067B; Wed, 1 Dec 2021 08:26:01 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2084.outbound.protection.outlook.com [40.107.92.84]) by mails.dpdk.org (Postfix) with ESMTP id 553004067B for ; Wed, 1 Dec 2021 08:26:00 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YbVZKO1qHM4fennRsL2buluN5huBOa/z7SP8/KLwkmgfQDS2HWUE8TyeoK82Hqt/LIJBbQCih1LudWXAC9XwbzbhNbYKfJ3GmhWGKIJVDt8FSqMi8ITPH4HsBYOeBIIFMTtpEfl6L64d47batMt/1Fh49rmaKVkdtw3Z3ON0eG/6ivklDQnYJwxeqPSUDWJSX/kciL5iD+FbSjLucYcA8/FhNht5rSEtDUWdfX0hra9TfCnBZGcendpttISxSB9sLgrOqL7lt8CpKuB1DQPiHrI4ATbxZQtCffDYGm3DbS1hV87kQxJqW5SBZGUVZiVZ9wLgxE8avvUtKKQ9InUf0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CtrUIOC+j/bj4zBkkfTN4AAGqgBBAkDCyxwqN/aelrk=; b=FnC1qyuv/u7DGJqghDhURukedQ8qo+pn+HLcdsjcQNqfZufrQuDRw+LvjTjmJ5tgYT4NYvjsFBmePMgIVQvYO3IfKBNepd5W154grcqnyiFLwtKMRiiksSrM7aCwI0huJ6T1dAl4ERO7DYYlnfDU2+KtN80amjRT4Zptm+bgv4U9oBFbwpG8boEU5TJein+KKBPa5mk4N8Elbmz0XoLuGfN1BYmh4kQSh9Byn0YaU0k4xImlUBvk9wm1zOJrOYSRCrcEmKUpReJN/ueIYcC01QYlskAfBjEpMHwRxbis+cOoVu5x9UKN6a4/+0mhEZQfSy8FZUv8x8fzL7767rHmyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=canonical.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CtrUIOC+j/bj4zBkkfTN4AAGqgBBAkDCyxwqN/aelrk=; b=tAv0AOFVyjlKjR6i68/1AlVBXb5UwVBQSFhVb3E9tf8+kXtL8/PT0qUBlLlFZQybi2OiUDCBuIBOn6KUAea3gfd0Kr/5h2eWdhV5yVcFY6XJIIHB6iMeH/FWZUAuZrRNGHq5NlvHxQwoBY5Om5CcH+9Ke37z7Sk4s6V9D+EGoQjikrlw58H/vt/N0VJORdSubth8vvWuYAvayVgBchQU1D5ZnQ3SnkPmni1qUaaLDcE8VtiOsHT/GLMwd0ESgo6PlFhDkICFjKD2Y7lL53twQeLOjX2vekIf6wI/GpwuTSEdp9xDiV8gK13jVVZcFQzg/Uopsf4avwaWf6Gn/sqtzg== Received: from MW4PR04CA0295.namprd04.prod.outlook.com (2603:10b6:303:89::30) by BL0PR12MB2483.namprd12.prod.outlook.com (2603:10b6:207:4c::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Wed, 1 Dec 2021 07:25:57 +0000 Received: from CO1NAM11FT035.eop-nam11.prod.protection.outlook.com (2603:10b6:303:89:cafe::f5) by MW4PR04CA0295.outlook.office365.com (2603:10b6:303:89::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23 via Frontend Transport; Wed, 1 Dec 2021 07:25:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT035.mail.protection.outlook.com (10.13.175.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4755.13 via Frontend Transport; Wed, 1 Dec 2021 07:25:56 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 1 Dec 2021 07:25:56 +0000 Received: from nvidia.com (172.20.187.5) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.986.9; Tue, 30 Nov 2021 23:25:54 -0800 From: Eli Britstein To: CC: Matan Azrad , Ferruh Yigit , , Eli Britstein Subject: [PATCH 19.11] app/testpmd: fix packet burst spreading stats Date: Wed, 1 Dec 2021 09:25:20 +0200 Message-ID: <20211201072520.11808-1-elibr@nvidia.com> X-Mailer: git-send-email 2.18.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 430d5aa1-ee38-44f4-4f69-08d9b49bd105 X-MS-TrafficTypeDiagnostic: BL0PR12MB2483: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:913; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NAb6bA8liN9M0llTp5abg/SpKYstpRrgv/dbnsNEx+4ivdEANYrYg7IkgRlRqCwnxPbp6ItKUiN2leqaAZUdA1CwnniwZBGSPgM0m0HkklFXSSUee7HvaQf983i3Df8PEogTKiuRfEOWM8aPqy0ZnuFxw4qg+4tlmAidiOolDyUoKCUIEsCJZ1lUO6oILK+5PH6oTtpv9/5epYO2CqY6dnKcUJqDDHmgJyf1TJw7RO6D707jcOxDqI6mn0zNqgXFDlo2o2oVAH+6q3jTVqCm6fHEfYy4k8VefOU0xhrzptE/qb5jvrgwEwkZDt8kHn2inCij75viA6JM9CQ1cBmrhY8byvMJSGFl3RmRcHsx7GwyeohNEUoLlGJpfEM4ojZ1OrIo7G/e1fIqbcYcajRcBj2z9Y/3KN3r5u0q+SG8sXafld7+/ZSwz3M+iOhcMWAg8rkELizbQxLvlMn+gUhLPmtvyIXP1cUTw8gUbuNgzulC87X7mZLBr1UJQnR5QgZt5SAcQ476ADP/yUDjUA0yhzVxkT1wjMiXEV7IZbm+dNCqGjFkn3Lzv+M0R6X3LVth8uG1N1JPuWels3Q1lsoGIS36vr2gdHR8NPByRoPcDUJFCEN982f42lN+/VvVpy9AxRKq3XdnKSPA4flR2TdvgkohEEKm3tGkqOtg1LvxwS114zckqTym82lwKqL8HHOiiuVpfIUb9LTnaedCZbK5xk5kWfu3uyT3qL1Ev1zo4GjrscBx8+A62UvkDUCcU7GfYt7jAgXuTBkr0cJ6EyyMgA== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(40470700001)(5660300002)(186003)(316002)(508600001)(8936002)(356005)(6666004)(6916009)(16526019)(336012)(2616005)(426003)(36756003)(8676002)(4326008)(26005)(2906002)(83380400001)(82310400004)(55016003)(70586007)(7636003)(54906003)(70206006)(1076003)(6286002)(47076005)(36860700001)(40460700001)(86362001)(7696005)(107886003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 07:25:56.8258 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 430d5aa1-ee38-44f4-4f69-08d9b49bd105 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT035.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB2483 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org [ upstream commit 6a8b64fd5e9e8f5572ea4d9de40a1cff23498246 ] RX/TX functions (rte_eth_rx_burst/rte_eth_tx_burst) get 'nb_pkts' argument, which specifies the maximum number to receive/transmit. It can be 0..nb_pkts, meaning nb_pkts+1 options. Testpmd can provide statistics of the burst sizes ('set record-burst-stats on') by incrementing an array cell of index . This array is mistakenly [MAX_PKT_BURST] size. Receiving the maximum burst will cause out of bound write. Enlarge the spread stats array by one cell to fix it. Fixes: af75078fece3 ("first public release") Signed-off-by: Eli Britstein Reviewed-by: Matan Azrad Acked-by: Ferruh Yigit --- app/test-pmd/testpmd.c | 2 +- app/test-pmd/testpmd.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index bd15fe9e53..f4a54102ca 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1605,7 +1605,7 @@ pkt_burst_stats_display(const char *rx_tx, struct pkt_burst_stats *pbs) total_burst = 0; burst_stats[0] = burst_stats[1] = burst_stats[2] = 0; pktnb_stats[0] = pktnb_stats[1] = pktnb_stats[2] = 0; - for (nb_pkt = 0; nb_pkt < MAX_PKT_BURST; nb_pkt++) { + for (nb_pkt = 0; nb_pkt < MAX_PKT_BURST + 1; nb_pkt++) { nb_burst = pbs->pkt_burst_spread[nb_pkt]; if (nb_burst == 0) continue; diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index bbe18a7191..334bcc28e6 100644 --- a/app/test-pmd/testpmd.h +++ b/app/test-pmd/testpmd.h @@ -86,7 +86,7 @@ enum { * that are recorded for each forwarding stream. */ struct pkt_burst_stats { - unsigned int pkt_burst_spread[MAX_PKT_BURST]; + unsigned int pkt_burst_spread[MAX_PKT_BURST + 1]; }; #endif -- 2.28.0.2311.g225365fb51