patches for DPDK stable branches
 help / color / mirror / Atom feed
From: christian.ehrhardt@canonical.com
To: stable@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
	Luca Boccassi <bluca@debian.org>,
	Xueming Li <xuemingl@nvidia.com>,
	David Marchand <david.marchand@redhat.com>,
	Kevin Traynor <ktraynor@redhat.com>,
	Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Subject: [PATCH 1/2] devtools: don't include headline "fix" in backports
Date: Fri,  3 Dec 2021 08:51:22 +0100	[thread overview]
Message-ID: <20211203075123.4081128-1-christian.ehrhardt@canonical.com> (raw)

From: Christian Ehrhardt <christian.ehrhardt@canonical.com>

It was important in the past to select anything with "fix" in the
headline, but recently more often created false positives and work
to sort tihngs out than identifying many helpful patches.

The community and processes aroudn DPDK matured enough that developers
(rightfully) expect to rely on "Fixes:" and "stable@" marking for
backprots.

Therefore do no more include patches that just include the word fix
in the backport candidate list.

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
---
 devtools/git-log-fixes.sh | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh
index 210c8dcf25..27ec9088d4 100755
--- a/devtools/git-log-fixes.sh
+++ b/devtools/git-log-fixes.sh
@@ -13,7 +13,7 @@ print_help ()
 	cat <<- END_OF_HELP
 
 	Find fixes to backport on previous versions.
-	It looks for the word "fix" in the headline or a tag "Fixes" or "Reverts".
+	It looks for a tag "Fixes" or "Reverts" and for recipient stable@dpdk.org.
 	The oldest bug origin is printed as well as partially fixed versions.
 	END_OF_HELP
 }
@@ -109,8 +109,7 @@ while read id headline ; do
 	origins=$(origin_filter $id)
 	stable=$(stable_tag $id)
 	fixes=$(fixes_tag $id)
-	[ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || \
-		echo "$headline" | grep -q fix || continue
+	[ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || continue
 	version=$(commit_version $id)
 	if [ -n "$origins" ] ; then
 		origver="$(origin_version $origins)"
-- 
2.34.0


             reply	other threads:[~2021-12-03  7:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-03  7:51 christian.ehrhardt [this message]
2021-12-03  7:51 ` [PATCH 2/2] devtools: report commit id on partial fixes christian.ehrhardt
2021-12-03  7:53   ` Christian Ehrhardt
2021-12-03  7:53 ` [PATCH 1/2] devtools: don't include headline "fix" in backports Christian Ehrhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211203075123.4081128-1-christian.ehrhardt@canonical.com \
    --to=christian.ehrhardt@canonical.com \
    --cc=bluca@debian.org \
    --cc=david.marchand@redhat.com \
    --cc=ktraynor@redhat.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=xuemingl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).