From: Michal Krawczyk <mk@semihalf.com>
To: stable@dpdk.org
Cc: christian.ehrhardt@canonical.com, Michal Krawczyk <mk@semihalf.com>
Subject: [PATCH 19.11 4/4] Revert "net/ena: trigger reset on Tx prepare failure"
Date: Fri, 3 Dec 2021 16:08:59 +0100 [thread overview]
Message-ID: <20211203150859.3933-4-mk@semihalf.com> (raw)
In-Reply-To: <20211203150859.3933-1-mk@semihalf.com>
This reverts commit 91867d8536914374062693fd5fddc08ae267a41f.
ENA Tx logic in the DPDK v19.11 is a bit different than the one from
which the original commit was backported (DPDK v21.08). As calculations
of the available ring size is not very precise, ena_com_prepare_tx()
function can fail because the ring is full - it's not a fault in the
current logic, so it shouldn't print error logs nor trigger the device
reset.
Signed-off-by: Michal Krawczyk <mk@semihalf.com>
---
drivers/net/ena/ena_ethdev.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index 62c15f3c9..8f02ecde1 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -2533,12 +2533,7 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
rc = ena_com_prepare_tx(tx_ring->ena_com_io_sq,
&ena_tx_ctx, &nb_hw_desc);
if (unlikely(rc)) {
- PMD_DRV_LOG(ERR,
- "Failed to prepare Tx buffers, rc: %d\n", rc);
++tx_ring->tx_stats.prepare_ctx_err;
- tx_ring->adapter->reset_reason =
- ENA_REGS_RESET_DRIVER_INVALID_STATE;
- tx_ring->adapter->trigger_reset = true;
break;
}
tx_info->tx_descs = nb_hw_desc;
--
2.25.1
next prev parent reply other threads:[~2021-12-03 15:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 15:08 [PATCH 19.11 1/4] net/ena: fix offload capabilities verification Michal Krawczyk
2021-12-03 15:08 ` [PATCH 19.11 2/4] net/ena: fix per-queue offload capabilities Michal Krawczyk
2021-12-03 15:08 ` [PATCH 19.11 3/4] net/ena: advertise scattered Rx capability Michal Krawczyk
2021-12-03 15:08 ` Michal Krawczyk [this message]
2021-12-06 8:31 ` [PATCH 19.11 4/4] Revert "net/ena: trigger reset on Tx prepare failure" Christian Ehrhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211203150859.3933-4-mk@semihalf.com \
--to=mk@semihalf.com \
--cc=christian.ehrhardt@canonical.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).