[PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang 13

[PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang 13

[Haiyue Wang]

Disable the -Wunused-but-set-variable option for clang to avoid
compile warning.

Bugzilla ID: 900

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
 drivers/net/ixgbe/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile
index 31523025b3..31a418a2c6 100644
--- a/drivers/net/ixgbe/Makefile
+++ b/drivers/net/ixgbe/Makefile
@@ -29,6 +29,7 @@ else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
 #
 CFLAGS_BASE_DRIVER = -Wno-unused-parameter -Wno-unused-value
 CFLAGS_BASE_DRIVER += -Wno-strict-aliasing -Wno-format-extra-args
+CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
 
 else
 #
-- 
2.34.1

[PATCH 19.11 v1 2/3] net/i40e: build failure with make and clang 13

[Haiyue Wang]

Disable the -Wunused-but-set-variable option for clang to avoid
compile warning.

Bugzilla ID: 901

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
 drivers/net/i40e/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/i40e/Makefile b/drivers/net/i40e/Makefile
index 4ea58bd9e7..d6ced28f3d 100644
--- a/drivers/net/i40e/Makefile
+++ b/drivers/net/i40e/Makefile
@@ -35,6 +35,7 @@ CFLAGS_BASE_DRIVER += -Wno-missing-field-initializers
 CFLAGS_BASE_DRIVER += -Wno-pointer-to-int-cast
 CFLAGS_BASE_DRIVER += -Wno-format-nonliteral
 CFLAGS_BASE_DRIVER += -Wno-unused-variable
+CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
 else
 CFLAGS_BASE_DRIVER  = -Wno-sign-compare
 CFLAGS_BASE_DRIVER += -Wno-unused-value
-- 
2.34.1

[PATCH 19.11 v1 3/3] net/ice: build failure with make and clang 13

[Haiyue Wang]

Disable the -Wunused-but-set-variable option for clang to avoid
compile warning.

Bugzilla ID: 902

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
 drivers/net/ice/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ice/Makefile b/drivers/net/ice/Makefile
index 6c4d155268..370b33af60 100644
--- a/drivers/net/ice/Makefile
+++ b/drivers/net/ice/Makefile
@@ -26,6 +26,7 @@ CFLAGS_BASE_DRIVER +=
 else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
 CFLAGS_BASE_DRIVER += -Wno-unused-parameter
 CFLAGS_BASE_DRIVER += -Wno-unused-variable
+CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
 else
 CFLAGS_BASE_DRIVER += -Wno-unused-parameter
 CFLAGS_BASE_DRIVER += -Wno-unused-variable
-- 
2.34.1

RE: [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang 13

[Ali Alnubani]

> -----Original Message-----
> From: Haiyue Wang <haiyue.wang@intel.com>
> Sent: Tuesday, December 14, 2021 6:30 PM
> To: stable@dpdk.org
> Cc: christian.ehrhardt@canonical.com; yux.jiang@intel.com;
> qi.z.zhang@intel.com; Haiyue Wang <haiyue.wang@intel.com>; Wenzhuo Lu
> <wenzhuo.lu@intel.com>; Konstantin Ananyev
> <konstantin.ananyev@intel.com>
> Subject: [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang 13
> 
> Disable the -Wunused-but-set-variable option for clang to avoid
> compile warning.
> 
> Bugzilla ID: 900

Do you mean "Bugzilla ID: 903"?
https://bugs.dpdk.org/show_bug.cgi?id=900 is a net/nfp build failure.

> 
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
>  drivers/net/ixgbe/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile
> index 31523025b3..31a418a2c6 100644
> --- a/drivers/net/ixgbe/Makefile
> +++ b/drivers/net/ixgbe/Makefile
> @@ -29,6 +29,7 @@ else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
>  #
>  CFLAGS_BASE_DRIVER = -Wno-unused-parameter -Wno-unused-value
>  CFLAGS_BASE_DRIVER += -Wno-strict-aliasing -Wno-format-extra-args
> +CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
> 
>  else
>  #
> --
> 2.34.1

Thanks Haiyue for looking into this.
I no longer see the build failures in Bugzilla tickets 901/902/903, but I now see similar build errors in net/qede and net/sfc.

RE: [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang 13

[Wang, Haiyue]

> -----Original Message-----
> From: Ali Alnubani <alialnu@nvidia.com>
> Sent: Wednesday, December 15, 2021 01:23
> To: Wang, Haiyue <haiyue.wang@intel.com>; stable@dpdk.org
> Cc: christian.ehrhardt@canonical.com; Jiang, YuX <yux.jiang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>
> Subject: RE: [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang 13
> 
> > -----Original Message-----
> > From: Haiyue Wang <haiyue.wang@intel.com>
> > Sent: Tuesday, December 14, 2021 6:30 PM
> > To: stable@dpdk.org
> > Cc: christian.ehrhardt@canonical.com; yux.jiang@intel.com;
> > qi.z.zhang@intel.com; Haiyue Wang <haiyue.wang@intel.com>; Wenzhuo Lu
> > <wenzhuo.lu@intel.com>; Konstantin Ananyev
> > <konstantin.ananyev@intel.com>
> > Subject: [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang 13
> >
> > Disable the -Wunused-but-set-variable option for clang to avoid
> > compile warning.
> >
> > Bugzilla ID: 900
> 
> Do you mean "Bugzilla ID: 903"?

My typo fault, yes, 903. will send v2.

> https://bugs.dpdk.org/show_bug.cgi?id=900 is a net/nfp build failure.
> 
> >
> > Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> > ---
> >  drivers/net/ixgbe/Makefile | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile
> > index 31523025b3..31a418a2c6 100644
> > --- a/drivers/net/ixgbe/Makefile
> > +++ b/drivers/net/ixgbe/Makefile
> > @@ -29,6 +29,7 @@ else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
> >  #
> >  CFLAGS_BASE_DRIVER = -Wno-unused-parameter -Wno-unused-value
> >  CFLAGS_BASE_DRIVER += -Wno-strict-aliasing -Wno-format-extra-args
> > +CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
> >
> >  else
> >  #
> > --
> > 2.34.1
> 
> Thanks Haiyue for looking into this.
> I no longer see the build failures in Bugzilla tickets 901/902/903, but I now see similar build errors
> in net/qede and net/sfc.

Re: [PATCH 19.11 v1 2/3] net/i40e: build failure with make and clang 13

[Christian Ehrhardt]

On Tue, Dec 14, 2021 at 6:03 PM Haiyue Wang <haiyue.wang@intel.com> wrote:
>
> Disable the -Wunused-but-set-variable option for clang to avoid
> compile warning.
>
> Bugzilla ID: 901

Same as I said on the other two patches of the series applies here.
I'll apply all three and do some test runs checking which errors are left.
Thanks!

> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
>  drivers/net/i40e/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/i40e/Makefile b/drivers/net/i40e/Makefile
> index 4ea58bd9e7..d6ced28f3d 100644
> --- a/drivers/net/i40e/Makefile
> +++ b/drivers/net/i40e/Makefile
> @@ -35,6 +35,7 @@ CFLAGS_BASE_DRIVER += -Wno-missing-field-initializers
>  CFLAGS_BASE_DRIVER += -Wno-pointer-to-int-cast
>  CFLAGS_BASE_DRIVER += -Wno-format-nonliteral
>  CFLAGS_BASE_DRIVER += -Wno-unused-variable
> +CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
>  else
>  CFLAGS_BASE_DRIVER  = -Wno-sign-compare
>  CFLAGS_BASE_DRIVER += -Wno-unused-value
> --
> 2.34.1
>


-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

Re: [PATCH 19.11 v1 3/3] net/ice: build failure with make and clang < 13

[Christian Ehrhardt]

On Mon, Dec 20, 2021 at 12:21 PM Haiyue Wang <haiyue.wang@intel.com> wrote:
>
> Check the clang version before enabling '-Wno-unused-but-set-variable',
> otherwise it will have "error: unknown warning option".

Thanks, Queued for 19.11.11 as it improves some other recently added
compiler fixes and we'd want to avoid those breaking older clang
builds.

> https://reviews.llvm.org/D100581
>
> Bugzilla ID: 913
>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
>  drivers/net/ice/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ice/Makefile b/drivers/net/ice/Makefile
> index 370b33af60..9cfd059781 100644
> --- a/drivers/net/ice/Makefile
> +++ b/drivers/net/ice/Makefile
> @@ -26,7 +26,9 @@ CFLAGS_BASE_DRIVER +=
>  else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
>  CFLAGS_BASE_DRIVER += -Wno-unused-parameter
>  CFLAGS_BASE_DRIVER += -Wno-unused-variable
> +ifeq ($(shell test $(CLANG_MAJOR_VERSION) -ge 13 && echo 1), 1)
>  CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
> +endif
>  else
>  CFLAGS_BASE_DRIVER += -Wno-unused-parameter
>  CFLAGS_BASE_DRIVER += -Wno-unused-variable
> --
> 2.34.1
>


-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

[PATCH 19.11 v1 3/3] net/ice: build failure with make and clang < 13

[Haiyue Wang]

Check the clang version before enabling '-Wno-unused-but-set-variable',
otherwise it will have "error: unknown warning option".

https://reviews.llvm.org/D100581

Bugzilla ID: 913

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
 drivers/net/ice/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ice/Makefile b/drivers/net/ice/Makefile
index 370b33af60..9cfd059781 100644
--- a/drivers/net/ice/Makefile
+++ b/drivers/net/ice/Makefile
@@ -26,7 +26,9 @@ CFLAGS_BASE_DRIVER +=
 else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
 CFLAGS_BASE_DRIVER += -Wno-unused-parameter
 CFLAGS_BASE_DRIVER += -Wno-unused-variable
+ifeq ($(shell test $(CLANG_MAJOR_VERSION) -ge 13 && echo 1), 1)
 CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
+endif
 else
 CFLAGS_BASE_DRIVER += -Wno-unused-parameter
 CFLAGS_BASE_DRIVER += -Wno-unused-variable
-- 
2.34.1