patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Jerin Jacob <jerinjacobk@gmail.com>, Gaoxiang Liu <gaoxiangliu0@163.com>
Cc: dpdk-dev <dev@dpdk.org>,
	Anatoly Burakov <anatoly.burakov@intel.com>,
	liugaoxiang@huawei.com, dpdk stable <stable@dpdk.org>
Subject: Re: [PATCH v3] eal: allow to exclude memseg from core dump
Date: Wed, 15 Dec 2021 17:34:55 +0300	[thread overview]
Message-ID: <20211215173455.6e688519@sovereign> (raw)
In-Reply-To: <CALBAE1Mz9b9ZaTYo7yTmXHJKWEJetcDLTy90rhJQiYj=Ot9mHw@mail.gmail.com>

2021-12-15 17:36 (UTC+0530), Jerin Jacob:
[...]
> > diff --git a/lib/eal/unix/eal_unix_memory.c b/lib/eal/unix/eal_unix_memory.c
> > index 68ae93bd6e..44227aee95 100644
> > --- a/lib/eal/unix/eal_unix_memory.c
> > +++ b/lib/eal/unix/eal_unix_memory.c
> > @@ -83,10 +83,13 @@ eal_mem_set_dump(void *virt, size_t size, bool dump)
> >         int flags = dump ? EAL_DODUMP : EAL_DONTDUMP;
> >         int ret = madvise(virt, size, flags);
> >         if (ret) {
> > -               RTE_LOG(DEBUG, EAL, "madvise(%p, %#zx, %d) failed: %s\n",
> > +               RTE_LOG(INFO, EAL, "madvise(%p, %#zx, %d) failed: %s\n",
> >                                 virt, size, flags, strerror(rte_errno));  
> 
> probably ERR instead of INFO.
> 
> 
> >                 rte_errno = errno;
> > -       }
> > +       } else
> > +               RTE_LOG(INFO, EAL, "madvise(%p, %#zx, %d) success: %s\n",
> > +                               virt, size, flags, __func__);  
> 
> This should be DEBUG. Not INFO.

Usually errors from OS API are reported as DEBUG in EAL,
so the first one should also remain DEBUG.

  reply	other threads:[~2021-12-15 14:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-14 11:41 [PATCH] mem: exclude used memory from core dump by config Gaoxiang Liu
2021-12-14 12:08 ` [PATCH v2] " Gaoxiang Liu
2021-12-14 15:18   ` [PATCH v3] eal: allow to exclude memseg from core dump Gaoxiang Liu
2021-12-15 12:06     ` Jerin Jacob
2021-12-15 14:34       ` Dmitry Kozlyuk [this message]
2021-12-15 15:46     ` Dmitry Kozlyuk
2021-12-14 12:08 ` [PATCH] mem: exclude used memory from core dump by config Jerin Jacob
2021-12-14 12:21   ` Gaoxiang Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211215173455.6e688519@sovereign \
    --to=dmitry.kozliuk@gmail.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=gaoxiangliu0@163.com \
    --cc=jerinjacobk@gmail.com \
    --cc=liugaoxiang@huawei.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).