From: beilei.xing@intel.com
To: jingjing.wu@intel.com
Cc: stable@dpdk.org, Padraig.J.Connolly@intel.com,
dhanya.r.pillai@intel.com, liang-min.wang@intel.com,
Beilei Xing <beilei.xing@intel.com>
Subject: [PATCH] net/i40evf: remove VF reset during initialization
Date: Fri, 17 Dec 2021 15:55:29 +0800 [thread overview]
Message-ID: <20211217075529.5354-1-beilei.xing@intel.com> (raw)
From: Beilei Xing <beilei.xing@intel.com>
VF reset during initialization will cause PF busy when
multiple VFs request virtual channel message from PF.
VF reset is not necessary during initialization, so
remove it.
Fixes: 4861cde46116 ("i40e: new poll mode driver")
Cc: stable@dpdk.org
Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
drivers/net/i40e/i40e_ethdev_vf.c | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index 69cab8e739..7a8c4c2df3 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -1266,24 +1266,6 @@ i40evf_init_vf(struct rte_eth_dev *dev)
goto err;
}
- /* Reset VF and wait until it's complete */
- if (i40evf_reset_vf(dev)) {
- PMD_INIT_LOG(ERR, "reset NIC failed");
- goto err_aq;
- }
-
- /* VF reset, shutdown admin queue and initialize again */
- if (i40e_shutdown_adminq(hw) != I40E_SUCCESS) {
- PMD_INIT_LOG(ERR, "i40e_shutdown_adminq failed");
- goto err;
- }
-
- i40e_init_adminq_parameter(hw);
- if (i40e_init_adminq(hw) != I40E_SUCCESS) {
- PMD_INIT_LOG(ERR, "init_adminq failed");
- goto err;
- }
-
vf->aq_resp = rte_zmalloc("vf_aq_resp", I40E_AQ_BUF_SZ, 0);
if (!vf->aq_resp) {
PMD_INIT_LOG(ERR, "unable to allocate vf_aq_resp memory");
--
2.26.2
reply other threads:[~2021-12-17 8:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211217075529.5354-1-beilei.xing@intel.com \
--to=beilei.xing@intel.com \
--cc=Padraig.J.Connolly@intel.com \
--cc=dhanya.r.pillai@intel.com \
--cc=jingjing.wu@intel.com \
--cc=liang-min.wang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).